From ee67bb37e3ee08bb96fa1b39a3373b0a54cc390b Mon Sep 17 00:00:00 2001 From: "Denis Bilenko (aider)" Date: Tue, 10 Dec 2024 17:26:53 +0100 Subject: [PATCH] refactor: Remove unnecessary error discards from RegisterFlagCompletionFunc calls --- cmd/root/bundle.go | 2 +- cmd/root/logger.go | 6 +++--- cmd/root/progress_logger.go | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/root/bundle.go b/cmd/root/bundle.go index a9521a597..8b98f2cf2 100644 --- a/cmd/root/bundle.go +++ b/cmd/root/bundle.go @@ -146,7 +146,7 @@ func targetCompletion(cmd *cobra.Command, args []string, toComplete string) ([]s func initTargetFlag(cmd *cobra.Command) { // To operate in the context of a bundle, all commands must take an "target" parameter. cmd.PersistentFlags().StringP("target", "t", "", "bundle target to use (if applicable)") - _ = cmd.RegisterFlagCompletionFunc("target", targetCompletion) + cmd.RegisterFlagCompletionFunc("target", targetCompletion) } // DEPRECATED flag diff --git a/cmd/root/logger.go b/cmd/root/logger.go index cd9461822..38e09b9c9 100644 --- a/cmd/root/logger.go +++ b/cmd/root/logger.go @@ -104,8 +104,8 @@ func initLogFlags(cmd *cobra.Command) *logFlags { flags.MarkHidden("log-level") flags.MarkHidden("log-format") - _ = cmd.RegisterFlagCompletionFunc("log-file", f.file.Complete) - _ = cmd.RegisterFlagCompletionFunc("log-level", f.level.Complete) - _ = cmd.RegisterFlagCompletionFunc("log-format", f.output.Complete) + cmd.RegisterFlagCompletionFunc("log-file", f.file.Complete) + cmd.RegisterFlagCompletionFunc("log-level", f.level.Complete) + cmd.RegisterFlagCompletionFunc("log-format", f.output.Complete) return &f } diff --git a/cmd/root/progress_logger.go b/cmd/root/progress_logger.go index cc800d7a2..1458de13a 100644 --- a/cmd/root/progress_logger.go +++ b/cmd/root/progress_logger.go @@ -65,6 +65,6 @@ func initProgressLoggerFlag(cmd *cobra.Command, logFlags *logFlags) *progressLog flags := cmd.PersistentFlags() flags.Var(&f.ProgressLogFormat, "progress-format", "format for progress logs (append, inplace, json)") flags.MarkHidden("progress-format") - _ = cmd.RegisterFlagCompletionFunc("progress-format", f.ProgressLogFormat.Complete) + cmd.RegisterFlagCompletionFunc("progress-format", f.ProgressLogFormat.Complete) return &f }