steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

acc: Do not show all replacements on every failure (#2331) 

## Changes
- Only print replacements if VERBOSE_TEST flag is set.
- This is set on CI but not when you do "go test" or "make test".

Note, env var is used, so that it can be set in Makefile.

## Tests
Manually.
This commit is contained in:
Denis Bilenko 2025-02-11 10:38:53 +01:00 committed by GitHub
parent e81ec4ee23
commit f2096eddcc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Makefile
View File

@ -28,7 +28,7 @@ test:
cover: cover:
rm -fr ./acceptance/build/cover/ rm -fr ./acceptance/build/cover/
CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} -- -coverprofile=coverage.txt ${PACKAGES} VERBOSE_TEST=1 CLI_GOCOVERDIR=build/cover ${GOTESTSUM_CMD} -- -coverprofile=coverage.txt ${PACKAGES}
rm -fr ./acceptance/build/cover-merged/ rm -fr ./acceptance/build/cover-merged/
mkdir -p acceptance/build/cover-merged/ mkdir -p acceptance/build/cover-merged/
go tool covdata merge -i $$(printf '%s,' acceptance/build/cover/* | sed 's/,$$//') -o acceptance/build/cover-merged/ go tool covdata merge -i $$(printf '%s,' acceptance/build/cover/* | sed 's/,$$//') -o acceptance/build/cover-merged/
@ -61,6 +61,6 @@ integration: vendor
$(INTEGRATION) $(INTEGRATION)
integration-short: vendor integration-short: vendor
$(INTEGRATION) -short VERBOSE_TEST=1 $(INTEGRATION) -short
.PHONY: lint tidy lintcheck fmt test cover showcover build snapshot vendor schema integration integration-short acc-cover acc-showcover docs .PHONY: lint tidy lintcheck fmt test cover showcover build snapshot vendor schema integration integration-short acc-cover acc-showcover docs

7
acceptance/acceptance_test.go
View File

@ -30,8 +30,9 @@ import (
) )
var ( var (
KeepTmp bool KeepTmp bool
NoRepl bool NoRepl bool
VerboseTest bool = os.Getenv("VERBOSE_TEST") != ""
) )
// In order to debug CLI running under acceptance test, set this to full subtest name, e.g. "bundle/variables/empty" // In order to debug CLI running under acceptance test, set this to full subtest name, e.g. "bundle/variables/empty"
@ -412,7 +413,7 @@ func doComparison(t *testing.T, repls testdiff.ReplacementsContext, dirRef, dirN
testutil.WriteFile(t, pathRef, valueNew) testutil.WriteFile(t, pathRef, valueNew)
} }
if !equal && printedRepls != nil && !*printedRepls { if VerboseTest && !equal && printedRepls != nil && !*printedRepls {
*printedRepls = true *printedRepls = true
var items []string var items []string
for _, item := range repls.Repls { for _, item := range repls.Repls {