consolidate test configuration

acceptance/telemetry/test.toml

@@ -1,4 +1,6 @@
 IncludeRequestHeaders = ["Authorization"]
+RecordRequests = true
+
 Local = true
 Cloud = false
 
@@ -13,3 +15,12 @@ New = '[OS]'
 [[Repls]]
 Old = 'execution_time_ms\\\":\d{1,5},'
 New = 'execution_time_ms\":\"SMALL_INT\",'
+
+[[Server]]
+Pattern = "POST /telemetry-ext"
+Response.Body = '''
+{
+    "errors": [],
+    "numProtoSuccess": 2
+}
+'''

acceptance/telemetry/upload-command/test.toml

@@ -1,10 +0,0 @@
-RecordRequests = true
-
-[[Server]]
-Pattern = "POST /telemetry-ext"
-Response.Body = '''
-{
-    "errors": [],
-    "numProtoSuccess": 2
-}
-'''

acceptance/telemetry/upload-fails/out.upload_process.txt

@@ -1 +1 @@
-error: upload did not succeed after three attempts. err: &retries.Err{Err:(*apierr.APIError)(0x140003a20a0), Halt:true}. response body: (*telemetry.ResponseBody)(nil)
+error: upload did not succeed after three attempts. err: &retries.Err{Err:(*apierr.APIError)(0x14000361540), Halt:true}. response body: (*telemetry.ResponseBody)(nil)

acceptance/telemetry/upload-fails/test.toml

@@ -1,5 +1,3 @@
-RecordRequests = true
-
 [[Server]]
 Pattern = "POST /telemetry-ext"
 Response.Body = '''
@@ -9,3 +7,5 @@ Response.Body = '''
 }
 '''
 Response.StatusCode = 501
+
+# TODO: Validate that this and the other tests have sane outputs.

acceptance/telemetry/upload-partially-succeeds/test.toml

@@ -1,5 +1,3 @@
-RecordRequests = true
-
 [[Server]]
 Pattern = "POST /telemetry-ext"
 Response.Body = '''

acceptance/telemetry/upload-skipped/test.toml

@@ -1,10 +0,0 @@
-RecordRequests = true
-
-[[Server]]
-Pattern = "POST /telemetry-ext"
-Response.Body = '''
-{
-    "errors": [],
-    "numProtoSuccess": 2
-}
-'''

acceptance/telemetry/upload-succeeds-integration/test.toml

@@ -4,11 +4,4 @@
 Local = true
 Cloud = true
 
-[[Server]]
+RecordRequests = false
-Pattern = "POST /telemetry-ext"
-Response.Body = '''
-{
-    "errors": [],
-    "numProtoSuccess": 2
-}
-'''

acceptance/telemetry/upload-succeeds-oauth/test.toml

@@ -1,15 +1,3 @@
-RecordRequests = true
-
-[[Server]]
-Pattern = "POST /telemetry-ext"
-Response.Body = '''
-{
-    "errors": [],
-    "numProtoSuccess": 2
-}
-'''
-
-
 # "client_id:client_secret" in base64 is Y2xpZW50X2lkOmNsaWVudF9zZWNyZXQ=, expect to
 # see this in Authorization header
 [[Repls]]

acceptance/telemetry/upload-succeeds/test.toml

@@ -1,10 +0,0 @@
-RecordRequests = true
-
-[[Server]]
-Pattern = "POST /telemetry-ext"
-Response.Body = '''
-{
-    "errors": [],
-    "numProtoSuccess": 2
-}
-'''