From f8255f356b152367deb21d557f51401ddc2c19b8 Mon Sep 17 00:00:00 2001 From: Andrew Nester Date: Fri, 2 Jun 2023 14:13:18 +0200 Subject: [PATCH] Added spinner when loading command prompts (#420) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Changes Added spinner when loading command prompts ## Tests ``` andrew.nester@HFW9Y94129 multiples-tasks % cli jobs get-run ⡿ No RUN_ID argument specified. Loading names for Jobs drop-down.``` --- .codegen/service.go.tmpl | 3 ++ cmd/account/budgets/budgets.go | 6 ++++ cmd/account/credentials/credentials.go | 6 ++++ cmd/account/groups/groups.go | 12 +++++++ .../ip-access-lists/ip-access-lists.go | 6 ++++ cmd/account/log-delivery/log-delivery.go | 3 ++ cmd/account/networks/networks.go | 9 +++++ cmd/account/private-access/private-access.go | 6 ++++ .../service-principals/service-principals.go | 12 +++++++ cmd/account/storage/storage.go | 6 ++++ cmd/account/users/users.go | 12 +++++++ cmd/account/vpc-endpoints/vpc-endpoints.go | 9 +++++ cmd/account/workspaces/workspaces.go | 12 +++++++ cmd/workspace/alerts/alerts.go | 6 ++++ .../cluster-policies/cluster-policies.go | 9 +++++ cmd/workspace/clusters/clusters.go | 30 ++++++++++++++++ cmd/workspace/dashboards/dashboards.go | 9 +++++ .../git-credentials/git-credentials.go | 12 +++++++ .../global-init-scripts.go | 6 ++++ cmd/workspace/groups/groups.go | 12 +++++++ .../instance-pools/instance-pools.go | 6 ++++ .../ip-access-lists/ip-access-lists.go | 6 ++++ cmd/workspace/jobs/jobs.go | 34 +++++++++++++++++++ cmd/workspace/metastores/metastores.go | 12 +++++++ .../model-registry/model-registry.go | 4 +-- cmd/workspace/pipelines/pipelines.go | 24 +++++++++++++ cmd/workspace/providers/providers.go | 12 +++++++ cmd/workspace/queries/queries.go | 12 +++++++ cmd/workspace/recipients/recipients.go | 12 +++++++ cmd/workspace/repos/repos.go | 9 +++++ cmd/workspace/schemas/schemas.go | 9 +++++ .../service-principals/service-principals.go | 12 +++++++ cmd/workspace/tables/tables.go | 9 +++++ .../token-management/token-management.go | 6 ++++ cmd/workspace/tokens/tokens.go | 3 ++ cmd/workspace/users/users.go | 12 +++++++ cmd/workspace/volumes/volumes.go | 9 +++++ cmd/workspace/warehouses/warehouses.go | 15 ++++++++ cmd/workspace/workspace/workspace.go | 15 ++++++++ 39 files changed, 405 insertions(+), 2 deletions(-) diff --git a/.codegen/service.go.tmpl b/.codegen/service.go.tmpl index 3cc1943f..72aea370 100644 --- a/.codegen/service.go.tmpl +++ b/.codegen/service.go.tmpl @@ -96,7 +96,10 @@ var {{.CamelName}}Cmd = &cobra.Command{ } else { {{- if $hasIdPrompt}} if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No{{range .Request.RequiredFields}} {{.ConstantName}}{{end}} argument specified. Loading names for {{.Service.TitleName}} drop-down." names, err := {{if .Service.IsAccounts}}a{{else}}w{{end}}.{{(.Service.TrimPrefix "account").PascalName}}.{{.Service.List.NamedIdMap.PascalName}}(ctx{{if .Service.List.Request}}, {{.Service.Package.Name}}.{{.Service.List.Request.PascalName}}{}{{end}}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/budgets/budgets.go b/cmd/account/budgets/budgets.go index dedcdd80..8edbe0a6 100755 --- a/cmd/account/budgets/budgets.go +++ b/cmd/account/budgets/budgets.go @@ -94,7 +94,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No BUDGET_ID argument specified. Loading names for Budgets drop-down." names, err := a.Budgets.BudgetWithStatusNameToBudgetIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -150,7 +153,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No BUDGET_ID argument specified. Loading names for Budgets drop-down." names, err := a.Budgets.BudgetWithStatusNameToBudgetIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/credentials/credentials.go b/cmd/account/credentials/credentials.go index 1f3f5261..81f58770 100755 --- a/cmd/account/credentials/credentials.go +++ b/cmd/account/credentials/credentials.go @@ -113,7 +113,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CREDENTIALS_ID argument specified. Loading names for Credentials drop-down." names, err := a.Credentials.CredentialCredentialsNameToCredentialsIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -169,7 +172,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CREDENTIALS_ID argument specified. Loading names for Credentials drop-down." names, err := a.Credentials.CredentialCredentialsNameToCredentialsIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/groups/groups.go b/cmd/account/groups/groups.go index f76711d0..143bbf92 100755 --- a/cmd/account/groups/groups.go +++ b/cmd/account/groups/groups.go @@ -111,7 +111,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Groups drop-down." names, err := a.Groups.GroupDisplayNameToIdMap(ctx, iam.ListAccountGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -166,7 +169,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Groups drop-down." names, err := a.Groups.GroupDisplayNameToIdMap(ctx, iam.ListAccountGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -278,7 +284,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Groups drop-down." names, err := a.Groups.GroupDisplayNameToIdMap(ctx, iam.ListAccountGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -341,7 +350,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Groups drop-down." names, err := a.Groups.GroupDisplayNameToIdMap(ctx, iam.ListAccountGroupsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/ip-access-lists/ip-access-lists.go b/cmd/account/ip-access-lists/ip-access-lists.go index e525c57e..d52917af 100755 --- a/cmd/account/ip-access-lists/ip-access-lists.go +++ b/cmd/account/ip-access-lists/ip-access-lists.go @@ -132,7 +132,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No IP_ACCESS_LIST_ID argument specified. Loading names for Account Ip Access Lists drop-down." names, err := a.IpAccessLists.IpAccessListInfoLabelToListIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -187,7 +190,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No IP_ACCESS_LIST_ID argument specified. Loading names for Account Ip Access Lists drop-down." names, err := a.IpAccessLists.IpAccessListInfoLabelToListIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/log-delivery/log-delivery.go b/cmd/account/log-delivery/log-delivery.go index a38a661a..a20972ce 100755 --- a/cmd/account/log-delivery/log-delivery.go +++ b/cmd/account/log-delivery/log-delivery.go @@ -183,7 +183,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No LOG_DELIVERY_CONFIGURATION_ID argument specified. Loading names for Log Delivery drop-down." names, err := a.LogDelivery.LogDeliveryConfigurationConfigNameToConfigIdMap(ctx, billing.ListLogDeliveryRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/networks/networks.go b/cmd/account/networks/networks.go index 04355e5a..9a0b7739 100755 --- a/cmd/account/networks/networks.go +++ b/cmd/account/networks/networks.go @@ -58,7 +58,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NETWORK_NAME argument specified. Loading names for Networks drop-down." names, err := a.Networks.NetworkNetworkNameToNetworkIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -118,7 +121,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NETWORK_ID argument specified. Loading names for Networks drop-down." names, err := a.Networks.NetworkNetworkNameToNetworkIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -174,7 +180,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NETWORK_ID argument specified. Loading names for Networks drop-down." names, err := a.Networks.NetworkNetworkNameToNetworkIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/private-access/private-access.go b/cmd/account/private-access/private-access.go index e7235f37..0a6f06e5 100755 --- a/cmd/account/private-access/private-access.go +++ b/cmd/account/private-access/private-access.go @@ -123,7 +123,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PRIVATE_ACCESS_SETTINGS_ID argument specified. Loading names for Private Access drop-down." names, err := a.PrivateAccess.PrivateAccessSettingsPrivateAccessSettingsNameToPrivateAccessSettingsIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -185,7 +188,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PRIVATE_ACCESS_SETTINGS_ID argument specified. Loading names for Private Access drop-down." names, err := a.PrivateAccess.PrivateAccessSettingsPrivateAccessSettingsNameToPrivateAccessSettingsIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/service-principals/service-principals.go b/cmd/account/service-principals/service-principals.go index 6432ed2d..f2bce37a 100755 --- a/cmd/account/service-principals/service-principals.go +++ b/cmd/account/service-principals/service-principals.go @@ -110,7 +110,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Service Principals drop-down." names, err := a.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListAccountServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -166,7 +169,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Service Principals drop-down." names, err := a.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListAccountServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -279,7 +285,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Service Principals drop-down." names, err := a.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListAccountServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -345,7 +354,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Service Principals drop-down." names, err := a.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListAccountServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/storage/storage.go b/cmd/account/storage/storage.go index a8512ffa..023d5894 100755 --- a/cmd/account/storage/storage.go +++ b/cmd/account/storage/storage.go @@ -109,7 +109,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No STORAGE_CONFIGURATION_ID argument specified. Loading names for Storage drop-down." names, err := a.Storage.StorageConfigurationStorageConfigurationNameToStorageConfigurationIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -164,7 +167,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No STORAGE_CONFIGURATION_ID argument specified. Loading names for Storage drop-down." names, err := a.Storage.StorageConfigurationStorageConfigurationNameToStorageConfigurationIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/users/users.go b/cmd/account/users/users.go index 6ccb39f5..faf240d8 100755 --- a/cmd/account/users/users.go +++ b/cmd/account/users/users.go @@ -119,7 +119,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Users drop-down." names, err := a.Users.UserUserNameToIdMap(ctx, iam.ListAccountUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -174,7 +177,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Users drop-down." names, err := a.Users.UserUserNameToIdMap(ctx, iam.ListAccountUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -287,7 +293,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Users drop-down." names, err := a.Users.UserUserNameToIdMap(ctx, iam.ListAccountUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -353,7 +362,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Account Users drop-down." names, err := a.Users.UserUserNameToIdMap(ctx, iam.ListAccountUsersRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/vpc-endpoints/vpc-endpoints.go b/cmd/account/vpc-endpoints/vpc-endpoints.go index 0572c44c..295d7621 100755 --- a/cmd/account/vpc-endpoints/vpc-endpoints.go +++ b/cmd/account/vpc-endpoints/vpc-endpoints.go @@ -65,7 +65,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No VPC_ENDPOINT_NAME argument specified. Loading names for Vpc Endpoints drop-down." names, err := a.VpcEndpoints.VpcEndpointVpcEndpointNameToVpcEndpointIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -128,7 +131,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No VPC_ENDPOINT_ID argument specified. Loading names for Vpc Endpoints drop-down." names, err := a.VpcEndpoints.VpcEndpointVpcEndpointNameToVpcEndpointIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -187,7 +193,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No VPC_ENDPOINT_ID argument specified. Loading names for Vpc Endpoints drop-down." names, err := a.VpcEndpoints.VpcEndpointVpcEndpointNameToVpcEndpointIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/account/workspaces/workspaces.go b/cmd/account/workspaces/workspaces.go index f611fa8d..4dbfe24e 100755 --- a/cmd/account/workspaces/workspaces.go +++ b/cmd/account/workspaces/workspaces.go @@ -84,7 +84,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No WORKSPACE_NAME argument specified. Loading names for Workspaces drop-down." names, err := a.Workspaces.WorkspaceWorkspaceNameToWorkspaceIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -163,7 +166,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No WORKSPACE_ID argument specified. Loading names for Workspaces drop-down." names, err := a.Workspaces.WorkspaceWorkspaceNameToWorkspaceIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -234,7 +240,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No WORKSPACE_ID argument specified. Loading names for Workspaces drop-down." names, err := a.Workspaces.WorkspaceWorkspaceNameToWorkspaceIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -445,7 +454,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No WORKSPACE_ID argument specified. Loading names for Workspaces drop-down." names, err := a.Workspaces.WorkspaceWorkspaceNameToWorkspaceIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/alerts/alerts.go b/cmd/workspace/alerts/alerts.go index cd52408f..e1485d31 100755 --- a/cmd/workspace/alerts/alerts.go +++ b/cmd/workspace/alerts/alerts.go @@ -106,7 +106,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ALERT_ID argument specified. Loading names for Alerts drop-down." names, err := w.Alerts.AlertNameToIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -161,7 +164,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ALERT_ID argument specified. Loading names for Alerts drop-down." names, err := w.Alerts.AlertNameToIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/cluster-policies/cluster-policies.go b/cmd/workspace/cluster-policies/cluster-policies.go index 7fbdce9b..dce0a604 100755 --- a/cmd/workspace/cluster-policies/cluster-policies.go +++ b/cmd/workspace/cluster-policies/cluster-policies.go @@ -78,7 +78,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Cluster Policies drop-down." names, err := w.ClusterPolicies.PolicyNameToPolicyIdMap(ctx, compute.ListClusterPoliciesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -134,7 +137,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No POLICY_ID argument specified. Loading names for Cluster Policies drop-down." names, err := w.ClusterPolicies.PolicyNameToPolicyIdMap(ctx, compute.ListClusterPoliciesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -245,7 +251,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No POLICY_ID argument specified. Loading names for Cluster Policies drop-down." names, err := w.ClusterPolicies.PolicyNameToPolicyIdMap(ctx, compute.ListClusterPoliciesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/clusters/clusters.go b/cmd/workspace/clusters/clusters.go index d609f573..10155161 100755 --- a/cmd/workspace/clusters/clusters.go +++ b/cmd/workspace/clusters/clusters.go @@ -169,7 +169,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No SPARK_VERSION argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -249,7 +252,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -437,7 +443,10 @@ var eventsCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -498,7 +507,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -671,7 +683,10 @@ var permanentDeleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -728,7 +743,10 @@ var pinCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -792,7 +810,10 @@ var resizeCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -872,7 +893,10 @@ var restartCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -984,7 +1008,10 @@ var startCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -1058,7 +1085,10 @@ var unpinCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CLUSTER_ID argument specified. Loading names for Clusters drop-down." names, err := w.Clusters.ClusterInfoClusterNameToClusterIdMap(ctx, compute.ListClustersRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/dashboards/dashboards.go b/cmd/workspace/dashboards/dashboards.go index b2f21d57..b7b1fa1c 100755 --- a/cmd/workspace/dashboards/dashboards.go +++ b/cmd/workspace/dashboards/dashboards.go @@ -105,7 +105,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No DASHBOARD_ID argument specified. Loading names for Dashboards drop-down." names, err := w.Dashboards.DashboardNameToIdMap(ctx, sql.ListDashboardsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -161,7 +164,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No DASHBOARD_ID argument specified. Loading names for Dashboards drop-down." names, err := w.Dashboards.DashboardNameToIdMap(ctx, sql.ListDashboardsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -268,7 +274,10 @@ var restoreCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No DASHBOARD_ID argument specified. Loading names for Dashboards drop-down." names, err := w.Dashboards.DashboardNameToIdMap(ctx, sql.ListDashboardsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/git-credentials/git-credentials.go b/cmd/workspace/git-credentials/git-credentials.go index 3cad2847..ea7242da 100755 --- a/cmd/workspace/git-credentials/git-credentials.go +++ b/cmd/workspace/git-credentials/git-credentials.go @@ -60,7 +60,10 @@ var createCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No GIT_PROVIDER argument specified. Loading names for Git Credentials drop-down." names, err := w.GitCredentials.CredentialInfoGitProviderToCredentialIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -115,7 +118,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CREDENTIAL_ID argument specified. Loading names for Git Credentials drop-down." names, err := w.GitCredentials.CredentialInfoGitProviderToCredentialIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -173,7 +179,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CREDENTIAL_ID argument specified. Loading names for Git Credentials drop-down." names, err := w.GitCredentials.CredentialInfoGitProviderToCredentialIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -263,7 +272,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CREDENTIAL_ID argument specified. Loading names for Git Credentials drop-down." names, err := w.GitCredentials.CredentialInfoGitProviderToCredentialIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/global-init-scripts/global-init-scripts.go b/cmd/workspace/global-init-scripts/global-init-scripts.go index 9df0596a..090a2b35 100755 --- a/cmd/workspace/global-init-scripts/global-init-scripts.go +++ b/cmd/workspace/global-init-scripts/global-init-scripts.go @@ -109,7 +109,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No SCRIPT_ID argument specified. Loading names for Global Init Scripts drop-down." names, err := w.GlobalInitScripts.GlobalInitScriptDetailsNameToScriptIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -164,7 +167,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No SCRIPT_ID argument specified. Loading names for Global Init Scripts drop-down." names, err := w.GlobalInitScripts.GlobalInitScriptDetailsNameToScriptIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/groups/groups.go b/cmd/workspace/groups/groups.go index 3bfc83db..9f85cdf3 100755 --- a/cmd/workspace/groups/groups.go +++ b/cmd/workspace/groups/groups.go @@ -111,7 +111,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Groups drop-down." names, err := w.Groups.GroupDisplayNameToIdMap(ctx, iam.ListGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -166,7 +169,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Groups drop-down." names, err := w.Groups.GroupDisplayNameToIdMap(ctx, iam.ListGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -278,7 +284,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Groups drop-down." names, err := w.Groups.GroupDisplayNameToIdMap(ctx, iam.ListGroupsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -341,7 +350,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Groups drop-down." names, err := w.Groups.GroupDisplayNameToIdMap(ctx, iam.ListGroupsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/instance-pools/instance-pools.go b/cmd/workspace/instance-pools/instance-pools.go index 7d39cfd8..d78ae939 100755 --- a/cmd/workspace/instance-pools/instance-pools.go +++ b/cmd/workspace/instance-pools/instance-pools.go @@ -128,7 +128,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No INSTANCE_POOL_ID argument specified. Loading names for Instance Pools drop-down." names, err := w.InstancePools.InstancePoolAndStatsInstancePoolNameToInstancePoolIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -245,7 +248,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No INSTANCE_POOL_ID argument specified. Loading names for Instance Pools drop-down." names, err := w.InstancePools.InstancePoolAndStatsInstancePoolNameToInstancePoolIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/ip-access-lists/ip-access-lists.go b/cmd/workspace/ip-access-lists/ip-access-lists.go index 6e46c47b..e2933974 100755 --- a/cmd/workspace/ip-access-lists/ip-access-lists.go +++ b/cmd/workspace/ip-access-lists/ip-access-lists.go @@ -133,7 +133,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No IP_ACCESS_LIST_ID argument specified. Loading names for Ip Access Lists drop-down." names, err := w.IpAccessLists.IpAccessListInfoLabelToListIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -188,7 +191,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No IP_ACCESS_LIST_ID argument specified. Loading names for Ip Access Lists drop-down." names, err := w.IpAccessLists.IpAccessListInfoLabelToListIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/jobs/jobs.go b/cmd/workspace/jobs/jobs.go index 2d8dbd0d..601293ee 100755 --- a/cmd/workspace/jobs/jobs.go +++ b/cmd/workspace/jobs/jobs.go @@ -69,7 +69,10 @@ var cancelAllRunsCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No JOB_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -133,7 +136,10 @@ var cancelRunCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -203,6 +209,7 @@ func init() { createCmd.Flags().IntVar(&createReq.MaxConcurrentRuns, "max-concurrent-runs", createReq.MaxConcurrentRuns, `An optional maximum allowed number of concurrent runs of the job.`) createCmd.Flags().StringVar(&createReq.Name, "name", createReq.Name, `An optional name for the job.`) // TODO: complex arg: notification_settings + // TODO: complex arg: run_as // TODO: complex arg: schedule // TODO: map via StringToStringVar: tags // TODO: array: tasks @@ -278,7 +285,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No JOB_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -336,7 +346,10 @@ var deleteRunCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -396,7 +409,10 @@ var exportRunCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -454,7 +470,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No JOB_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -519,7 +538,10 @@ var getRunCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -586,7 +608,10 @@ var getRunOutputCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -772,7 +797,10 @@ var repairRunCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No RUN_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -918,7 +946,10 @@ var runNowCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No JOB_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -1092,7 +1123,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No JOB_ID argument specified. Loading names for Jobs drop-down." names, err := w.Jobs.BaseJobSettingsNameToJobIdMap(ctx, jobs.ListJobsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/metastores/metastores.go b/cmd/workspace/metastores/metastores.go index f1cc68e6..589140a0 100755 --- a/cmd/workspace/metastores/metastores.go +++ b/cmd/workspace/metastores/metastores.go @@ -196,7 +196,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Metastores drop-down." names, err := w.Metastores.MetastoreInfoNameToMetastoreIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -252,7 +255,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Metastores drop-down." names, err := w.Metastores.MetastoreInfoNameToMetastoreIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -477,7 +483,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Metastores drop-down." names, err := w.Metastores.MetastoreInfoNameToMetastoreIdMap(ctx) + close(promptSpinner) if err != nil { return err } @@ -538,7 +547,10 @@ var updateAssignmentCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No WORKSPACE_ID argument specified. Loading names for Metastores drop-down." names, err := w.Metastores.MetastoreInfoNameToMetastoreIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/model-registry/model-registry.go b/cmd/workspace/model-registry/model-registry.go index 3bda9e6f..1bfff481 100755 --- a/cmd/workspace/model-registry/model-registry.go +++ b/cmd/workspace/model-registry/model-registry.go @@ -605,8 +605,8 @@ func init() { var deleteTransitionRequestCmd = &cobra.Command{ Use: "delete-transition-request NAME VERSION STAGE CREATOR", - Short: `Delete a ransition request.`, - Long: `Delete a ransition request. + Short: `Delete a transition request.`, + Long: `Delete a transition request. Cancels a model version stage transition request.`, diff --git a/cmd/workspace/pipelines/pipelines.go b/cmd/workspace/pipelines/pipelines.go index b65af4d7..1d287174 100755 --- a/cmd/workspace/pipelines/pipelines.go +++ b/cmd/workspace/pipelines/pipelines.go @@ -131,7 +131,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -189,7 +192,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -298,7 +304,10 @@ var listPipelineEventsCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -409,7 +418,10 @@ var listUpdatesCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -469,7 +481,10 @@ var resetCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -546,7 +561,10 @@ var startUpdateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -606,7 +624,10 @@ var stopCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -698,7 +719,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PIPELINE_ID argument specified. Loading names for Pipelines drop-down." names, err := w.Pipelines.PipelineStateInfoNameToPipelineIdMap(ctx, pipelines.ListPipelinesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/providers/providers.go b/cmd/workspace/providers/providers.go index 21a85ff1..c9dd3cd0 100755 --- a/cmd/workspace/providers/providers.go +++ b/cmd/workspace/providers/providers.go @@ -106,7 +106,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Providers drop-down." names, err := w.Providers.ProviderInfoNameToMetastoreIdMap(ctx, sharing.ListProvidersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -163,7 +166,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Providers drop-down." names, err := w.Providers.ProviderInfoNameToMetastoreIdMap(ctx, sharing.ListProvidersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -272,7 +278,10 @@ var listSharesCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Providers drop-down." names, err := w.Providers.ProviderInfoNameToMetastoreIdMap(ctx, sharing.ListProvidersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -335,7 +344,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Providers drop-down." names, err := w.Providers.ProviderInfoNameToMetastoreIdMap(ctx, sharing.ListProvidersRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/queries/queries.go b/cmd/workspace/queries/queries.go index 1c81c704..fa83408a 100755 --- a/cmd/workspace/queries/queries.go +++ b/cmd/workspace/queries/queries.go @@ -116,7 +116,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No QUERY_ID argument specified. Loading names for Queries drop-down." names, err := w.Queries.QueryNameToIdMap(ctx, sql.ListQueriesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -172,7 +175,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No QUERY_ID argument specified. Loading names for Queries drop-down." names, err := w.Queries.QueryNameToIdMap(ctx, sql.ListQueriesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -281,7 +287,10 @@ var restoreCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No QUERY_ID argument specified. Loading names for Queries drop-down." names, err := w.Queries.QueryNameToIdMap(ctx, sql.ListQueriesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -344,7 +353,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No QUERY_ID argument specified. Loading names for Queries drop-down." names, err := w.Queries.QueryNameToIdMap(ctx, sql.ListQueriesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/recipients/recipients.go b/cmd/workspace/recipients/recipients.go index 6ccbece9..2f907a6d 100755 --- a/cmd/workspace/recipients/recipients.go +++ b/cmd/workspace/recipients/recipients.go @@ -111,7 +111,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Recipients drop-down." names, err := w.Recipients.RecipientInfoNameToMetastoreIdMap(ctx, sharing.ListRecipientsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -168,7 +171,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Recipients drop-down." names, err := w.Recipients.RecipientInfoNameToMetastoreIdMap(ctx, sharing.ListRecipientsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -329,7 +335,10 @@ var sharePermissionsCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Recipients drop-down." names, err := w.Recipients.RecipientInfoNameToMetastoreIdMap(ctx, sharing.ListRecipientsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -392,7 +401,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No NAME argument specified. Loading names for Recipients drop-down." names, err := w.Recipients.RecipientInfoNameToMetastoreIdMap(ctx, sharing.ListRecipientsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/repos/repos.go b/cmd/workspace/repos/repos.go index 403c8a95..d3e95fc7 100755 --- a/cmd/workspace/repos/repos.go +++ b/cmd/workspace/repos/repos.go @@ -112,7 +112,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No REPO_ID argument specified. Loading names for Repos drop-down." names, err := w.Repos.RepoInfoPathToIdMap(ctx, workspace.ListReposRequest{}) + close(promptSpinner) if err != nil { return err } @@ -170,7 +173,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No REPO_ID argument specified. Loading names for Repos drop-down." names, err := w.Repos.RepoInfoPathToIdMap(ctx, workspace.ListReposRequest{}) + close(promptSpinner) if err != nil { return err } @@ -284,7 +290,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No REPO_ID argument specified. Loading names for Repos drop-down." names, err := w.Repos.RepoInfoPathToIdMap(ctx, workspace.ListReposRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/schemas/schemas.go b/cmd/workspace/schemas/schemas.go index 16e0387a..c4bce9dd 100755 --- a/cmd/workspace/schemas/schemas.go +++ b/cmd/workspace/schemas/schemas.go @@ -109,7 +109,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME argument specified. Loading names for Schemas drop-down." names, err := w.Schemas.SchemaInfoNameToFullNameMap(ctx, catalog.ListSchemasRequest{}) + close(promptSpinner) if err != nil { return err } @@ -166,7 +169,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME argument specified. Loading names for Schemas drop-down." names, err := w.Schemas.SchemaInfoNameToFullNameMap(ctx, catalog.ListSchemasRequest{}) + close(promptSpinner) if err != nil { return err } @@ -282,7 +288,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME argument specified. Loading names for Schemas drop-down." names, err := w.Schemas.SchemaInfoNameToFullNameMap(ctx, catalog.ListSchemasRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/service-principals/service-principals.go b/cmd/workspace/service-principals/service-principals.go index 675ce899..ea52d52a 100755 --- a/cmd/workspace/service-principals/service-principals.go +++ b/cmd/workspace/service-principals/service-principals.go @@ -110,7 +110,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Service Principals drop-down." names, err := w.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -166,7 +169,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Service Principals drop-down." names, err := w.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -279,7 +285,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Service Principals drop-down." names, err := w.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } @@ -345,7 +354,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Service Principals drop-down." names, err := w.ServicePrincipals.ServicePrincipalDisplayNameToIdMap(ctx, iam.ListServicePrincipalsRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/tables/tables.go b/cmd/workspace/tables/tables.go index 622cbe8a..c4f0dd80 100755 --- a/cmd/workspace/tables/tables.go +++ b/cmd/workspace/tables/tables.go @@ -61,7 +61,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME argument specified. Loading names for Tables drop-down." names, err := w.Tables.TableInfoNameToTableIdMap(ctx, catalog.ListTablesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -122,7 +125,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME argument specified. Loading names for Tables drop-down." names, err := w.Tables.TableInfoNameToTableIdMap(ctx, catalog.ListTablesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -250,7 +256,10 @@ var listSummariesCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No CATALOG_NAME argument specified. Loading names for Tables drop-down." names, err := w.Tables.TableInfoNameToTableIdMap(ctx, catalog.ListTablesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/token-management/token-management.go b/cmd/workspace/token-management/token-management.go index 9e7f5614..03c32b59 100755 --- a/cmd/workspace/token-management/token-management.go +++ b/cmd/workspace/token-management/token-management.go @@ -105,7 +105,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No TOKEN_ID argument specified. Loading names for Token Management drop-down." names, err := w.TokenManagement.TokenInfoCommentToTokenIdMap(ctx, settings.ListTokenManagementRequest{}) + close(promptSpinner) if err != nil { return err } @@ -160,7 +163,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No TOKEN_ID argument specified. Loading names for Token Management drop-down." names, err := w.TokenManagement.TokenInfoCommentToTokenIdMap(ctx, settings.ListTokenManagementRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/tokens/tokens.go b/cmd/workspace/tokens/tokens.go index ad829a6a..359f1afd 100755 --- a/cmd/workspace/tokens/tokens.go +++ b/cmd/workspace/tokens/tokens.go @@ -106,7 +106,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No TOKEN_ID argument specified. Loading names for Tokens drop-down." names, err := w.Tokens.TokenInfoCommentToTokenIdMap(ctx) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/users/users.go b/cmd/workspace/users/users.go index fcafde2d..fec18927 100755 --- a/cmd/workspace/users/users.go +++ b/cmd/workspace/users/users.go @@ -119,7 +119,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Users drop-down." names, err := w.Users.UserUserNameToIdMap(ctx, iam.ListUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -174,7 +177,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Users drop-down." names, err := w.Users.UserUserNameToIdMap(ctx, iam.ListUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -287,7 +293,10 @@ var patchCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Users drop-down." names, err := w.Users.UserUserNameToIdMap(ctx, iam.ListUsersRequest{}) + close(promptSpinner) if err != nil { return err } @@ -353,7 +362,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Users drop-down." names, err := w.Users.UserUserNameToIdMap(ctx, iam.ListUsersRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/volumes/volumes.go b/cmd/workspace/volumes/volumes.go index 3484e227..8364850d 100755 --- a/cmd/workspace/volumes/volumes.go +++ b/cmd/workspace/volumes/volumes.go @@ -134,7 +134,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME_ARG argument specified. Loading names for Volumes drop-down." names, err := w.Volumes.VolumeInfoNameToVolumeIdMap(ctx, catalog.ListVolumesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -253,7 +256,10 @@ var readCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME_ARG argument specified. Loading names for Volumes drop-down." names, err := w.Volumes.VolumeInfoNameToVolumeIdMap(ctx, catalog.ListVolumesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -319,7 +325,10 @@ var updateCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No FULL_NAME_ARG argument specified. Loading names for Volumes drop-down." names, err := w.Volumes.VolumeInfoNameToVolumeIdMap(ctx, catalog.ListVolumesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/warehouses/warehouses.go b/cmd/workspace/warehouses/warehouses.go index bc862101..ad8ef1c7 100755 --- a/cmd/workspace/warehouses/warehouses.go +++ b/cmd/workspace/warehouses/warehouses.go @@ -148,7 +148,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Warehouses drop-down." names, err := w.Warehouses.EndpointInfoNameToIdMap(ctx, sql.ListWarehousesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -246,7 +249,10 @@ var editCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Warehouses drop-down." names, err := w.Warehouses.EndpointInfoNameToIdMap(ctx, sql.ListWarehousesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -330,7 +336,10 @@ var getCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Warehouses drop-down." names, err := w.Warehouses.EndpointInfoNameToIdMap(ctx, sql.ListWarehousesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -525,7 +534,10 @@ var startCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Warehouses drop-down." names, err := w.Warehouses.EndpointInfoNameToIdMap(ctx, sql.ListWarehousesRequest{}) + close(promptSpinner) if err != nil { return err } @@ -609,7 +621,10 @@ var stopCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No ID argument specified. Loading names for Warehouses drop-down." names, err := w.Warehouses.EndpointInfoNameToIdMap(ctx, sql.ListWarehousesRequest{}) + close(promptSpinner) if err != nil { return err } diff --git a/cmd/workspace/workspace/workspace.go b/cmd/workspace/workspace/workspace.go index 04623424..03598c5f 100755 --- a/cmd/workspace/workspace/workspace.go +++ b/cmd/workspace/workspace/workspace.go @@ -62,7 +62,10 @@ var deleteCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PATH argument specified. Loading names for Workspace drop-down." names, err := w.Workspace.ObjectInfoPathToObjectIdMap(ctx, workspace.ListWorkspaceRequest{}) + close(promptSpinner) if err != nil { return err } @@ -127,7 +130,10 @@ var exportCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PATH argument specified. Loading names for Workspace drop-down." names, err := w.Workspace.ObjectInfoPathToObjectIdMap(ctx, workspace.ListWorkspaceRequest{}) + close(promptSpinner) if err != nil { return err } @@ -183,7 +189,10 @@ var getStatusCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PATH argument specified. Loading names for Workspace drop-down." names, err := w.Workspace.ObjectInfoPathToObjectIdMap(ctx, workspace.ListWorkspaceRequest{}) + close(promptSpinner) if err != nil { return err } @@ -246,7 +255,10 @@ var importCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PATH argument specified. Loading names for Workspace drop-down." names, err := w.Workspace.ObjectInfoPathToObjectIdMap(ctx, workspace.ListWorkspaceRequest{}) + close(promptSpinner) if err != nil { return err } @@ -358,7 +370,10 @@ var mkdirsCmd = &cobra.Command{ } } else { if len(args) == 0 { + promptSpinner := cmdio.Spinner(ctx) + promptSpinner <- "No PATH argument specified. Loading names for Workspace drop-down." names, err := w.Workspace.ObjectInfoPathToObjectIdMap(ctx, workspace.ListWorkspaceRequest{}) + close(promptSpinner) if err != nil { return err }