steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add comment for why we test two files for `bundle_uuid` (#1949) 

## Changes
Addresses feedback from this thread
https://github.com/databricks/cli/pull/1947#discussion_r1865692479
This commit is contained in:
shreyas-goenka 2024-12-02 20:10:57 +05:30 committed by GitHub
parent 94b221b8ba
commit f9d65f315f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libs/template/helpers_test.go
View File

@ -43,11 +43,16 @@ func TestTemplateBundleUuidFunction(t *testing.T) {
err = r.walk() err = r.walk()
assert.NoError(t, err) assert.NoError(t, err)
// We test the content of two generated files to ensure that the same UUID
// is used across all files generated by the template. Each file content is
// generated by a separate (*template.Template).Execute call, so testing different
// files ensures that the UUID is stable across all template execution calls.
copy := strings.Clone(bundleUuid)
assert.Len(t, r.files, 2) assert.Len(t, r.files, 2)
c1 := strings.Trim(string(r.files[0].(*inMemoryFile).content), "\n\r") c1 := strings.Trim(string(r.files[0].(*inMemoryFile).content), "\n\r")
assert.Equal(t, strings.Repeat(bundleUuid, 3), c1) assert.Equal(t, strings.Repeat(copy, 3), c1)
c2 := strings.Trim(string(r.files[1].(*inMemoryFile).content), "\n\r") c2 := strings.Trim(string(r.files[1].(*inMemoryFile).content), "\n\r")
assert.Equal(t, strings.Repeat(bundleUuid, 5), c2) assert.Equal(t, strings.Repeat(copy, 5), c2)
} }
func TestTemplateRegexpCompileFunction(t *testing.T) { func TestTemplateRegexpCompileFunction(t *testing.T) {