databricks-cli

Commit Graph

Author	SHA1	Message	Date
Denis Bilenko	2fee243586	Fix finding Python within virtualenv on Windows (#2034 ) ## Changes Simplify logic for selecting Python to run when calculating default whl build command: "python" on Windows and "python3" everywhere. Python installers from python.org do not install python3.exe. In virtualenv there is no python3.exe. ## Tests Added new unit tests to create real venv with uv and simulate activation by prepending venv/bin to PATH.	2024-12-20 07:45:32 +00:00
Denis Bilenko	2e018cfaec	Enable gofumpt and goimports in golangci-lint (#1999 ) ## Changes Enable gofumpt and goimports in golangci-lint and apply autofix. This makes 'make fmt' redundant, will be cleaned up in follow up diff. ## Tests Existing tests.	2024-12-12 10:28:42 +01:00
Gleb Kanterov	44902fa350	Make `pydabs/venv_path` optional (#1687 ) ## Changes Make `pydabs/venv_path` optional. When not specified, CLI detects the Python interpreter using `python.DetectExecutable`, the same way as for `artifacts`. `python.DetectExecutable` works correctly if a virtual environment is activated or `python3` is available on PATH through other means. Extract the venv detection code from PyDABs into `libs/python/detect`. This code will be used when we implement the `python/venv_path` section in `databricks.yml`. ## Tests Unit tests and manually --------- Co-authored-by: Pieter Noordhuis <pcnoordhuis@gmail.com>	2024-08-20 13:26:57 +00:00

Author

SHA1

Message

Date

Denis Bilenko

2fee243586

Fix finding Python within virtualenv on Windows (#2034 )

## Changes
Simplify logic for selecting Python to run when calculating default whl
build command: "python" on Windows and "python3" everywhere.

Python installers from python.org do not install python3.exe. In
virtualenv there is no python3.exe.

## Tests
Added new unit tests to create real venv with uv and simulate activation
by prepending venv/bin to PATH.

2024-12-20 07:45:32 +00:00

Denis Bilenko

2e018cfaec

Enable gofumpt and goimports in golangci-lint (#1999 )

## Changes
Enable gofumpt and goimports in golangci-lint and apply autofix.

This makes 'make fmt' redundant, will be cleaned up in follow up diff.

## Tests
Existing tests.

2024-12-12 10:28:42 +01:00

Gleb Kanterov

44902fa350

Make `pydabs/venv_path` optional (#1687 )

## Changes
Make `pydabs/venv_path` optional. When not specified, CLI detects the
Python interpreter using `python.DetectExecutable`, the same way as for
`artifacts`. `python.DetectExecutable` works correctly if a virtual
environment is activated or `python3` is available on PATH through other
means.

Extract the venv detection code from PyDABs into `libs/python/detect`.
This code will be used when we implement the `python/venv_path` section
in `databricks.yml`.

## Tests
Unit tests and manually

---------

Co-authored-by: Pieter Noordhuis <pcnoordhuis@gmail.com>

2024-08-20 13:26:57 +00:00

3 Commits