databricks-cli

Commit Graph

Author	SHA1	Message	Date
shreyas-goenka	55c03cc119	Always close test HTTP server during cleanup (#2261 ) ## Changes This PR registers the `server.Close()` function to be run during test cleanup in the server initialization function. This ensures that all test servers are closed as soon as the test they are scoped to finish. Motivated by https://github.com/databricks/cli/pull/2255/files where a regression was introduced where we did not close the test server. ## Tests N/A	2025-01-29 15:54:33 +00:00
shreyas-goenka	124515e8d2	Move TestServer from acceptance to libs/testserver (#2255 ) ## Changes Just a move, no changes. As recommended here: https://github.com/databricks/cli/pull/2226#discussion_r1932152627 ## Tests N/A	2025-01-29 10:42:21 +00:00
Denis Bilenko	3a32c63919	Add -inprocess mode for acceptance tests (#2184 ) ## Changes - If you pass -inprocess flag to acceptance tests, they will run in the same process as test itself. This enables debugging. - If you set singleTest variable on top of acceptance_test.go, you'll only run that test and with inprocess mode. This is intended for debugging in VSCode. - (minor) Converted KeepTmp to flag -keeptmp from env var KEEP_TMP for consistency with other flags. ## Tests - I verified that acceptance tests pass with -inprocess mode: `go test -inprocess < /dev/null \| cat` - I verified that debugging in VSCode works: set a test name in singleTest variable, set breakpoints inside CLI and click "debug test" in VSCode.	2025-01-21 21:21:12 +00:00

Author

SHA1

Message

Date

shreyas-goenka

55c03cc119

Always close test HTTP server during cleanup (#2261 )

## Changes
This PR registers the `server.Close()` function to be run during test
cleanup in the server initialization function. This ensures that all
test servers are closed as soon as the test they are scoped to finish.

Motivated by https://github.com/databricks/cli/pull/2255/files where a
regression was introduced where we did not close the test server.

## Tests
N/A

2025-01-29 15:54:33 +00:00

shreyas-goenka

124515e8d2

Move TestServer from acceptance to libs/testserver (#2255 )

## Changes
Just a move, no changes. As recommended here:
https://github.com/databricks/cli/pull/2226#discussion_r1932152627

## Tests
N/A

2025-01-29 10:42:21 +00:00

Denis Bilenko

3a32c63919

Add -inprocess mode for acceptance tests (#2184 )

## Changes
- If you pass -inprocess flag to acceptance tests, they will run in the
same process as test itself. This enables debugging.
- If you set singleTest variable on top of acceptance_test.go, you'll
only run that test and with inprocess mode. This is intended for
debugging in VSCode.
- (minor) Converted KeepTmp to flag -keeptmp from env var KEEP_TMP for
consistency with other flags.

## Tests
- I verified that acceptance tests pass with -inprocess mode: `go test
-inprocess < /dev/null | cat`
- I verified that debugging in VSCode works: set a test name in
singleTest variable, set breakpoints inside CLI and click "debug test"
in VSCode.

2025-01-21 21:21:12 +00:00

3 Commits