databricks-cli

Commit Graph

Author	SHA1	Message	Date
Andrew Nester	ea4153e323	Fixed flaky TestBackgroundCombinedOutputFailure (#978 ) ## Changes `TestBackgroundCombinedOutputFailure` was occasionally failing because combined output could have been in different order, see https://github.com/databricks/cli/actions/runs/6823883271/job/18558675165?pr=928	2023-11-10 14:09:02 +00:00
Serge Smertin	f111b0846e	Added process stubbing for easier testing of launched subprocesses (#963 ) ## Changes This PR makes unit testing with subprocesses fast. ``` ctx := context.Background() ctx, stub := process.WithStub(ctx) stub.WithDefaultOutput("meeee") ctx = env.Set(ctx, "FOO", "bar") out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"}) require.NoError(t, err) require.Equal(t, "meeee", out) require.Equal(t, 1, stub.Len()) require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands()) allEnv := stub.CombinedEnvironment() require.Equal(t, "bar", allEnv["FOO"]) require.Equal(t, "bar", stub.LookupEnv("FOO")) ``` This should make further iterations of https://github.com/databricks/cli/pull/914 easier ## Tests `make test`	2023-11-09 14:24:05 +00:00
Serge Smertin	7171874db0	Added `process.Background()` and `process.Forwarded()` (#804 ) ## Changes This PR adds higher-level wrappers for calling subprocesses. One of the steps to get https://github.com/databricks/cli/pull/637 in, as previously discussed. The reason to add `process.Forwarded()` is to proxy Python's `input()` calls from a child process seamlessly. Another use-case is plugging in `less` as a pager for the list results. ## Tests `make test`	2023-09-27 09:04:44 +00:00

Author

SHA1

Message

Date

Andrew Nester

ea4153e323

Fixed flaky TestBackgroundCombinedOutputFailure (#978 )

## Changes
`TestBackgroundCombinedOutputFailure` was occasionally failing because
combined output could have been in different order, see


https://github.com/databricks/cli/actions/runs/6823883271/job/18558675165?pr=928

2023-11-10 14:09:02 +00:00

Serge Smertin

f111b0846e

Added process stubbing for easier testing of launched subprocesses (#963 )

## Changes

This PR makes unit testing with subprocesses fast.

```
	ctx := context.Background()
	ctx, stub := process.WithStub(ctx)
	stub.WithDefaultOutput("meeee")

	ctx = env.Set(ctx, "FOO", "bar")

	out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"})
	require.NoError(t, err)
	require.Equal(t, "meeee", out)
	require.Equal(t, 1, stub.Len())
	require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands())

	allEnv := stub.CombinedEnvironment()
	require.Equal(t, "bar", allEnv["FOO"])
	require.Equal(t, "bar", stub.LookupEnv("FOO"))
```

This should make further iterations of
https://github.com/databricks/cli/pull/914 easier

## Tests

`make test`

2023-11-09 14:24:05 +00:00

Serge Smertin

7171874db0

Added `process.Background()` and `process.Forwarded()` (#804 )

## Changes
This PR adds higher-level wrappers for calling subprocesses. One of the
steps to get https://github.com/databricks/cli/pull/637 in, as
previously discussed.

The reason to add `process.Forwarded()` is to proxy Python's `input()`
calls from a child process seamlessly. Another use-case is plugging in
`less` as a pager for the list results.

## Tests
`make test`

2023-09-27 09:04:44 +00:00

3 Commits