56 Commits

Author	SHA1	Message	Date
Pieter Noordhuis	14abcb3ad7	Add `dynvar` package for variable resolution with a `dyn.Value` tree (#1143) ... ## Changes This is the `dyn` counterpart to the `bundle/config/interpolation` package. It relies on the paths in `${foo.bar}` being valid `dyn.Path` instances. It leverages `dyn.Walk` to get a complete picture of all variable references and uses `dyn.Get` to retrieve values pointed to by variable references. Depends on #1142. ## Tests Unit test coverage. I tried to mirror the tests from `bundle/config/interpolation` and added new ones where applicable (for example to test type retention of referenced values).	2024-01-24 18:49:06 +00:00
Pieter Noordhuis	ff6e0354b9	Add functionality to visit values in `dyn.Value` tree (#1142) ... ## Changes This change adds the following functions: * `dyn.Get(value, "foo.bar") -> (dyn.Value, error)` * `dyn.Set(value, "foo.bar", newValue) -> (dyn.Value, error)` * `dyn.Map(value, "foo.bar", func) -> (dyn.Value, error)` And equivalent functions that take a previously constructed `dyn.Path`: * `dyn.GetByPath(value, dyn.Path) -> (dyn.Value, error)` * `dyn.SetByPath(value, dyn.Path, newValue) -> (dyn.Value, error)` * `dyn.MapByPath(value, dyn.Path, func) -> (dyn.Value, error)` Changes made by the "set" and "map" functions are never reflected in the input argument; they return new `dyn.Value` instances for all nodes in the path leading up to the changed value. ## Tests New unit tests cover all critical paths.	2024-01-24 18:38:46 +00:00
Andrew Nester	70fe0e36ef	Added `databricks bundle generate job` command (#1043) ... ## Changes Now it's possible to generate bundle configuration for existing job. For now it only supports jobs with notebook tasks. It will download notebooks referenced in the job tasks and generate bundle YAML config for this job which can be included in larger bundle. ## Tests Running command manually Example of generated config ``` resources: jobs: job_128737545467921: name: Notebook job format: MULTI_TASK tasks: - task_key: as_notebook existing_cluster_id: 0704-xxxxxx-yyyyyyy notebook_task: base_parameters: bundle_root: /Users/andrew.nester@databricks.com/.bundle/job_with_module_imports/development/files notebook_path: ./entry_notebook.py source: WORKSPACE run_if: ALL_SUCCESS max_concurrent_runs: 1 ``` ## Tests Manual (on our last 100 jobs) + added end-to-end test ``` --- PASS: TestAccGenerateFromExistingJobAndDeploy (50.91s) PASS coverage: 61.5% of statements in ./... ok github.com/databricks/cli/internal/bundle 51.209s coverage: 61.5% of statements in ./... ```	2024-01-17 14:26:33 +00:00
Pieter Noordhuis	d8a64e6617	Define constant for the invalid `dyn.Value` (#1101) ... ## Changes The nil value is a real valid value that we need to represent. To accommodate this we introduced `dyn.KindInvalid` as the zero-value for `dyn.Kind` (see #904), but did not yet update the comments on `dyn.NilValue` or add tests for `kind.go`. This also moves `KindNil` to be last in the definition order (least likely to care about it). ## Tests Tests pass.	2024-01-05 13:02:04 +00:00
Pieter Noordhuis	bae220d1bc	Consolidate functions to convert `dyn.Value` to native types (#1100) ... ## Changes The file `value.go` had a couple `AsZZZ` and `MustZZZ` functions. This change backfills missing versions and moves all of them to a separate file. ## Tests Tests pass; full coverage.	2024-01-05 12:06:12 +00:00
Pieter Noordhuis	938eb1600c	Rename libs/config -> libs/dyn (#1086) ... ## Changes The name "dynamic value", or "dyn" for short, is more descriptive than the opaque "config". Also, it conveniently does not alias with other packages in the repository, or (popular ones) elsewhere. (discussed with @andrewnester) ## Tests n/a	2023-12-22 13:20:45 +00:00