databricks-cli

Commit Graph

Author	SHA1	Message	Date
Ilia Babanov	cbf75b157d	Avoid race-conditions while executing sub-commands (#1201 ) ## Changes `executor.Exec` now uses `cmd.CombinedOutput`. Previous implementation was hanging on my windows VM during `bundle deploy` on the `ReadAll(MultiReader(stdout, stderr))` line. The problem is related to the fact the MultiReader reads sequentially, and the `stdout` is the first in line. Even simple `io.ReadAll(stdout)` hangs on me, as it seems like the command that we spawn (python wheel build) waits for the error stream to be finished before closing stdout on its own side? Reading `stderr` (or `out`) in a separate go-routine fixes the deadlock, but `cmd.CombinedOutput` feels like a simpler solution. Also noticed that Exec was not removing `scriptFile` after itself, fixed that too. ## Tests Unit tests and manually	2024-02-12 15:04:14 +00:00
Pieter Noordhuis	94112eaedb	Make libs/exec fallback to `sh` if `bash` cannot be found (#1114 ) ## Changes Falling back to `sh` is also what GitHub Actions do if `bash` is not found in the path. It is possible `bash` is not available when running from minimal Docker containers and we must not error out in this case. See: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell. This change renames `interpreter` -> `shell`. ## Tests Unit tests pass.	2024-01-11 12:26:31 +00:00
Andrew Nester	ac37a592f1	Added exec.NewCommandExecutor to execute commands with correct interpreter (#1075 ) ## Changes Instead of handling command chaining ourselves, we execute passed commands as-is by storing them, in temp file and passing to correct interpreter (bash or cmd) based on OS. Fixes #1065 ## Tests Added unit tests	2023-12-21 15:45:23 +00:00

Author

SHA1

Message

Date

Ilia Babanov

cbf75b157d

Avoid race-conditions while executing sub-commands (#1201 )

## Changes
`executor.Exec` now uses `cmd.CombinedOutput`. Previous implementation
was hanging on my windows VM during `bundle deploy` on the
`ReadAll(MultiReader(stdout, stderr))` line.

The problem is related to the fact the MultiReader reads sequentially,
and the `stdout` is the first in line. Even simple `io.ReadAll(stdout)`
hangs on me, as it seems like the command that we spawn (python wheel
build) waits for the error stream to be finished before closing stdout
on its own side? Reading `stderr` (or `out`) in a separate go-routine
fixes the deadlock, but `cmd.CombinedOutput` feels like a simpler
solution.

Also noticed that Exec was not removing `scriptFile` after itself, fixed
that too.

## Tests
Unit tests and manually

2024-02-12 15:04:14 +00:00

Pieter Noordhuis

94112eaedb

Make libs/exec fallback to `sh` if `bash` cannot be found (#1114 )

## Changes

Falling back to `sh` is also what GitHub Actions do if `bash` is not
found in the path. It is possible `bash` is not available when running
from minimal Docker containers and we must not error out in this case.

See:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsshell.

This change renames `interpreter` -> `shell`.

## Tests

Unit tests pass.

2024-01-11 12:26:31 +00:00

Andrew Nester

ac37a592f1

Added exec.NewCommandExecutor to execute commands with correct interpreter (#1075 )

## Changes
Instead of handling command chaining ourselves, we execute passed
commands as-is by storing them, in temp file and passing to correct
interpreter (bash or cmd) based on OS.

Fixes #1065 

## Tests
Added unit tests

2023-12-21 15:45:23 +00:00

3 Commits