databricks-cli

Commit Graph

Author	SHA1	Message	Date
Denis Bilenko	0b80784df7	Enable testifylint and fix the issues (#2065 ) ## Changes - Enable new linter: testifylint. - Apply fixes with --fix. - Fix remaining issues (mostly with aider). There were 2 cases we --fix did the wrong thing - this seems to a be a bug in linter: https://github.com/Antonboom/testifylint/issues/210 Nonetheless, I kept that check enabled, it seems useful, just need to be fixed manually after autofix. ## Tests Existing tests	2025-01-02 12:03:41 +01:00
Pieter Noordhuis	4e95cb226c	Remove superfluous name prefix for integration tests (#2012 ) ## Changes Mechanical rename of "TestAcc" -> "Test" in the test name prefix. ## Tests n/a	2024-12-13 15:47:50 +01:00
Pieter Noordhuis	c958702097	Move integration tests to `integration` package (#2009 ) ## Changes Objectives: * A dedicated directory for integration tests * It is not picked up by `go test ./...` * No need for a `TestAcc` test name prefix * More granular packages to improve test selection (future) The tree structure generally mirrors the source code tree structure. Requirements for new files in this directory: * Every package must be named after its directory with `_test` appended * Requiring a different package name for integration tests avoids aliasing with the main package. * Every integration test package must include a `main_test.go` file. These requirements are enforced by a unit test in the `integration` package. ## Tests Integration tests pass. The total run time regresses by about 10%. A follow-up change that increases the degree of test parallelism will address this.	2024-12-13 15:38:58 +01:00

Author

SHA1

Message

Date

Denis Bilenko

0b80784df7

Enable testifylint and fix the issues (#2065 )

## Changes
- Enable new linter: testifylint.
- Apply fixes with --fix.
- Fix remaining issues (mostly with aider).

There were 2 cases we --fix did the wrong thing - this seems to a be a
bug in linter: https://github.com/Antonboom/testifylint/issues/210

Nonetheless, I kept that check enabled, it seems useful, just need to be
fixed manually after autofix.

## Tests
Existing tests

2025-01-02 12:03:41 +01:00

Pieter Noordhuis

4e95cb226c

Remove superfluous name prefix for integration tests (#2012 )

## Changes

Mechanical rename of "TestAcc" -> "Test" in the test name prefix.

## Tests

n/a

2024-12-13 15:47:50 +01:00

Pieter Noordhuis

c958702097

Move integration tests to `integration` package (#2009 )

## Changes

Objectives:
* A dedicated directory for integration tests
* It is not picked up by `go test ./...`
* No need for a `TestAcc` test name prefix
* More granular packages to improve test selection (future)

The tree structure generally mirrors the source code tree structure.

Requirements for new files in this directory:
* Every package **must** be named after its directory with `_test` appended
* Requiring a different package name for integration tests avoids
aliasing with the main package.
* Every integration test package **must** include a `main_test.go` file.

These requirements are enforced by a unit test in the `integration` package.

## Tests

Integration tests pass.

The total run time regresses by about 10%. A follow-up change that
increases the degree of test parallelism will address this.

2024-12-13 15:38:58 +01:00

3 Commits