databricks-cli

Commit Graph

Author	SHA1	Message	Date
Pieter Noordhuis	b64e11304c	Fix integration test with invalid configuration (#1182 ) ## Changes The indentation mistake on the `path` field under `notebook` meant the pipeline had a single entry with a `nil` notebook field. This was allowed but incorrect. While working on the `dyn.Value` approach, this yielded a non-nil but zeroed `notebook` field and a failure to translate an empty path. ## Tests Correcting the indentation made the test fail because the file is not a notebook. I changed it to a `file` reference and the test now passes.	2024-02-07 10:53:50 +00:00
shreyas-goenka	fe32c46dc8	Make bundle deploy work if no resources are defined (#767 ) ## Changes This PR sets "resource" to nil in the terraform representation if no resources are defined in the bundle configuration. This solves two problems: 1. Makes bundle deploy work without any resources specified. 2. Previously if a `resources` block was removed after a deployment, that would fail with an error. Now the resources would get destroyed as expected. Also removes `TerraformHasNoResources` which is no longer needed. ## Tests New e2e tests.	2023-09-13 22:50:37 +00:00

Author

SHA1

Message

Date

Pieter Noordhuis

b64e11304c

Fix integration test with invalid configuration (#1182 )

## Changes

The indentation mistake on the `path` field under `notebook` meant the
pipeline had a single entry with a `nil` notebook field. This was
allowed but incorrect.

While working on the `dyn.Value` approach, this yielded a non-nil but
zeroed `notebook` field and a failure to translate an empty path.

## Tests

Correcting the indentation made the test fail because the file is not a
notebook. I changed it to a `file` reference and the test now passes.

2024-02-07 10:53:50 +00:00

shreyas-goenka

fe32c46dc8

Make bundle deploy work if no resources are defined (#767 )

## Changes

This PR sets "resource" to nil in the terraform representation if no
resources are defined in the bundle configuration. This solves two
problems:

1. Makes bundle deploy work without any resources specified. 
2. Previously if a `resources` block was removed after a deployment,
that would fail with an error. Now the resources would get destroyed as
expected.

Also removes `TerraformHasNoResources` which is no longer needed.

## Tests
New e2e tests.

2023-09-13 22:50:37 +00:00

2 Commits