steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,853 Commits 136 Branches 115 Tags 152 MiB
Commit Graph

1853 Commits

Author SHA1 Message Date
Ilya Kuznetsov 25a701be92
Add missing `.gitignore` to dbt-sql and default-sql templates (#2356) 
## Changes

Added missing .gitignore files to templates

## Tests

There were some incorrect snapshots of gitignore files in acceptance
tests, probably generated by testing infra. Updated them to new files

---------

Co-authored-by: Lennart Kats (databricks) <lennart.kats@databricks.com>
 2025-02-25 09:42:02 +00:00
Denis Bilenko ccdbb1aeba
acc: fix override of settings with null values (#2369) 
## Changes
Previously, one could not set `LocalOnly=true` in parent directory and
then override it with `LocalOnly=false` in child directory. This is
because, `false` is considered empty value by mergo.

In order to distinguish between 'explicitly set to false' and 'not set',
I've changed all simple variables in config to be pointers. Now, one can
always override those, because non-nil pointers are not null (with
mergo.WithoutDereference option).

## Tests
Manually:

```
~/work/cli/acceptance/bundle/templates/default-python % cat test.toml   # add this new file 
LocalOnly = false

~/work/cli/acceptance/bundle/templates/default-python % CLOUD_ENV=aws go test ../../.. -run ^TestAccept$/^bundle$/^templates$/^default-python$ -v
(the test is no longer skipped)
```
 2025-02-25 08:53:46 +00:00
Julia Crawford (Databricks) 864f0abc4b
Populate missing bundle config reference doc descriptions and fix resource reference doc template (#2314) 
## Changes
- Added some missing descriptions to annotations.yml
- Fixed links in the resource reference doc template 

## Tests
<!-- How is this tested? -->
 2025-02-24 18:59:12 +00:00
Shreyas Goenka 33a7f7151e
- 2025-02-24 18:31:43 +01:00
Shreyas Goenka 0f98570539
Revert "-" 
This reverts commit 6dc73d7a46.
 2025-02-24 18:30:29 +01:00
Shreyas Goenka 6dc73d7a46
- 2025-02-24 18:29:06 +01:00
Shreyas Goenka 71643ab1df
- 2025-02-24 18:09:21 +01:00
Shreyas Goenka 549e49e2ae
cancel test 2025-02-24 18:05:19 +01:00
Shreyas Goenka 3f48d1f41e
- 2025-02-24 17:09:18 +01:00
Shreyas Goenka 32a600a18f
cleanip 2025-02-24 17:07:15 +01:00
Shreyas Goenka 63ad316e8a
fx 2025-02-24 17:05:18 +01:00
Shreyas Goenka 6acb6f166e
consolidate repl 2025-02-24 17:03:23 +01:00
Shreyas Goenka 00ebbb9c47
add integration test 2025-02-24 16:59:17 +01:00
Shreyas Goenka 9e3aa59293
- 2025-02-24 16:10:50 +01:00
Shreyas Goenka 59396166c3
rename env var 2025-02-24 16:09:09 +01:00
Shreyas Goenka a0e6f8f635
pull latest 2025-02-24 15:56:05 +01:00
Shreyas Goenka 8cfbb335c8
Merge remote-tracking branch 'origin' into async-logger-clean 2025-02-24 15:55:17 +01:00
Shreyas Goenka 0d37654735
add test for timeout 2025-02-24 15:26:31 +01:00
Shreyas Goenka f11f5895ff
toml files 2025-02-24 14:54:39 +01:00
Denis Bilenko 4881fd873b
acc: Write out.requests.txt immediately (#2368) 
## Changes
- Instead of collecting requests in memory and writing them at the end
of the test, write them right away. Then test authors can do filtering
with jq in 'script' or collect individual files per different command.
- testserver is now simpler - it just calls a caller-provided function.
The logging logic is moved to acceptance_test.go.

See https://github.com/databricks/cli/pull/2359/files#r1967591173

## Tests
Existing tests.
 2025-02-24 13:37:05 +00:00
Lennart Kats (databricks) ce7e64062b
Change warning about incomplete permissions section into a recommendation (#2043) 
## Changes

Changes the warning about an incomplete / implicit permissions section
into a recommendation, and does a minor bit of cleanup.

## Tests
New unit test.
 2025-02-24 09:39:03 +00:00
Lennart Kats (databricks) 6e18d94264
Refine `mode: production` diagnostic output (#2236) 
## Changes

This refines the `mode: production` diagnostic output now that the
`Detail` property is rendered as output. This is a follow-up to
https://github.com/databricks/cli/pull/1712.
 2025-02-24 08:33:13 +00:00
Lennart Kats (databricks) f99716b0a5
Remove `run_as` from the built-in templates (#2044) 
## Changes

This removes the `run-as` property from the default templates. It's a
useful property but it still only works for jobs and it makes the
default databricks.yml a bit longer. It seems like users can just learn
about it from the docs and/or vary their deployment identity.

Depends on https://github.com/databricks/cli/pull/1712.
 2025-02-24 08:31:46 +00:00
Shreyas Goenka 69f5b037e6
remove log line 2025-02-21 18:08:00 +01:00
Shreyas Goenka 68646a583d
remove leaking logs 2025-02-21 18:05:42 +01:00
Shreyas Goenka ae8ebaa757
add acc test for oauth' 2025-02-21 16:58:45 +01:00
Shreyas Goenka 5056070d11
remove user agent from telemetry tests 2025-02-21 16:48:30 +01:00
Shreyas Goenka 5ee52acacf
remove parent child selftest commands 2025-02-21 15:57:30 +01:00
Shreyas Goenka d7abb3bd97
remove daemon acceptance tests 2025-02-21 15:56:28 +01:00
Shreyas Goenka 96ade4eee6
merge 2025-02-21 15:55:30 +01:00
shreyas-goenka ddcfac5069
Add library for spawning a daemon (#2354) 
## Changes
This PR adds a library for spawning a daemon process. Our needs are
different from those of a typical daemon process in that we want to
handle being orphaned gracefully. This is because, in the vast majority
of telemetry use cases, the main CLI process (i.e., the parent process)
will exit before the telemetry process has a chance to finish uploading
the logs.

To achieve this we "detach" the child process from the parent process,
which requires different flags for UNIX vs. non-unix systems.

Here are the properties that we want to ensure for our telemetry
child/daemon processes:
1. They do not block the parent process. 
Reason: The main CLI process should not be blocked on the telemetry
child process.
2. The child can read from stdin. The parent can write to stdin. 
Reason: Telemetry logs will be passed to the child process via stdin.
3. Output logs do not leak from the child process.
    Reason: Telemetry logs should not be visible to users of the CLI.

## Tests
Unit test
 2025-02-21 13:49:47 +00:00
Shreyas Goenka 18748f7879
rename 2025-02-18 17:26:16 +01:00
Ilya Kuznetsov 874a05a27b
Add escaping for links and headers in docsgen (#2330) 
## Changes

To avoid build warnings and errors in docs build we need to escape
symbols that are treated as syntax elements

## Tests
<!-- How is this tested? -->
 2025-02-18 16:12:49 +00:00
Shreyas Goenka 3cfeb640e1
add skip functionality 2025-02-18 16:47:47 +01:00
Shreyas Goenka a98993abfc
- 2025-02-18 16:35:14 +01:00
Shreyas Goenka 520f06905b
use daemon 2025-02-18 16:30:50 +01:00
Shreyas Goenka f48fbb950b
merge daemon 2025-02-18 16:06:24 +01:00
Shreyas Goenka 8a0b359f8f
Merge remote-tracking branch 'origin' into async-logger-clean 2025-02-18 16:04:50 +01:00
Shreyas Goenka 12f1fbdece
- 2025-02-18 15:02:56 +01:00
Shreyas Goenka 86428dab79
- 2025-02-18 15:02:37 +01:00
Shreyas Goenka f504343774
- 2025-02-18 14:59:54 +01:00
Shreyas Goenka dfd26e37ae
- 2025-02-18 14:59:29 +01:00
Shreyas Goenka c59b11f7c1
- 2025-02-18 14:52:25 +01:00
Shreyas Goenka 608f0ad94f
- 2025-02-18 14:51:03 +01:00
Shreyas Goenka 8eb454da14
- 2025-02-18 14:50:02 +01:00
Shreyas Goenka f6bd82d68f
add readme 2025-02-18 14:49:24 +01:00
Shreyas Goenka e649fc056b
- 2025-02-18 14:34:13 +01:00
Shreyas Goenka 75f3008b66
- 2025-02-18 14:33:41 +01:00
Shreyas Goenka 11af4ba964
delay closing output log file 2025-02-18 14:32:16 +01:00
Shreyas Goenka 6f63e14cb7
- 2025-02-18 14:26:56 +01:00