databricks-cli

Author SHA1 Message Date

Author	SHA1	Message	Date
Pieter Noordhuis	3cb74e72a8	Run environment related tests in a pristine environment (#769 ) ## Changes If the caller running the test has one or more environment variables that are used in the test already set, they can interfere and make tests fail. ## Tests Ran tests in `./cmd/root` with Databricks related environment variables set.	2023-09-12 13:28:53 +00:00
Pieter Noordhuis	0cb05d1ded	Prompt once for a client profile (#727 ) ## Changes The previous implementation ran the risk of infinite looping for the account client due to a mismatch in determining what constitutes an account client between the CLI and SDK (see [here](`83443bae8d/libs/databrickscfg/profiles.go (L61)`) and [here](`0fdc5165e5/config/config.go (L160)`)). Ultimately, this code must never infinite loop. If a user is prompted and selects a profile that cannot be used, they should receive that feedback immediately and try again, instead of being prompted again. Related to #726. ## Tests <!-- How is this tested? -->	2023-09-11 15:32:24 +00:00
Pieter Noordhuis	f62def3e77	Replace API call to test configuration with dummy authenticate call (#728 ) ## Changes This reduces the latency of every workspace command by the duration of a single API call to retrieve the current user (which can take up to a full second). Note: the better place to verify that a request can be authenticated is the SDK itself. ## Tests * Unit test to confirm an the empty `http.Request` can be constructed Manually confirmed that the additional API call no longer happens	2023-09-05 11:10:37 +00:00

Pieter Noordhuis

3cb74e72a8

Run environment related tests in a pristine environment (#769 )

## Changes

If the caller running the test has one or more environment variables
that are used in the test already set, they can interfere and make tests
fail.

## Tests

Ran tests in `./cmd/root` with Databricks related environment variables
set.

2023-09-12 13:28:53 +00:00

Pieter Noordhuis

0cb05d1ded

Prompt once for a client profile (#727 )

## Changes

The previous implementation ran the risk of infinite looping for the
account client due to a mismatch in determining what constitutes an
account client between the CLI and SDK (see
[here](83443bae8d/libs/databrickscfg/profiles.go (L61))
and
[here](0fdc5165e5/config/config.go (L160))).

Ultimately, this code must never infinite loop. If a user is prompted
and selects a profile that cannot be used, they should receive that
feedback immediately and try again, instead of being prompted again.

Related to #726.

## Tests
<!-- How is this tested? -->

2023-09-11 15:32:24 +00:00

Pieter Noordhuis

f62def3e77

Replace API call to test configuration with dummy authenticate call (#728 )

## Changes

This reduces the latency of every workspace command by the duration of a
single API call to retrieve the current user (which can take up to a
full second).

Note: the better place to verify that a request can be authenticated is
the SDK itself.

## Tests

* Unit test to confirm an the empty `*http.Request` can be constructed
* Manually confirmed that the additional API call no longer happens

2023-09-05 11:10:37 +00:00

3 Commits