Fix tests

Co-authored-by: Pieter Noordhuis <pcnoordhuis@gmail.com>

bundle/config/validate/job_task_cluster_spec.go

@@ -83,11 +83,15 @@ func validateJobTask(rb bundle.ReadOnlyBundle, task jobs.Task, taskPath dyn.Path
 			// notebook tasks without cluster spec will use notebook environment
 		} else {
 			// path might be not very helpful, adding user-specified task key clarifies the context
-			detail := fmt.Sprintf("Task %q has a task type that requires a cluster or environment, but neither is specified", task.TaskKey)
+			detail := fmt.Sprintf(
+				"Task %q requires a cluster or an environment to run.\nSpecify one of the following fields: %s.",
+				task.TaskKey,
+				strings.Join(unspecified, ", "),
+			)
 
 			diags = diags.Append(diag.Diagnostic{
 				Severity:  diag.Error,
-				Summary:   fmt.Sprintf("One of the following fields must be set: %s", strings.Join(unspecified, ", ")),
+				Summary:   "Missing required cluster or environment settings",
 				Detail:    detail,
 				Locations: rb.Config().GetLocations(taskPath.String()),
 				Paths:     []dyn.Path{taskPath},

bundle/config/validate/job_task_cluster_spec_test.go

@@ -13,7 +13,7 @@ import (
 )
 
 func TestJobTaskClusterSpec(t *testing.T) {
-	expectedSummary := "One of the following fields must be set: job_cluster_key, environment_key, existing_cluster_id, new_cluster"
+	expectedSummary := "Missing required cluster or environment settings"
 
 	type testCase struct {
 		name         string
@@ -143,8 +143,9 @@ func TestJobTaskClusterSpec(t *testing.T) {
 				PythonWheelTask: &jobs.PythonWheelTask{},
 				TaskKey:         "my_task",
 			},
-			errorPath:    "resources.jobs.job1.tasks[0]",
-			errorDetail:  "Task \"my_task\" has a task type that requires a cluster or environment, but neither is specified",
+			errorPath: "resources.jobs.job1.tasks[0]",
+			errorDetail: `Task "my_task" requires a cluster or an environment to run.
+Specify one of the following fields: job_cluster_key, environment_key, existing_cluster_id, new_cluster.`,
 			errorSummary: expectedSummary,
 		},
 		{
@@ -157,8 +158,9 @@ func TestJobTaskClusterSpec(t *testing.T) {
 					},
 				},
 			},
-			errorPath:    "resources.jobs.job1.tasks[0].for_each_task.task",
-			errorDetail:  "Task \"my_task\" has a task type that requires a cluster or environment, but neither is specified",
+			errorPath: "resources.jobs.job1.tasks[0].for_each_task.task",
+			errorDetail: `Task "my_task" requires a cluster or an environment to run.
+Specify one of the following fields: job_cluster_key, environment_key, existing_cluster_id, new_cluster.`,
 			errorSummary: expectedSummary,
 		},
 	}