Enable 'govet' linter; expand log/diag with non-f functions (#1996)

## Changes
Fix all the govet-found issues and enable govet linter.

This prompts adding non-formatting variants of logging functions (Errorf
-> Error).

## Tests
Existing tests.

.golangci.yaml

@@ -4,12 +4,17 @@ linters:
     - bodyclose
     - errcheck
     - gosimple
-    #- govet
+    - govet
     - ineffassign
     - staticcheck
     - unused
     - gofmt
 linters-settings:
+  govet:
+    enable-all: true
+    disable:
+      - fieldalignment
+      - shadow
   gofmt:
     rewrite-rules:
       - pattern: 'a[b:len(a)]'

bundle/artifacts/whl/autodetect.go

@@ -42,7 +42,7 @@ func (m *detectPkg) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostic
 		return nil
 	}
 
-	log.Infof(ctx, fmt.Sprintf("Found Python wheel project at %s", b.BundleRootPath))
+	log.Infof(ctx, "Found Python wheel project at %s", b.BundleRootPath)
 	module := extractModuleName(setupPy)
 
 	if b.Config.Artifacts == nil {

bundle/config/mutator/override_compute.go

@@ -45,8 +45,9 @@ func (m *overrideCompute) Apply(ctx context.Context, b *bundle.Bundle) diag.Diag
 		if b.Config.Bundle.ClusterId != "" {
 			// Overriding compute via a command-line flag for production works, but is not recommended.
 			diags = diags.Extend(diag.Diagnostics{{
-				Summary: "Setting a cluster override for a target that uses 'mode: production' is not recommended",
-				Detail:  "It is recommended to always use the same compute for production target for consistency.",
+				Summary:  "Setting a cluster override for a target that uses 'mode: production' is not recommended",
+				Detail:   "It is recommended to always use the same compute for production target for consistency.",
+				Severity: diag.Warning,
 			}})
 		}
 	}

bundle/config/mutator/override_compute_test.go

@@ -8,6 +8,7 @@ import (
 	"github.com/databricks/cli/bundle/config"
 	"github.com/databricks/cli/bundle/config/mutator"
 	"github.com/databricks/cli/bundle/config/resources"
+	"github.com/databricks/cli/libs/diag"
 	"github.com/databricks/databricks-sdk-go/service/compute"
 	"github.com/databricks/databricks-sdk-go/service/jobs"
 	"github.com/stretchr/testify/assert"
@@ -173,6 +174,7 @@ func TestOverrideComputeModeProduction(t *testing.T) {
 	diags := bundle.Apply(context.Background(), b, m)
 	require.Len(t, diags, 1)
 	assert.Equal(t, "Setting a cluster override for a target that uses 'mode: production' is not recommended", diags[0].Summary)
+	assert.Equal(t, diag.Warning, diags[0].Severity)
 	assert.Equal(t, "newClusterID", b.Config.Resources.Jobs["job1"].Tasks[0].ExistingClusterId)
 }
 

bundle/deferred_test.go

@@ -19,7 +19,7 @@ func (t *mutatorWithError) Name() string {
 
 func (t *mutatorWithError) Apply(_ context.Context, b *Bundle) diag.Diagnostics {
 	t.applyCalled++
-	return diag.Errorf(t.errorMsg)
+	return diag.Errorf(t.errorMsg) // nolint:govet
 }
 
 func TestDeferredMutatorWhenAllMutatorsSucceed(t *testing.T) {

bundle/deploy/terraform/plan.go

@@ -2,7 +2,6 @@ package terraform
 
 import (
 	"context"
-	"fmt"
 	"path/filepath"
 
 	"github.com/databricks/cli/bundle"
@@ -57,7 +56,7 @@ func (p *plan) Apply(ctx context.Context, b *bundle.Bundle) diag.Diagnostics {
 		IsEmpty: !notEmpty,
 	}
 
-	log.Debugf(ctx, fmt.Sprintf("Planning complete and persisted at %s\n", planPath))
+	log.Debugf(ctx, "Planning complete and persisted at %s\n", planPath)
 	return nil
 }
 

bundle/libraries/filer_volume_test.go

@@ -173,7 +173,7 @@ func TestFilerForVolumeNotFoundAndInBundle(t *testing.T) {
 		{
 			Severity:  diag.Error,
 			Summary:   "volume /Volumes/main/my_schema/my_volume does not exist: error from API",
-			Locations: []dyn.Location{{"config.yml", 1, 2}, {"volume.yml", 1, 2}},
+			Locations: []dyn.Location{{File: "config.yml", Line: 1, Column: 2}, {File: "volume.yml", Line: 1, Column: 2}},
 			Paths:     []dyn.Path{dyn.MustPathFromString("workspace.artifact_path"), dyn.MustPathFromString("resources.volumes.foo")},
 			Detail: `You are using a volume in your artifact_path that is managed by
 this bundle but which has not been deployed yet. Please first deploy

bundle/run/job.go

@@ -143,7 +143,7 @@ func logProgressCallback(ctx context.Context, progressLogger *cmdio.Logger) func
 		progressLogger.Log(event)
 
 		// log progress events in using the default logger
-		log.Infof(ctx, event.String())
+		log.Info(ctx, event.String())
 	}
 }
 
@@ -203,7 +203,7 @@ func (r *jobRunner) Run(ctx context.Context, opts *Options) (output.RunOutput, e
 		logDebug(r)
 		logProgress(r)
 	}).GetWithTimeout(jobRunTimeout)
-	if err != nil && runId != nil {
+	if err != nil {
 		r.logFailedTasks(ctx, *runId)
 	}
 	if err != nil {

bundle/run/pipeline.go

@@ -37,7 +37,7 @@ func (r *pipelineRunner) logEvent(ctx context.Context, event pipelines.PipelineE
 		}
 	}
 	if logString != "" {
-		log.Errorf(ctx, fmt.Sprintf("[%s] %s", event.EventType, logString))
+		log.Errorf(ctx, "[%s] %s", event.EventType, logString)
 	}
 }
 
@@ -132,7 +132,7 @@ func (r *pipelineRunner) Run(ctx context.Context, opts *Options) (output.RunOutp
 		}
 		for _, event := range events {
 			progressLogger.Log(&event)
-			log.Infof(ctx, event.String())
+			log.Info(ctx, event.String())
 		}
 
 		update, err := w.Pipelines.GetUpdateByPipelineIdAndUpdateId(ctx, pipelineID, updateID)

cmd/labs/project/entrypoint.go

@@ -190,9 +190,6 @@ func (e *Entrypoint) getLoginConfig(cmd *cobra.Command) (*loginConfig, *config.C
 	if isNoLoginConfig && !e.IsBundleAware {
 		return nil, nil, ErrNoLoginConfig
 	}
-	if !isNoLoginConfig && err != nil {
-		return nil, nil, fmt.Errorf("load: %w", err)
-	}
 	if e.IsAccountLevel {
 		log.Debugf(ctx, "Using account-level login profile: %s", lc.AccountProfile)
 		cfg, err := e.envAwareConfigWithProfile(ctx, lc.AccountProfile)

cmd/root/auth_test.go

@@ -15,7 +15,8 @@ import (
 )
 
 func TestEmptyHttpRequest(t *testing.T) {
-	ctx, _ := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
 	req := emptyHttpRequest(ctx)
 	assert.Equal(t, req.Context(), ctx)
 }

internal/bundle/bundles/uc_schema/template/databricks.yml.tmpl

@@ -12,7 +12,6 @@ resources:
         - notebook:
             path: ./nb.sql
       development: true
-      catalog: main
 
 include:
   - "*.yml"

internal/bundle/bundles/uc_schema/template/schema.yml.tmpl

@@ -11,3 +11,4 @@ targets:
       pipelines:
         foo:
           target: ${resources.schemas.bar.id}
+          catalog: main

libs/log/logger.go

@@ -31,6 +31,51 @@ func log(logger *slog.Logger, ctx context.Context, level slog.Level, msg string)
 	_ = logger.Handler().Handle(ctx, r)
 }
 
+// Trace logs a string using the context-local or global logger.
+func Trace(ctx context.Context, msg string) {
+	logger := GetLogger(ctx)
+	if !logger.Enabled(ctx, LevelTrace) {
+		return
+	}
+	log(logger, ctx, LevelTrace, msg)
+}
+
+// Debug logs a string using the context-local or global logger.
+func Debug(ctx context.Context, msg string) {
+	logger := GetLogger(ctx)
+	if !logger.Enabled(ctx, LevelDebug) {
+		return
+	}
+	log(logger, ctx, LevelDebug, msg)
+}
+
+// Info logs a string using the context-local or global logger.
+func Info(ctx context.Context, msg string) {
+	logger := GetLogger(ctx)
+	if !logger.Enabled(ctx, LevelInfo) {
+		return
+	}
+	log(logger, ctx, LevelInfo, msg)
+}
+
+// Warn logs a string using the context-local or global logger.
+func Warn(ctx context.Context, msg string) {
+	logger := GetLogger(ctx)
+	if !logger.Enabled(ctx, LevelWarn) {
+		return
+	}
+	log(logger, ctx, LevelWarn, msg)
+}
+
+// Error logs a string using the context-local or global logger.
+func Error(ctx context.Context, msg string) {
+	logger := GetLogger(ctx)
+	if !logger.Enabled(ctx, LevelError) {
+		return
+	}
+	log(logger, ctx, LevelError, msg)
+}
+
 // Tracef logs a formatted string using the context-local or global logger.
 func Tracef(ctx context.Context, format string, v ...any) {
 	logger := GetLogger(ctx)

libs/template/renderer.go

@@ -310,7 +310,7 @@ func (r *renderer) persistToDisk(ctx context.Context, out filer.Filer) error {
 		if err == nil {
 			return fmt.Errorf("failed to initialize template, one or more files already exist: %s", path)
 		}
-		if err != nil && !errors.Is(err, fs.ErrNotExist) {
+		if !errors.Is(err, fs.ErrNotExist) {
 			return fmt.Errorf("error while verifying file %s does not already exist: %w", path, err)
 		}
 	}