mirror of https://github.com/databricks/cli.git
2847533e1e
## Changes
This PR adds support for UC volumes to DABs.
### Can I use a UC volume managed by DABs in `artifact_path`?
Yes, but we require the volume to exist before being referenced in
`artifact_path`. Otherwise you'll see an error that the volume does not
exist. For this case, this PR also adds a warning if we detect that the
UC volume is defined in the DAB itself, which informs the user to deploy
the UC volume in a separate deployment first before using it in
`artifact_path`.
We cannot create the UC volume and then upload the artifacts to it in
the same `bundle deploy` because `bundle deploy` always uploads the
artifacts to `artifact_path` before materializing any resources defined
in the bundle. Supporting this in a single deployment requires us to
migrate away from our dependency on the Databricks Terraform provider to
manage the CRUD lifecycle of DABs resources.
### Why do we not support `preset.name_prefix` for UC volumes?
UC volumes will not have a `dev_shreyas_goenka` prefix added in `mode:
development`. Configuring `presets.name_prefix` will be a no-op for UC
volumes. We have decided not to support prefixing for UC resources. This
is because:
1. UC provides its own namespace hierarchy that is independent of DABs.
2. Users can always manually use `${workspace.current_user.short_name}`
to configure the prefixes manually.
Customers often manually set up a UC hierarchy for dev and prod,
including a schema or catalog per developer. Thus, it's often
unnecessary for us to add prefixing in `mode: development` by default
for UC resources.
In retrospect, supporting prefixing for UC schemas and registered models
was a mistake and will be removed in a future release of DABs.
## Tests
Unit, integration test, and manually.
### Manual Testing cases:
1. UC volume does not exist:
```
➜ bundle-playground git:(master) ✗ cli bundle deploy
Error: failed to fetch metadata for the UC volume /Volumes/main/caps/my_volume that is configured in the artifact_path: Not Found
```
2. UC Volume does not exist, but is defined in the DAB
```
➜ bundle-playground git:(master) ✗ cli bundle deploy
Error: failed to fetch metadata for the UC volume /Volumes/main/caps/managed_by_dab that is configured in the artifact_path: Not Found
Warning: You might be using a UC volume in your artifact_path that is managed by this bundle but which has not been deployed yet. Please deploy the UC volume in a separate bundle deploy before using it in the artifact_path.
at resources.volumes.bar
in databricks.yml:24:7
```
---------
Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com>
|
||
|---|---|---|
| .. | ||
| convert | ||
| dynassert | ||
| dynvar | ||
| jsonloader | ||
| jsonsaver | ||
| merge | ||
| yamlloader | ||
| yamlsaver | ||
| kind.go | ||
| kind_test.go | ||
| location.go | ||
| location_test.go | ||
| mapping.go | ||
| mapping_test.go | ||
| path.go | ||
| path_string.go | ||
| path_string_test.go | ||
| path_test.go | ||
| pattern.go | ||
| pattern_test.go | ||
| time.go | ||
| time_test.go | ||
| value.go | ||
| value_test.go | ||
| value_underlying.go | ||
| value_underlying_test.go | ||
| visit.go | ||
| visit_get.go | ||
| visit_get_test.go | ||
| visit_map.go | ||
| visit_map_test.go | ||
| visit_set.go | ||
| visit_set_test.go | ||
| visit_test.go | ||
| walk.go | ||
| walk_test.go | ||