databricks-cli/internal
Pieter Noordhuis 70b7bbfd81
Remove calls to `t.Setenv` from integration tests (#2018)
## Changes

The `Setenv` helper function configures an environment variable and
resets it to its original value when exiting the test scope. It is
incompatible with running tests in parallel because it modifies
process-wide state. The `libs/env` package defines functions to interact
with the environment but records `Setenv` calls on a `context.Context`.
This enables us to override/specialize the environment scoped to a
context.

Pre-requisites for removing the `t.Setenv` calls:
* Make `cmdio.NewIO` accept a context and use it with `libs/env`
* Make all `internal/testcli` functions use a context

The rest of this change:
* Modifies integration tests to initialize a context to use if there
wasn't already one
* Updates `t.Setenv` calls to use `env.Set`

## Tests

n/a
2024-12-16 12:34:37 +01:00
..
acc Move test helpers from internal to `acc` and `testutil` (#2008) 2024-12-12 21:28:04 +00:00
bugbash Add script to make testing of code on branches easier (#1844) 2024-10-21 17:56:17 +00:00
build Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
mocks Rewrite 'interface{} -> any' (#1959) 2024-12-05 15:37:24 +00:00
testcli Remove calls to `t.Setenv` from integration tests (#2018) 2024-12-16 12:34:37 +01:00
testutil Move test helpers from internal to `acc` and `testutil` (#2008) 2024-12-12 21:28:04 +00:00