databricks-cli/libs/template
Pieter Noordhuis 70b7bbfd81
Remove calls to `t.Setenv` from integration tests (#2018)
## Changes

The `Setenv` helper function configures an environment variable and
resets it to its original value when exiting the test scope. It is
incompatible with running tests in parallel because it modifies
process-wide state. The `libs/env` package defines functions to interact
with the environment but records `Setenv` calls on a `context.Context`.
This enables us to override/specialize the environment scoped to a
context.

Pre-requisites for removing the `t.Setenv` calls:
* Make `cmdio.NewIO` accept a context and use it with `libs/env`
* Make all `internal/testcli` functions use a context

The rest of this change:
* Modifies integration tests to initialize a context to use if there
wasn't already one
* Updates `t.Setenv` calls to use `env.Set`

## Tests

n/a
2024-12-16 12:34:37 +01:00
..
templates Remove unused vscode settings in the templates (#2013) 2024-12-13 16:13:21 +00:00
testdata Add the `bundle_uuid` helper function for templates (#1947) 2024-12-02 10:29:29 +00:00
builtin.go Use `fs.FS` interface to read template (#1910) 2024-11-20 09:28:35 +00:00
builtin_test.go Use `fs.FS` interface to read template (#1910) 2024-11-20 09:28:35 +00:00
config.go Use `fs.FS` interface to read template (#1910) 2024-11-20 09:28:35 +00:00
config_test.go Use `filer.Filer` to write template instantiation (#1911) 2024-11-20 11:11:31 +01:00
file.go Use `filer.Filer` to write template instantiation (#1911) 2024-11-20 11:11:31 +01:00
file_test.go Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
helpers.go Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
helpers_test.go Remove calls to `t.Setenv` from integration tests (#2018) 2024-12-16 12:34:37 +01:00
materialize.go Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
materialize_test.go Fix template initialization when running on Databricks (#1912) 2024-11-20 11:42:23 +00:00
renderer.go Enable 'govet' linter; expand log/diag with non-f functions (#1996) 2024-12-11 16:42:03 +00:00
renderer_test.go Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00