databricks-cli/libs/dyn/yamlloader
Pieter Noordhuis 26094f01a0
Define `dyn.Mapping` to represent maps (#1301)
## Changes

Before this change maps were stored as a regular Go map with string
keys. This didn't let us capture metadata (location information) for map
keys.

To address this, this change replaces the use of the regular Go map with
a dedicated type for a dynamic map. This type stores the `dyn.Value` for
both the key and the value. It uses a map to still allow O(1) lookups
and redirects those into a slice.

## Tests

* All existing unit tests pass (some with minor modifications due to
interface change).
* Equality assertions with `assert.Equal` no longer worked because the
new `dyn.Mapping` persists the order in which keys are set and is
therefore susceptible to map ordering issues. To fix this, I added a
`dynassert` package that forwards all assertions to `testify/assert` but
intercepts equality for `dyn.Value` arguments.
2024-03-25 11:01:09 +00:00
..
testdata Rename libs/config -> libs/dyn (#1086) 2023-12-22 13:20:45 +00:00
loader.go Define `dyn.Mapping` to represent maps (#1301) 2024-03-25 11:01:09 +00:00
yaml.go Rename libs/config -> libs/dyn (#1086) 2023-12-22 13:20:45 +00:00
yaml_anchor_test.go Define `dyn.Mapping` to represent maps (#1301) 2024-03-25 11:01:09 +00:00
yaml_error_test.go Define `dyn.Mapping` to represent maps (#1301) 2024-03-25 11:01:09 +00:00
yaml_mix_test.go Define `dyn.Mapping` to represent maps (#1301) 2024-03-25 11:01:09 +00:00
yaml_test.go Define `dyn.Mapping` to represent maps (#1301) 2024-03-25 11:01:09 +00:00