databricks-cli/cmd/labs
Pieter Noordhuis 70b7bbfd81
Remove calls to `t.Setenv` from integration tests (#2018)
## Changes

The `Setenv` helper function configures an environment variable and
resets it to its original value when exiting the test scope. It is
incompatible with running tests in parallel because it modifies
process-wide state. The `libs/env` package defines functions to interact
with the environment but records `Setenv` calls on a `context.Context`.
This enables us to override/specialize the environment scoped to a
context.

Pre-requisites for removing the `t.Setenv` calls:
* Make `cmdio.NewIO` accept a context and use it with `libs/env`
* Make all `internal/testcli` functions use a context

The rest of this change:
* Modifies integration tests to initialize a context to use if there
wasn't already one
* Updates `t.Setenv` calls to use `env.Set`

## Tests

n/a
2024-12-16 12:34:37 +01:00
..
github Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
localcache Enable gofumpt and goimports in golangci-lint (#1999) 2024-12-12 10:28:42 +01:00
project Remove calls to `t.Setenv` from integration tests (#2018) 2024-12-16 12:34:37 +01:00
unpack Add `databricks labs` command group (#914) 2023-11-17 12:47:37 +00:00
CODEOWNERS Add `databricks labs` command group (#914) 2023-11-17 12:47:37 +00:00
clear_cache.go Fix `panic: $HOME is not set` (#1027) 2023-11-29 19:08:27 +00:00
install.go Add usage string when command fails with incorrect arguments (#1276) 2024-03-12 14:12:34 +00:00
installed.go Add `databricks labs` command group (#914) 2023-11-17 12:47:37 +00:00
installed_test.go Remove calls to `t.Setenv` from integration tests (#2018) 2024-12-16 12:34:37 +01:00
labs.go Fix `panic: $HOME is not set` (#1027) 2023-11-29 19:08:27 +00:00
list.go Fix `panic: $HOME is not set` (#1027) 2023-11-29 19:08:27 +00:00
list_test.go Remove calls to `t.Setenv` from integration tests (#2018) 2024-12-16 12:34:37 +01:00
show.go Add usage string when command fails with incorrect arguments (#1276) 2024-03-12 14:12:34 +00:00
uninstall.go Add usage string when command fails with incorrect arguments (#1276) 2024-03-12 14:12:34 +00:00
upgrade.go Add usage string when command fails with incorrect arguments (#1276) 2024-03-12 14:12:34 +00:00