mirror of https://github.com/databricks/cli.git
f70ec359dc
## Changes This builds on #1098 and uses the `dyn.Value` representation of the bundle configuration to generate the Terraform JSON definition of resources in the bundle. The existing code (in `BundleToTerraform`) was not great and in an effort to slightly improve this, I added a package `tfdyn` that includes dedicated files for each resource type. Every resource type has its own conversion type that takes the `dyn.Value` of the bundle-side resource and converts it into Terraform resources (e.g. a job and optionally its permissions). Because we now use a `dyn.Value` as input, we can represent and emit zero-values that have so far been omitted. For example, setting `num_workers: 0` in your bundle configuration now propagates all the way to the Terraform JSON definition. ## Tests * Unit tests for every converter. I reused the test inputs from `convert_test.go`. * Equivalence tests in every existing test case checks that the resulting JSON is identical. * I manually compared the TF JSON file generated by the CLI from the main branch and from this PR on all of our bundles and bundle examples (internal and external) and found the output doesn't change (with the exception of the odd zero-value being included by the version in this PR). |
||
|---|---|---|
| .. | ||
| convert | ||
| dynvar | ||
| merge | ||
| yamlloader | ||
| yamlsaver | ||
| kind.go | ||
| kind_test.go | ||
| location.go | ||
| location_test.go | ||
| path.go | ||
| path_string.go | ||
| path_string_test.go | ||
| path_test.go | ||
| value.go | ||
| value_test.go | ||
| value_underlying.go | ||
| value_underlying_test.go | ||
| visit.go | ||
| visit_get.go | ||
| visit_get_test.go | ||
| visit_map.go | ||
| visit_map_test.go | ||
| visit_set.go | ||
| visit_set_test.go | ||
| walk.go | ||
| walk_test.go | ||