mirror of https://github.com/databricks/cli.git
4ccc70aeac
## Changes There are a couple places throughout the code base where interaction with environment variables takes place. Moreover, more than one of these would try to read a value from more than one environment variable as fallback (for backwards compatibility). This change consolidates those accesses. The majority of diffs in this change are mechanical (i.e. add an argument or replace a call). This change: * Moves common environment variable lookups for bundles to `bundles/env`. * Adds a `libs/env` package that wraps `os.LookupEnv` and `os.Getenv` and allows for overrides to take place in a `context.Context`. By scoping overrides to a `context.Context` we can avoid `t.Setenv` in testing and unlock parallel test execution for integration tests. * Updates call sites to pass through a `context.Context` where needed. * For bundles, introduces `DATABRICKS_BUNDLE_ROOT` as new primary variable instead of `BUNDLE_ROOT`. This was the last environment variable that did not use the `DATABRICKS_` prefix. ## Tests Unit tests pass. |
||
|---|---|---|
| .. | ||
| acc | ||
| build | ||
| bundle | ||
| testdata/import_dir | ||
| testutil | ||
| alerts_test.go | ||
| api_test.go | ||
| clusters_test.go | ||
| filer_test.go | ||
| fs_cat_test.go | ||
| fs_cp_test.go | ||
| fs_ls_test.go | ||
| fs_mkdir_test.go | ||
| fs_rm_test.go | ||
| git_clone_test.go | ||
| helpers.go | ||
| locker_test.go | ||
| repos_test.go | ||
| secrets_test.go | ||
| sync_test.go | ||
| version_test.go | ||
| workspace_test.go | ||