mirror of https://github.com/databricks/cli.git
8d5351c1c3
## Changes Enable errcheck linter for the whole codebase. Fix remaining complaints: - If we can propagate error to caller, do that - If we writing to stdout, continue ignoring errors (to avoid crashing in "cli | head" case) - Add exception for cobra non-critical API such as MarkHidden/MarkDeprecated/RegisterFlagCompletionFunc. This keeps current code and behaviour, to be decided later if we want to change this. - Continue ignoring errors where that is desired behaviour (e.g. git.loadConfig). - Continue ignoring errors where panicking seems riskier than ignoring the error. - Annotate cases in libs/dyn with //nolint:errcheck - to be addressed later. Note, this PR is not meant to come up with the best strategy for each case, but to be a relative safe change to enable errcheck linter. ## Tests Existing tests. |
||
|---|---|---|
| .. | ||
| testdata/sync-fileset | ||
| diff.go | ||
| diff_test.go | ||
| dirset.go | ||
| dirset_test.go | ||
| event.go | ||
| event_test.go | ||
| output.go | ||
| path.go | ||
| path_test.go | ||
| snapshot.go | ||
| snapshot_state.go | ||
| snapshot_state_test.go | ||
| snapshot_test.go | ||
| sync.go | ||
| sync_test.go | ||
| watchdog.go | ||