mirror of https://github.com/databricks/cli.git
e2db0cd0e2
## Changes - Instead of constructing chains of mutators and then executing them, execute them directly. - Remove functionality related to chain-building: Seq, If, Defer, newPhase, logString. - Phases become functions that apply the changes directly rather than construct mutator chains that will be called later. - Add a helper ApplySeq to call multiple mutators, use it where Apply+Seq were used before. This is intended to be a refactoring without functional changes, but there are a few behaviour changes: - Since defer() is used to call unlock instead of bundle.Defer() unlocking will now happen even in case of panics. - In --debug, the phase names are are still logged once before start of the phase but each entry no longer has 'seq' or phase name in it. - The message "Deployment complete!" was printed even if terraform.Apply() mutator had an error. It no longer does that. ## Motivation The use of the chains was necessary when mutators were returning a list of other mutators instead of calling them directly. But that has since been removed, so now the chain machinery have no purpose anymore. Use of direct functions simplifies the logic and makes bugs more apparent and easy to fix. Other improvements that this unlocks: - Simpler stacktraces/debugging (breakpoints). - Use of functions with narrowly scoped API: instead of mutators that receive full bundle config, we can use focused functions that only deal with sections they care about prepareGitSettings(currentGitSection) -> updatedGitSection. This makes the data flow more apparent. - Parallel computations across mutators (within phase): launch goroutines fetching data from APIs at the beggining, process them once they are ready. ## Tests Existing tests. |
||
|---|---|---|
| .. | ||
| output | ||
| progress | ||
| app.go | ||
| app_test.go | ||
| args.go | ||
| args_test.go | ||
| job.go | ||
| job_args.go | ||
| job_args_test.go | ||
| job_options.go | ||
| job_options_test.go | ||
| job_test.go | ||
| options.go | ||
| pipeline.go | ||
| pipeline_options.go | ||
| pipeline_options_test.go | ||
| pipeline_test.go | ||
| runner.go | ||
| runner_test.go | ||