mirror of https://github.com/databricks/cli.git
7beb0fb8b5
## Changes
This PR:
1. Incrementally improves the error messages shown to the user when the
volume they are referring to in `workspace.artifact_path` does not
exist.
2. Performs this validation in both `bundle validate` and `bundle
deploy` compared to before on just deployments.
3. It runs "fast" validations on `bundle deploy`, which earlier were
only run on `bundle validate`.
## Tests
Unit tests and manually. Also, existing integration tests provide
coverage (`TestUploadArtifactToVolumeNotYetDeployed`,
`TestUploadArtifactFileToVolumeThatDoesNotExist`)
Examples:
```
.venv➜ bundle-playground git:(master) ✗ cli bundle validate
Error: cannot access volume capital.whatever.my_volume: User does not have READ VOLUME on Volume 'capital.whatever.my_volume'.
at workspace.artifact_path
in databricks.yml:7:18
```
and
```
.venv➜ bundle-playground git:(master) ✗ cli bundle validate
Error: volume capital.whatever.foobar does not exist
at workspace.artifact_path
resources.volumes.foo
in databricks.yml:7:18
databricks.yml:12:7
You are using a volume in your artifact_path that is managed by
this bundle but which has not been deployed yet. Please first deploy
the volume using 'bundle deploy' and then switch over to using it in
the artifact_path.
```
|
||
|---|---|---|
| .. | ||
| all_resources_have_values.go | ||
| fast_validate.go | ||
| files_to_sync.go | ||
| files_to_sync_test.go | ||
| folder_permissions.go | ||
| folder_permissions_test.go | ||
| job_cluster_key_defined.go | ||
| job_cluster_key_defined_test.go | ||
| job_task_cluster_spec.go | ||
| job_task_cluster_spec_test.go | ||
| single_node_cluster.go | ||
| single_node_cluster_test.go | ||
| unique_resource_keys.go | ||
| validate.go | ||
| validate_artifact_path.go | ||
| validate_artifact_path_test.go | ||
| validate_sync_patterns.go | ||