databricks-cli/bundle/artifacts
Pieter Noordhuis ed194668db
Return `diag.Diagnostics` from mutators (#1305)
## Changes

This diagnostics type allows us to capture multiple warnings as well as
errors in the return value. This is a preparation for returning
additional warnings from mutators in case we detect non-fatal problems.

* All return statements that previously returned an error now return
`diag.FromErr`
* All return statements that previously returned `fmt.Errorf` now return
`diag.Errorf`
* All `err != nil` checks now use `diags.HasError()` or `diags.Error()`

## Tests

* Existing tests pass.
* I confirmed no call site under `./bundle` or `./cmd/bundle` uses
`errors.Is` on the return value from mutators. This is relevant because
we cannot wrap errors with `%w` when calling `diag.Errorf` (like
`fmt.Errorf`; context in https://github.com/golang/go/issues/47641).
2024-03-25 14:18:47 +00:00
..
whl Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
all.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
artifacts.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
autodetect.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
build.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
infer.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
upload.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
upload_test.go Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00