databricks-cli/internal
Pieter Noordhuis ed194668db
Return `diag.Diagnostics` from mutators (#1305)
## Changes

This diagnostics type allows us to capture multiple warnings as well as
errors in the return value. This is a preparation for returning
additional warnings from mutators in case we detect non-fatal problems.

* All return statements that previously returned an error now return
`diag.FromErr`
* All return statements that previously returned `fmt.Errorf` now return
`diag.Errorf`
* All `err != nil` checks now use `diags.HasError()` or `diags.Error()`

## Tests

* Existing tests pass.
* I confirmed no call site under `./bundle` or `./cmd/bundle` uses
`errors.Is` on the return value from mutators. This is relevant because
we cannot wrap errors with `%w` when calling `diag.Errorf` (like
`fmt.Errorf`; context in https://github.com/golang/go/issues/47641).
2024-03-25 14:18:47 +00:00
..
acc Update Go SDK to 0.23.0 and use custom marshaller (#772) 2023-10-16 06:56:06 +00:00
build Make default dev semver a const (#891) 2023-10-19 18:56:54 +00:00
bundle Return `diag.Diagnostics` from mutators (#1305) 2024-03-25 14:18:47 +00:00
mocks Use mockery to generate mocks compatible with testify/mock (#1190) 2024-02-08 15:18:53 +00:00
python Added test to submit and run various Python tasks on multiple DBR versions (#806) 2023-10-03 11:18:55 +00:00
testdata Fix integration test asserting errors on unknown template parameters (#977) 2023-11-10 11:05:32 +00:00
testjsons Update Go SDK to 0.23.0 and use custom marshaller (#772) 2023-10-16 06:56:06 +00:00
testutil Added deployment state for bundles (#1267) 2024-03-18 14:41:58 +00:00
alerts_test.go Update alerts command integration test (#512) 2023-06-22 10:30:52 +02:00
api_test.go Rename bricks -> databricks (#389) 2023-05-16 18:35:39 +02:00
clusters_test.go Add usage string when command fails with incorrect arguments (#1276) 2024-03-12 14:12:34 +00:00
filer_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
fs_cat_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
fs_cp_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
fs_ls_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
fs_mkdir_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
fs_rm_test.go Add support for UC Volumes to the `databricks fs` commands (#1209) 2024-02-20 16:14:37 +00:00
git_clone_test.go Remove resolution of repo names against the Databricks Github account (#940) 2023-11-01 13:02:06 +00:00
helpers.go Fix CLI nightlies on our UC workspaces (#1225) 2024-02-21 13:06:03 +00:00
init_test.go Use UserName field to identify if service principal is used (#1310) 2024-03-25 11:32:45 +00:00
jobs_test.go Update Go SDK to 0.23.0 and use custom marshaller (#772) 2023-10-16 06:56:06 +00:00
locker_test.go Added test to submit and run various Python tasks on multiple DBR versions (#806) 2023-10-03 11:18:55 +00:00
repos_test.go Enabled incorrectly skipped tests (#1280) 2024-03-14 12:56:21 +00:00
secrets_test.go Enabled incorrectly skipped tests (#1280) 2024-03-14 12:56:21 +00:00
storage_credentials_test.go Enabled incorrectly skipped tests (#1280) 2024-03-14 12:56:21 +00:00
sync_test.go Refactor change computation for sync (#785) 2023-10-03 13:47:46 +00:00
tags_test.go Run tests to verify backend tag validation behavior (#814) 2023-09-29 08:38:06 +00:00
version_test.go Use cmdio in version command for `--output` flag (#419) 2023-06-01 12:03:22 +02:00
workspace_test.go Enabled incorrectly skipped tests (#1280) 2024-03-14 12:56:21 +00:00