mirror of https://github.com/databricks/cli.git
cleanup todos
This commit is contained in:
parent
39cb5e8471
commit
13748f177d
|
@ -9,13 +9,10 @@ type Volume struct {
|
|||
// List of grants to apply on this schema.
|
||||
Grants []Grant `json:"grants,omitempty"`
|
||||
|
||||
// TODO: Confirm the accuracy of this comment.
|
||||
// Full name of the schema (catalog_name.schema_name.volume_name). This value is read from
|
||||
// the terraform state after deployment succeeds.
|
||||
ID string `json:"id,omitempty" bundle:"readonly"`
|
||||
|
||||
// TODO: Are there fields in the edit API or terraform that are not in this struct?
|
||||
// If so call it out in the PR.
|
||||
*catalog.CreateVolumeRequestContent
|
||||
|
||||
ModifiedStatus ModifiedStatus `json:"modified_status,omitempty" bundle:"internal"`
|
||||
|
|
|
@ -10,10 +10,6 @@ import (
|
|||
"github.com/databricks/cli/libs/log"
|
||||
)
|
||||
|
||||
// TODO: Articulate the consequences of deleting a UC volume in the prompt message that
|
||||
// is displayed.
|
||||
// TODO: What sort of interpolation should be allowed at `artifact_path`? Should it be
|
||||
// ${volumes.foo.id} or ${volumes.foo.name} or something else?
|
||||
func convertVolumeResource(ctx context.Context, vin dyn.Value) (dyn.Value, error) {
|
||||
// Normalize the output value to the target schema.
|
||||
vout, diags := convert.Normalize(schema.ResourceVolume{}, vin)
|
||||
|
|
Loading…
Reference in New Issue