steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cleanup todos

This commit is contained in:
Shreyas Goenka 2024-09-16 03:14:30 +02:00
parent 39cb5e8471
commit 13748f177d
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
2 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bundle/config/resources/volume.go
View File

@ -9,13 +9,10 @@ type Volume struct {
// List of grants to apply on this schema. // List of grants to apply on this schema.
Grants []Grant `json:"grants,omitempty"` Grants []Grant `json:"grants,omitempty"`
// TODO: Confirm the accuracy of this comment.
// Full name of the schema (catalog_name.schema_name.volume_name). This value is read from // Full name of the schema (catalog_name.schema_name.volume_name). This value is read from
// the terraform state after deployment succeeds. // the terraform state after deployment succeeds.
ID string `json:"id,omitempty" bundle:"readonly"` ID string `json:"id,omitempty" bundle:"readonly"`
// TODO: Are there fields in the edit API or terraform that are not in this struct?
// If so call it out in the PR.
*catalog.CreateVolumeRequestContent *catalog.CreateVolumeRequestContent
ModifiedStatus ModifiedStatus `json:"modified_status,omitempty" bundle:"internal"` ModifiedStatus ModifiedStatus `json:"modified_status,omitempty" bundle:"internal"`

4
bundle/deploy/terraform/tfdyn/convert_volume.go
View File

@ -10,10 +10,6 @@ import (
"github.com/databricks/cli/libs/log" "github.com/databricks/cli/libs/log"
) )
// TODO: Articulate the consequences of deleting a UC volume in the prompt message that
// is displayed.
// TODO: What sort of interpolation should be allowed at `artifact_path`? Should it be
// ${volumes.foo.id} or ${volumes.foo.name} or something else?
func convertVolumeResource(ctx context.Context, vin dyn.Value) (dyn.Value, error) { func convertVolumeResource(ctx context.Context, vin dyn.Value) (dyn.Value, error) {
// Normalize the output value to the target schema. // Normalize the output value to the target schema.
vout, diags := convert.Normalize(schema.ResourceVolume{}, vin) vout, diags := convert.Normalize(schema.ResourceVolume{}, vin)