steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove todos

This commit is contained in:
Shreyas Goenka 2023-06-29 18:56:33 +02:00
parent 2854bc196c
commit 3959ca1317
No known key found for this signature in database
GPG Key ID: 92A07DF49CCB0622
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/git/clone.go
View File

@ -52,7 +52,6 @@ func (opts CloneOptions) zipUrl() string {
return fmt.Sprintf(`%s/archive/%s.zip`, opts.repoUrl(), opts.Reference)
}
// TODO: test this holds true for alternate branches and tags
func (opts CloneOptions) destination() string {
return filepath.Join(opts.TargetDir, opts.RepositoryName+"-"+opts.Reference)
}
@ -88,7 +87,6 @@ func download(ctx context.Context, url string, dest string) error {
}
func clonePrivate(ctx context.Context, opts CloneOptions) error {
// TODO: test that the branch --branch flag works with tags
cmd := exec.CommandContext(ctx, "git", "clone", opts.repoUrl(), opts.destination(), "--branch", opts.Reference)
// Redirect exec command output