mirror of https://github.com/databricks/cli.git
1654 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
dependabot[bot]
|
4bc231ad4f
|
Bump golang.org/x/oauth2 from 0.25.0 to 0.26.0 (#2322)
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from
0.25.0 to 0.26.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="
|
|
shreyas-goenka
|
6953a84db6
|
Serialize recorded requests with indentation in acceptance tests (#2329)
## Changes This PR indents the recorded requests to make them easier to review. They can still be parsed using jq. ## Tests Existing tests. |
|
|
shreyas-goenka
|
ddedc4272d
|
Return 501 status code when API stub is not implemented (#2327)
## Changes Addresses feedback from https://github.com/databricks/cli/pull/2292#discussion_r1946846865 ## Tests Manually, confirmed that unstubbed API calls still cause acceptance tests to fail. |
|
Denis Bilenko
|
d282f33a22
|
Append newline to "-o json" for validate/summary/run (#2326)
## Changes - Insert newline after rendering indented JSON in bundle validate/summary/run. - This prevents "No newline at end of file" message in various cases, for example when switching between recording raw output of the command to output processed by jq, since jq does add a newline or when running diff in acceptance tests. ## Tests Manually running validate: ``` ~/work/dabs_cuj_brickfood % ../cli/cli-main bundle validate -o json | tail -n 2 # without change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } }% ~/work/dabs_cuj_brickfood % ../cli/cli bundle validate -o json | tail -n 2 # with change Error: root_path must start with '~/' or contain the current username to ensure uniqueness when using 'mode: development' } } ~/work/dabs_cuj_brickfood % ``` Via #2316 -- see cleaner output there. |
|
|
dependabot[bot]
|
047691dd91
|
Bump github.com/databricks/databricks-sdk-go from 0.56.1 to 0.57.0 (#2321)
Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.56.1 to 0.57.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sdk-go/releases">github.com/databricks/databricks-sdk-go's releases</a>.</em></p> <blockquote> <h2>v0.57.0</h2> <h2>[Release] Release v0.57.0</h2> <h3>New Features and Improvements</h3> <ul> <li>Add support for async OAuth token refreshes (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1135">#1135</a>).</li> </ul> <h3>API Changes:</h3> <ul> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#BudgetPolicyAPI">a.BudgetPolicy</a> account-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#EnableIpAccessListsAPI">a.EnableIpAccessLists</a> account-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewEmbeddedAPI">w.LakeviewEmbedded</a> workspace-level service and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#QueryExecutionAPI">w.QueryExecution</a> workspace-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/sql#RedashConfigAPI">w.RedashConfig</a> workspace-level service.</li> <li>Added <code>GcpOauthToken</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#TemporaryCredentials">catalog.TemporaryCredentials</a>.</li> <li>Added <code>Options</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateCatalog">catalog.UpdateCatalog</a>.</li> <li>Added <code>StatementId</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#QueryAttachment">dashboards.QueryAttachment</a>.</li> <li>Added <code>EffectivePerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun">jobs.BaseRun</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob">jobs.CreateJob</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings">jobs.JobSettings</a>.</li> <li>Added <code>EffectivePerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run">jobs.Run</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunNow">jobs.RunNow</a>.</li> <li>Added <code>Disabled</code> and <code>EffectivePerformanceTarget</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask">jobs.RunTask</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#CreateCustomAppIntegration">oauth2.CreateCustomAppIntegration</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#GetCustomAppIntegrationOutput">oauth2.GetCustomAppIntegrationOutput</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateCustomAppIntegration">oauth2.UpdateCustomAppIntegration</a>.</li> <li>Added <code>Contents</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#HttpRequestResponse">serving.HttpRequestResponse</a>.</li> <li>Changed <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service to type <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service.</li> <li>Changed <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service to return <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#HttpRequestResponse">serving.HttpRequestResponse</a>.</li> <li>Removed <code>SecurableKind</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CatalogInfo">catalog.CatalogInfo</a>.</li> <li>Removed <code>SecurableKind</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ConnectionInfo">catalog.ConnectionInfo</a>.</li> <li>Removed <code>StatusCode</code> and <code>Text</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalFunctionResponse">serving.ExternalFunctionResponse</a>.</li> </ul> <p>OpenAPI SHA: c72c58f97b950fcb924a90ef164bcb10cfcd5ece, Date: 2025-02-03</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md">github.com/databricks/databricks-sdk-go's changelog</a>.</em></p> <blockquote> <h2>[Release] Release v0.57.0</h2> <h3>New Features and Improvements</h3> <ul> <li>Add support for async OAuth token refreshes (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/1135">#1135</a>).</li> </ul> <h3>API Changes:</h3> <ul> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/billing#BudgetPolicyAPI">a.BudgetPolicy</a> account-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#EnableIpAccessListsAPI">a.EnableIpAccessLists</a> account-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#LakeviewEmbeddedAPI">w.LakeviewEmbedded</a> workspace-level service and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#QueryExecutionAPI">w.QueryExecution</a> workspace-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/sql#RedashConfigAPI">w.RedashConfig</a> workspace-level service.</li> <li>Added <code>GcpOauthToken</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#TemporaryCredentials">catalog.TemporaryCredentials</a>.</li> <li>Added <code>Options</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateCatalog">catalog.UpdateCatalog</a>.</li> <li>Added <code>StatementId</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/dashboards#QueryAttachment">dashboards.QueryAttachment</a>.</li> <li>Added <code>EffectivePerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#BaseRun">jobs.BaseRun</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob">jobs.CreateJob</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings">jobs.JobSettings</a>.</li> <li>Added <code>EffectivePerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#Run">jobs.Run</a>.</li> <li>Added <code>PerformanceTarget</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunNow">jobs.RunNow</a>.</li> <li>Added <code>Disabled</code> and <code>EffectivePerformanceTarget</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#RunTask">jobs.RunTask</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#CreateCustomAppIntegration">oauth2.CreateCustomAppIntegration</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#GetCustomAppIntegrationOutput">oauth2.GetCustomAppIntegrationOutput</a>.</li> <li>Added <code>UserAuthorizedScopes</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#UpdateCustomAppIntegration">oauth2.UpdateCustomAppIntegration</a>.</li> <li>Added <code>Contents</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#HttpRequestResponse">serving.HttpRequestResponse</a>.</li> <li>Changed <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service to type <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service.</li> <li>Changed <code>HttpRequest</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ServingEndpointsAPI">w.ServingEndpoints</a> workspace-level service to return <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#HttpRequestResponse">serving.HttpRequestResponse</a>.</li> <li>Removed <code>SecurableKind</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CatalogInfo">catalog.CatalogInfo</a>.</li> <li>Removed <code>SecurableKind</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#ConnectionInfo">catalog.ConnectionInfo</a>.</li> <li>Removed <code>StatusCode</code> and <code>Text</code> fields for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ExternalFunctionResponse">serving.ExternalFunctionResponse</a>.</li> </ul> <p>OpenAPI SHA: c72c58f97b950fcb924a90ef164bcb10cfcd5ece, Date: 2025-02-03</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
shreyas-goenka
|
ee440e65fe
|
Serialize all header values in acceptance tests (#2311)
## Changes Based on feedback in https://github.com/databricks/cli/pull/2296#discussion_r1946660650. Previously we only serialized the first value for a header in the requests log. Now we serialise all values for a header key. ## Tests Existing test |
|
|
Denis Bilenko
|
4ebc86282f
|
acc: Split bundle/templates and bundle/templates-machinery (#2317)
The tests in acceptance/bundle/template focus on standard templates. The plan is to extend them with "bundle deploy" and enable them on the cloud. The tests in acceptance/bundle/template-machinery focus on specific aspects of template implementation. Most of them are expected to remain local-only. |
|
|
Denis Bilenko
|
cc07380185
|
acc: Summarize unexpected files (#2320)
## Changes
When there are many unexpected files, it's good to see them as a list
rather than scattered throughout the output.
<!-- Summary of your changes that are easy to understand -->
## Tests
Manually, example output:
```
acceptance_test.go:363: Test produced unexpected files:
output/my_default_sql/.databricks/bundle/dev/sync-snapshots/71c79ded90615dc7.json
output/my_default_sql/.databricks/bundle/dev/terraform/.terraform/providers/registry.terraform.io/databricks/databricks/1.64.1/darwin_arm64
output/my_default_sql/.databricks/bundle/dev/terraform/plan
output/my_default_sql/.databricks/bundle/prod/sync-snapshots/83e677e75259c93b.json
output/my_default_sql/.databricks/bundle/prod/terraform/.terraform/providers/registry.terraform.io/databricks/databricks/1.64.1/darwin_arm64
```
|
|
|
Denis Bilenko
|
2175dd24a4
|
Do not gitignore .databricks and terraform (#2318)
For acceptance/bundle/templates I'd like to run "bundle deploy". This would create .databricks directory inside materialized output. It might makes sense to commit some of this as part of golden files output. Even if we did not commit anything, the test runner will see those files and show the difference. Thus git should also see them. Also rename .gitignore to out.gitignore in those tests, since that includes .databricks as well. |
|
|
Denis Bilenko
|
06e342afc5
|
Silence a comment in Makefile (#2315)
It was not indended to be printed. Follow up to #2298 |
|
Andrew Nester
|
f8aaa7fce3
|
Added support to generate Git based jobs (#2304)
## Changes This will generate bundle YAML configuration for Git based jobs but won't download any related files as they are in Git repo. Fixes #1423 ## Tests Added unit test --------- Co-authored-by: Pieter Noordhuis <pieter.noordhuis@databricks.com> |
|
|
Andrew Nester
|
2a97dcaa45
|
Raise an error when there are multiple local libraries with the same basename used (#2297)
## Changes Raise an error when there are multiple local libraries with the same basename used Fixes #1674 ## Tests Added an unit test |
|
|
Denis Bilenko
|
6d83ffd109
|
acc: enable bundle/scripts on cloud (#2313) | |
|
Denis Bilenko
|
989aabe5f1
|
acc: Make variable tests local-only (#2312)
Makes use of #2294 |
|
|
Andrew Nester
|
5aa89230e9
|
Use CreatePipeline instead of PipelineSpec for resources.Pipeline struct (#2287)
## Changes `CreatePipeline` is a more complete structure (superset of PipelineSpec one) which enables support of additional fields such as `run_as` and `allow_duplicate_names` in DABs configuration. Note: these fields are subject to support in TF in order to correctly work. ## Tests Existing tests pass + no fields are removed from JSON schema |
|
|
Denis Bilenko
|
ff4a5c2269
|
acc: Implement config merge (#2294)
## Changes
Instead of using leaf-most config, all configs from root at
acceptance/test.toml to all intermediate ones to leaf config are merged
into one. Maps are merged, slices are appended, other values are
overridden.
I had to disable caching, because it is tricky when merging is involved
- deep copy is needed. There is performance
impact but currently it is tiny, about 1%.
Also, remove empty root config.
## Tests
Manually checked that inheritance of LocalOnly setting worked for these
tests:
Before - integration tests showed:
```
PASS acceptance.TestAccept/bundle/templates/wrong-url (0.70s)
PASS acceptance.TestAccept/bundle/templates/wrong-path (0.44s)
```
After:
```
SKIP acceptance.TestAccept/bundle/templates/wrong-url (0.00s)
SKIP acceptance.TestAccept/bundle/templates/wrong-path (0.00s)
acceptance_test.go:216: Disabled via LocalOnly setting in bundle/templates/test.toml, bundle/templates/wrong-path/test.toml (CLOUD_ENV=***)
```
|
|
|
shreyas-goenka
|
f71583fbc0
|
Error when unknown API endpoint is used in testserver (#2292)
## Changes
This PR fails the acceptance test when an unknown endpoint (i.e. not
stubbed) is used. We want to ensure that all API endpoints used in an
acceptance test are stubbed and do not otherwise silently fail with a
404.
The logs on failure output include a configuration that developers can
simply copy-paste to `test.toml` to stub the missing API endpoint. It'll
look something like:
```
[[Server]]
Pattern = "<method> <path>"
Response.Body = '''
<response body here>
'''
Response.StatusCode = <response status-code here>
```
## Tests
Manually:
output.txt when an endpoint is not found:
```
>>> [CLI] jobs create --json {"name":"abc"}
Error: No stub found for pattern: POST /api/2.1/jobs/create
```
How this renders in the test logs:
```
--- FAIL: TestAccept/workspace/jobs/create (0.03s)
server.go:46:
----------------------------------------
No stub found for pattern: POST /api/2.1/jobs/create
To stub a response for this request, you can add
the following to test.toml:
[[Server]]
Pattern = "POST /api/2.1/jobs/create"
Response.Body = '''
<response body here>
'''
Response.StatusCode = <response status-code here>
----------------------------------------
```
Manually checked that the debug mode still works.
|
|
|
Denis Bilenko
|
6b1a778fe1
|
Fix flaky acceptance test (#2310)
## Changes
Replace timestamps with fixed string before output is sorted (and before
test runner replacements are applied).
Otherwise the test sometimes fails with error below. Note, timestamps
themselves do not show it, because they were replaced.
```
--- FAIL: TestAccept/bundle/debug (0.78s)
acceptance_test.go:404: Diff:
--- bundle/debug/out.stderr.parallel.txt
+++ /var/folders/5y/9kkdnjw91p11vsqwk0cvmk200000gp/T/TestAcceptbundledebug1859985035/001/out.stderr.parallel.txt
@@ -8,8 +8,8 @@
10:07:59 Debug: ApplyReadOnly pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync
10:07:59 Debug: ApplyReadOnly pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:folder_permissions
10:07:59 Debug: ApplyReadOnly pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:validate_sync_patterns
-10:07:59 Debug: Path /Workspace/Users/[USERNAME]/.bundle/debug/default/files has type directory (ID: 0) pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync
10:07:59 Debug: non-retriable error: pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync sdk=true
+10:07:59 Debug: Path /Workspace/Users/[USERNAME]/.bundle/debug/default/files has type directory (ID: 0) pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync
< {} pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync sdk=true
< {} pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync sdk=true
< } pid=12345 mutator=validate mutator (read-only)=parallel mutator (read-only)=validate:files_to_sync sdk=true
```
## Tests
Running `hyperfine --min-runs 10 'go test ../.. -run
^TestAccept$/^bundle$/^debug$ -count=1' --show-output` detects flakiness
on main but not with this PR.
|
|
|
Andrew Nester
|
ecb816446e
|
Update app deploy test to confirm app config changes on redeploy (#2301)
## Changes
Adds additional step to integration test which changes the app config
and confirms it's updated after redeploy
## Tests
```
helpers_test.go:156: stderr: Deleting files...
helpers_test.go:156: stderr: Destroy complete!
--- PASS: TestDeployBundleWithApp (470.25s)
PASS
coverage: [no statements]
ok github.com/databricks/cli/integration/bundle 470.981s coverage: [no statements]
```
|
|
|
Denis Bilenko
|
ecc05689ca
|
Add a couple of tests for bundle init with custom template (#2293)
These test custom template and what happens if helper function returns an error. |
|
|
shreyas-goenka
|
65ac9a336a
|
Add doc string for the `auth token` command (#2302)
## Changes The intent of this PR is to clarify that the `databricks auth token` command is not supported for M2M auth. Fixes: https://github.com/databricks/cli/issues/1939 ## Tests Manually. |
|
|
Denis Bilenko
|
54e16d5f62
|
Always print warnings and errors; clean up format (#2213)
## Changes - Print warnings and errors by default. - Fix ErrAlreadyPrinted not to be logged at Error level. - Format log messages as "Warn: message" instead of "WARN" to make it more readable and in-line with the rest of the output. - Only print attributes (pid, mutator, etc) and time when the overall level is debug (so --debug output has not changed much). ## Tests - Existing acceptance tests show how warning messages appear in various test case. - Added new test for `--debug` output. - Add sort_lines.py helper to avoid dependency on 'sort' which is locale-sensitive. |
|
Gleb Kanterov
|
75127fe42e
|
Extend testserver for deployment (#2299)
## Changes Extend testserver for bundle deployment: - Allocate a new workspace per test case to isolate test cases from each other - Support jobs get/list/create - Support creation and listing of workspace files ## Tests Using existing acceptance tests |
|
Ilya Kuznetsov
|
27eb0c4072
|
Allow 'any' examples in JSON schema (#2289)
## Changes 1. Allow `any` examples in json-schema type since we have many of them in open api spec 2. Fix issue with missing overrides annotations when re-generating the schema ## Tests <!-- How is this tested? --> |
|
|
Denis Bilenko
|
e0903fbd37
|
Include 'go mod tidy' into 'make' and 'make tidy' (#2298)
Apparently, it's not part of golangci-lint, so you can send PRs that fail this check on CI. |
|
Marcin Wojtyczka
|
27caf413f2
|
Add support for extras to the labs CLI (#2288)
## Changes Added support for extras / optional Python dependencies in the labs CLI. Added new `extras` field under install. Example: ```yaml install: script: install.py extras: cli ``` Resolves: #2257 ## Tests Manual test |
|
|
Andrew Nester
|
5c90752797
|
acc: Added acceptance test for CLI commands inside bundle with and without profile flag (#2270)
## Changes This encodes existing behaviour in CLI as reported here: #1358 |
|
|
shreyas-goenka
|
57b8d336e0
|
Add ability to record headers in acceptance tests (#2296)
## Changes HTTP headers like the User-Agent are an important part of our internal ETL pipelines. This PR adds the ability to validate the headers used in an HTTP request as part of our acceptance tests. ## Tests Modifying existing test. |
|
|
Ilya Kuznetsov
|
1678503cb0
|
Fix docs template (#2283)
## Changes Comment breaks markdown front-matter and description cannot be read ## Tests <!-- How is this tested? --> |
|
Pieter Noordhuis
|
2e1455841c
|
Update CODEOWNERS for cmd/labs (#2295)
## Changes The `CODEOWNERS` file must live in one of the directories specified in the [docs][docs], so the existing file under `cmd/labs` didn't work. This change moves the contents to the top-level file and includes @alexott as owner. [docs]: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-file-location |
|
rikjansen-hu
|
dcc61cd763
|
Fix env variable for AzureCli local config (#2248)
## Changes Solves #1722 (current solution passes wrong variable) ## Tests None, this is a simple find-and-replace on a previous PR. Proof that this is the correct [variable](https://learn.microsoft.com/en-us/cli/azure/azure-cli-configuration#cli-configuration-file). This just passes the variable along to the Terraform environment, which [should](https://github.com/hashicorp/terraform/issues/25416) be picked up by Terraform. Co-authored-by: Rik Jansen <rik.jansen2@nl.abnamro.com> |
|
Simon Poltier
|
84b694f2a1
|
accept JSON includes (#2265)
#2201 disabled using JSON as part of a bundle definition. I believe this was not intended. ## Changes Accept json files as includes, just as YAML files. ## Tests Covered by the tests in #2201 |
|
|
shreyas-goenka
|
d86ad91899
|
Allow test servers to return errors responses (#2291)
## Changes
The APIs at Databricks when returning a non `200` status code will
return a response body of the format:
```
{
"error_code": "Error code",
"message": "Human-readable error message."
}
```
This PR adds the ability to stub non-200 status codes in the test
server, allowing us to mock API errors from Databricks.
## Tests
New test
|
|
|
Denis Bilenko
|
07efe83023
|
Use go-version-file instead of go-version in github actions (#2290)
This minimizes number of places where we hard-code go version.
Note, since we have go version specified without patch version ("1.23")
in go.mod, it will use most recent in 1.23.x line. I think this is fine.
https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file
|
|
|
dependabot[bot]
|
2eb9abb5ee
|
Bump github.com/spf13/pflag from 1.0.5 to 1.0.6 (#2281)
Bumps [github.com/spf13/pflag](https://github.com/spf13/pflag) from 1.0.5 to 1.0.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/pflag/releases">github.com/spf13/pflag's releases</a>.</em></p> <blockquote> <h2>v1.0.6</h2> <h2>What's Changed</h2> <ul> <li>Add exported functions to preserve <code>pkg/flag</code> compatibility by <a href="https://github.com/mckern"><code>@mckern</code></a> in <a href="https://redirect.github.com/spf13/pflag/pull/220">spf13/pflag#220</a></li> <li>remove dead code for checking error nil by <a href="https://github.com/yashbhutwala"><code>@yashbhutwala</code></a> in <a href="https://redirect.github.com/spf13/pflag/pull/282">spf13/pflag#282</a></li> <li>Add IPNetSlice and unit tests by <a href="https://github.com/rpothier"><code>@rpothier</code></a> in <a href="https://redirect.github.com/spf13/pflag/pull/170">spf13/pflag#170</a></li> <li>allow for blank ip addresses by <a href="https://github.com/duhruh"><code>@duhruh</code></a> in <a href="https://redirect.github.com/spf13/pflag/pull/316">spf13/pflag#316</a></li> <li>add github actions by <a href="https://github.com/sagikazarmark"><code>@sagikazarmark</code></a> in <a href="https://redirect.github.com/spf13/pflag/pull/419">spf13/pflag#419</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/mckern"><code>@mckern</code></a> made their first contribution in <a href="https://redirect.github.com/spf13/pflag/pull/220">spf13/pflag#220</a></li> <li><a href="https://github.com/yashbhutwala"><code>@yashbhutwala</code></a> made their first contribution in <a href="https://redirect.github.com/spf13/pflag/pull/282">spf13/pflag#282</a></li> <li><a href="https://github.com/rpothier"><code>@rpothier</code></a> made their first contribution in <a href="https://redirect.github.com/spf13/pflag/pull/170">spf13/pflag#170</a></li> <li><a href="https://github.com/duhruh"><code>@duhruh</code></a> made their first contribution in <a href="https://redirect.github.com/spf13/pflag/pull/316">spf13/pflag#316</a></li> <li><a href="https://github.com/sagikazarmark"><code>@sagikazarmark</code></a> made their first contribution in <a href="https://redirect.github.com/spf13/pflag/pull/419">spf13/pflag#419</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/spf13/pflag/compare/v1.0.5...v1.0.6">https://github.com/spf13/pflag/compare/v1.0.5...v1.0.6</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
Denis Bilenko
|
9320bd1682
|
acc: Use [VARNAME] instead of $VARNAME (#2282)
$VARNAME is what we use for environment variables, it's good to separate. Some people use envsubst for homemade variable interpolation, it's also good to have separation there. |
|
|
dependabot[bot]
|
838de2fde2
|
Bump github.com/hashicorp/terraform-exec from 0.21.0 to 0.22.0 (#2237)
Bumps [github.com/hashicorp/terraform-exec](https://github.com/hashicorp/terraform-exec) from 0.21.0 to 0.22.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/hashicorp/terraform-exec/releases">github.com/hashicorp/terraform-exec's releases</a>.</em></p> <blockquote> <h2>v0.22.0</h2> <p>ENHANCEMENTS:</p> <ul> <li>tfexec: Add support for <code>terraform init --json</code> via <code>InitJSON</code> (<a href="https://redirect.github.com/hashicorp/terraform-exec/pull/478">#478</a>)</li> </ul> <p>INTERNAL:</p> <ul> <li>go: Require Go 1.22 (previously 1.18) (<a href="https://redirect.github.com/hashicorp/terraform-exec/pull/499">#499</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/hashicorp/terraform-exec/blob/main/CHANGELOG.md">github.com/hashicorp/terraform-exec's changelog</a>.</em></p> <blockquote> <h1>0.22.0 (January 21, 2025)</h1> <p>ENHANCEMENTS:</p> <ul> <li>tfexec: Add support for <code>terraform init --json</code> via <code>InitJSON</code> (<a href="https://redirect.github.com/hashicorp/terraform-exec/pull/478">#478</a>)</li> </ul> <p>INTERNAL:</p> <ul> <li>go: Require Go 1.22 (previously 1.18) (<a href="https://redirect.github.com/hashicorp/terraform-exec/pull/499">#499</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
75db82ae1f
|
Bump actions/create-github-app-token from 1.11.1 to 1.11.2 (#2276)
Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 1.11.1 to 1.11.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/create-github-app-token/releases">actions/create-github-app-token's releases</a>.</em></p> <blockquote> <h2>v1.11.2</h2> <h2><a href="https://github.com/actions/create-github-app-token/compare/v1.11.1...v1.11.2">1.11.2</a> (2025-01-30)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>deps:</strong> bump <code>@octokit/request</code> from 9.1.3 to 9.1.4 in the production-dependencies group (<a href="https://redirect.github.com/actions/create-github-app-token/issues/196">#196</a>) (<a href=" |
|
|
dependabot[bot]
|
4f3a289333
|
Bump actions/stale from 9.0.0 to 9.1.0 (#2275)
Bumps [actions/stale](https://github.com/actions/stale) from 9.0.0 to 9.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v9.1.0</h2> <h2>What's Changed</h2> <ul> <li>Documentation update by <a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1116">actions/stale#1116</a></li> <li>Add workflow file for publishing releases to immutable action package by <a href="https://github.com/Jcambass"><code>@Jcambass</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1179">actions/stale#1179</a></li> <li>Update undici from 5.28.2 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1150">actions/stale#1150</a></li> <li>Update actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1091">actions/stale#1091</a></li> <li>Update actions/publish-action from 0.2.2 to 0.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1147">actions/stale#1147</a></li> <li>Update ts-jest from 29.1.1 to 29.2.5 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1175">actions/stale#1175</a></li> <li>Update <code>@actions/core</code> from 1.10.1 to 1.11.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1191">actions/stale#1191</a></li> <li>Update <code>@types/jest</code> from 29.5.11 to 29.5.14 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1193">actions/stale#1193</a></li> <li>Update <code>@actions/cache</code> from 3.2.2 to 4.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/stale/pull/1194">actions/stale#1194</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1116">actions/stale#1116</a></li> <li><a href="https://github.com/Jcambass"><code>@Jcambass</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1179">actions/stale#1179</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/stale/compare/v9...v9.1.0">https://github.com/actions/stale/compare/v9...v9.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
75932198f7
|
Bump astral-sh/ruff-action from 3.0.1 to 3.1.0 (#2274)
Bumps [astral-sh/ruff-action](https://github.com/astral-sh/ruff-action) from 3.0.1 to 3.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/astral-sh/ruff-action/releases">astral-sh/ruff-action's releases</a>.</em></p> <blockquote> <h2>v3.1.0 🌈 Determine ruff version from optional or dependency groups</h2> <h2>Changes</h2> <p>Big thank you to <a href="https://github.com/AA-Turner"><code>@AA-Turner</code></a> for expanding the pyproject.toml parsing to also find the ruff version to use in the following scenarios:</p> <pre lang="toml"><code>[dependency-groups] dev = [ { include-group = "docs" }, { include-group = "lint" }, ] docs = [ "sphinx", ] lint = [ "ruff==0.8.3", ] </code></pre> <pre lang="toml"><code>[project.optional-dependencies] lint = [ "ruff==0.8.3", ] </code></pre> <h2>🚀 Enhancements</h2> <ul> <li>Read the <code>[project.optional-dependencies]</code> and <code>[dependency-groups]</code> tables <a href="https://github.com/AA-Turner"><code>@AA-Turner</code></a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/66">#66</a>)</li> </ul> <h2>v3.0.2 🌈 Full support for GHES</h2> <h2>Changes</h2> <p>This release fixes some issues that prevented use with GitHub Enterprise Server instances. Parsing the ruff version from pyproject.toml now also uses a library that is fully TOML 1.0.0 compliant.</p> <h2>🐛 Bug fixes</h2> <ul> <li>Do not expect GITHUB_TOKEN to be set or valid <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/65">#65</a>)</li> <li>Use TOML 1.0.0 compliant library for parsing <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/47">#47</a>)</li> </ul> <h2>🧰 Maintenance</h2> <ul> <li>Fix compiled known versions <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/62">#62</a>)</li> <li>chore: update known checksums for 0.9.3 @<a href="https://github.com/apps/github-actions">github-actions[bot]</a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/61">#61</a>)</li> <li>chore: update known checksums for 0.9.1 @<a href="https://github.com/apps/github-actions">github-actions[bot]</a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/42">#42</a>)</li> </ul> <h2>📚 Documentation</h2> <ul> <li>Fix Markdown link to Install the latest version <a href="https://github.com/eifinger"><code>@eifinger</code></a> (<a href="https://redirect.github.com/astral-sh/ruff-action/issues/58">#58</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
91e04cc444
|
Bump golangci/golangci-lint-action from 6.1.1 to 6.2.0 (#2273)
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.1.1 to 6.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's releases</a>.</em></p> <blockquote> <h2>v6.2.0</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Changes</h3> <ul> <li>chore: use new build tag syntax by <a href="https://github.com/alexandear"><code>@alexandear</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1133">golangci/golangci-lint-action#1133</a></li> <li>feat: support linux arm64 public preview by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1144">golangci/golangci-lint-action#1144</a></li> </ul> <h3>Documentation</h3> <ul> <li>docs: update local development instructions by <a href="https://github.com/dmitris"><code>@dmitris</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1125">golangci/golangci-lint-action#1125</a></li> </ul> <h3>Dependencies</h3> <ul> <li>build(deps-dev): bump the dev-dependencies group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1112">golangci/golangci-lint-action#1112</a></li> <li>build(deps): bump the dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1113">golangci/golangci-lint-action#1113</a></li> <li>build(deps-dev): bump the dev-dependencies group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1114">golangci/golangci-lint-action#1114</a></li> <li>build(deps): bump <code>@types/node</code> from 22.7.4 to 22.7.5 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1115">golangci/golangci-lint-action#1115</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1117">golangci/golangci-lint-action#1117</a></li> <li>build(deps): bump <code>@types/node</code> from 22.7.5 to 22.7.7 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1118">golangci/golangci-lint-action#1118</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1119">golangci/golangci-lint-action#1119</a></li> <li>build(deps): bump <code>@types/node</code> from 22.7.7 to 22.8.1 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1120">golangci/golangci-lint-action#1120</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1122">golangci/golangci-lint-action#1122</a></li> <li>build(deps): bump the dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1123">golangci/golangci-lint-action#1123</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1126">golangci/golangci-lint-action#1126</a></li> <li>build(deps): bump <code>@types/node</code> from 22.8.7 to 22.9.0 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1127">golangci/golangci-lint-action#1127</a></li> <li>build(deps-dev): bump the dev-dependencies group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1128">golangci/golangci-lint-action#1128</a></li> <li>build(deps): bump <code>@types/node</code> from 22.9.0 to 22.9.3 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1130">golangci/golangci-lint-action#1130</a></li> <li>build(deps): bump <code>@types/node</code> from 22.9.3 to 22.10.1 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1131">golangci/golangci-lint-action#1131</a></li> <li>build(deps-dev): bump the dev-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1132">golangci/golangci-lint-action#1132</a></li> <li>build(deps-dev): bump the dev-dependencies group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1134">golangci/golangci-lint-action#1134</a></li> <li>build(deps): bump <code>@actions/cache</code> from 3.3.0 to 4.0.0 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1135">golangci/golangci-lint-action#1135</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1136">golangci/golangci-lint-action#1136</a></li> <li>build(deps): bump <code>@types/node</code> from 22.10.1 to 22.10.2 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1137">golangci/golangci-lint-action#1137</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1138">golangci/golangci-lint-action#1138</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1139">golangci/golangci-lint-action#1139</a></li> <li>build(deps-dev): bump the dev-dependencies group with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1141">golangci/golangci-lint-action#1141</a></li> <li>build(deps): bump <code>@types/node</code> from 22.10.2 to 22.10.5 in the dependencies group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1142">golangci/golangci-lint-action#1142</a></li> <li>build(deps-dev): bump the dev-dependencies group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1143">golangci/golangci-lint-action#1143</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/dmitris"><code>@dmitris</code></a> made their first contribution in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1125">golangci/golangci-lint-action#1125</a></li> <li><a href="https://github.com/alexandear"><code>@alexandear</code></a> made their first contribution in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1133">golangci/golangci-lint-action#1133</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v6.1.1...v6.2.0">https://github.com/golangci/golangci-lint-action/compare/v6.1.1...v6.2.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
Denis Bilenko
|
f267318bb9
|
Include acceptance tests in integration tests (#2242)
## Changes - Include acceptance directory in integration tests. Acceptance tests will not start local server if CLOUD_ENV is set, so they become integration tests. - Add dependency for vendor to integration, so that CLI can be build there. - Implement LocalOnly option in test.toml to opt out of running acceptance tests as integration tests. Use it in certain tests that are difficult or not necessary to fix when run as integration tests. - Update terraform test to redact timings out. - Clean up .workspace.current_user from outputs of the tests. ## Tests Existing tests. |
|
|
Denis Bilenko
|
fcedfe4c78
|
acc: Consistent & detailed output for file issues (#2279)
## Changes - Include compact relPath in the error message title. Include full paths in separate lines below. - Previously sometimes full paths were printed, sometime only rel path. ## Tests Manually trigger the errors. |
|
|
Denis Bilenko
|
2f798c4ded
|
acc: Remove initial '$CLI --version' call (#2280)
It is proven to be not necessary. ``` ~/work/cli/acceptance % hyperfine -w 2 'go test' # with change: Benchmark 1: go test Time (mean ± σ): 4.983 s ± 0.209 s [User: 6.073 s, System: 9.869 s] Range (min … max): 4.792 s … 5.483 s 10 runs ~/work/cli/acceptance % git stash # without change: ~/work/cli/acceptance % hyperfine -w 2 'go test' Benchmark 1: go test Time (mean ± σ): 5.018 s ± 0.100 s [User: 6.142 s, System: 10.234 s] Range (min … max): 4.899 s … 5.182 s 10 runs ``` |
|
|
Denis Bilenko
|
e5730bf57e
|
Use real terraform in acceptance tests (#2267)
## Changes - Add a script install_terraform.py that downloads terraform and provider and generates a config to use, inspired by https://gist.github.com/pietern/1cb6b6f3e0a452328e13cdc75031105e - Make acceptance tests run this script once before running the tests and set the required env vars to make cli use this terraform installation. - Use OS-specific directory for things that are build by acceptance test runner (CLI and terraform). This enables acceptance tests against cloud #2242 and local test for bundle deploy #2254. ## Tests - Add an acceptance test for standalone terraform. This is useful to debug terraform with TF_LOG=DEBUG to see that it uses local provider. - Other acceptance tests are updated with regard to terraform exec path. - The overall time for tests locally is unchanged (if terraform is already fetched). |
|
|
shreyas-goenka
|
787dbe9099
|
Add request body assertions to acceptance tests (#2263)
## Changes With this PR, any acceptance tests that define custom server stubs in `test.toml` will automatically record all HTTP requests made and assert on them. Builds on top of https://github.com/databricks/cli/pull/2226 ## Tests Modifying existing acceptance test. |
|
|
shreyas-goenka
|
3c6eacb05b
|
Add feature to mock server APIs in acceptance tests (#2226)
## Changes This PR allows us to define custom server stubs in a `test.toml` file. Note: A followup PR will add functionality to do assertions on the API request itself. ## Tests New acceptance test. |
|
|
Denis Bilenko
|
f1efbd7d9f
|
acc: add -norepl flag that disables replacements (for debugging) (#2269) | |
|
Denis Bilenko
|
a03ea73011
|
Add ruff.toml with increased line-length (#2268)
The default is 88 which reformats too much. This has no effect on templates but affects Python script in this PR https://github.com/databricks/cli/pull/2267 For context, we do not set any line length for golang and have 177 .go files with max line length 150 or more. |
|
|
Denis Bilenko
|
58ef34f320
|
acc: Include "id" into /api/2.0/preview/scim/v2/Me response (#2266)
This is something terraform provider expects. Related to https://github.com/databricks/cli/pull/2242 |