steve/databricks-cli
steve
/
databricks-cli
mirror of https://github.com/databricks/cli.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
1,770 Commits 135 Branches 115 Tags 152 MiB
Commit Graph

1770 Commits

Author SHA1 Message Date
Denis Bilenko 9c41156d34 clean up 2025-03-04 12:01:17 +01:00
Denis Bilenko (aider) e44373fe29 fix: Add missing closing brace in readMetadataAndRecord function 2025-03-04 11:58:13 +01:00
Denis Bilenko 3f5a1334ad refactor: Optimize metadata and record file search in wheel patching logic 2025-03-04 11:58:10 +01:00
Denis Bilenko (aider) cc07556392 fix: Handle non-seekable zip readers by reopening files 2025-03-04 11:53:52 +01:00
Denis Bilenko (aider) 9bd6229844 refactor: Improve error handling and prevent potential panics in wheel parsing 2025-03-04 11:52:45 +01:00
Denis Bilenko (aider) 6b5fa7ad33 fix: Correct variable assignment in patchwheel seeker reset 2025-03-04 11:51:04 +01:00
Denis Bilenko (aider) 7e747d29ac refactor: Simplify zip file reader seeking by removing unnecessary fallback logic 2025-03-04 11:50:12 +01:00
Denis Bilenko (aider) 80617cbb02 fix: Update patchRecord function to accept io.Reader instead of []byte 2025-03-04 11:48:08 +01:00
Denis Bilenko (aider) bbe90007d8 refactor: Optimize wheel patching by using io.Reader directly 2025-03-04 11:46:08 +01:00
Denis Bilenko 58e746757d clean up redundant comments 2025-03-04 11:37:18 +01:00
Denis Bilenko d54d093ecf do not return error from readMetadataAndRecord; make parse() work only on filenames (without path) 2025-03-04 11:34:45 +01:00
Denis Bilenko 6a7fae08ba clean up redundant comments 2025-03-04 11:21:16 +01:00
Denis Bilenko ba3062b654 rm copy 2025-03-04 10:01:45 +01:00
Denis Bilenko cc5133a5e4 clean up 2025-03-04 09:59:55 +01:00
Denis Bilenko 0aec26705f clean up 2025-03-03 21:31:58 +01:00
Denis Bilenko (aider) efa924613a refactor: Extract version verification into reusable function in patch_test.go 2025-03-03 21:14:01 +01:00
Denis Bilenko 1045dc169b refactor: Improve version verification comments in patch test 2025-03-03 21:13:59 +01:00
Denis Bilenko 84f4b5cd78 test: Add TODO comments for version verification in patch test 2025-03-03 21:12:38 +01:00
Denis Bilenko (aider) fc48cff153 fix: Implement atomic file write with temporary file in PatchWheel 2025-03-03 21:10:11 +01:00
Denis Bilenko 4afaf98324 refactor: Improve wheel patching with TODO comment and minor code cleanup 2025-03-03 21:10:08 +01:00
Denis Bilenko bc1b339f6a rename patchwheel to patch.go 2025-03-03 21:01:26 +01:00
Denis Bilenko c3b659c5e3 extract parse.go 2025-03-03 21:00:50 +01:00
Denis Bilenko (aider) 97109ec438 test: Modify writeProjectFiles to handle errors internally in tests 2025-03-03 20:58:28 +01:00
Denis Bilenko ea5690eb67 refactor: Remove commented-out code and improve test setup comment 2025-03-03 20:58:27 +01:00
Denis Bilenko 5689d6f7c2 formatting & clean up 2025-03-03 20:53:43 +01:00
Denis Bilenko (aider) 613d38d79d fix: Validate wheel metadata version and distribution against filename 2025-03-03 20:50:46 +01:00
Denis Bilenko (aider) 19b330be01 fix: Resolve variable redeclaration issues in PatchWheel function 2025-03-03 20:49:25 +01:00
Denis Bilenko (aider) f5530d9ed4 feat: Enhance wheel filename parsing and add target wheel existence check 2025-03-03 20:48:37 +01:00
Denis Bilenko 43be8ea727 refactor: Simplify wheel filename parsing and remove unused imports 2025-03-03 20:45:53 +01:00
Denis Bilenko (aider) a7e10066ca feat: Add idempotency to PatchWheel and extract version from wheel filename 2025-03-03 20:42:22 +01:00
Denis Bilenko (aider) 8d041437c7 refactor: Replace deprecated SetModTime with Modified field 2025-03-03 20:38:17 +01:00
Denis Bilenko 040bd32424 fix: Remove duplicate import of 'os' in patchwheel_test.go 2025-03-03 20:38:14 +01:00
Denis Bilenko (aider) 6babde4ae5 refactor: Update deprecated Go constructs to modern Go 1.24 practices 2025-03-03 20:37:05 +01:00
Denis Bilenko c8daa445b1 wip; add 2 digits after seconds; check outpout; use -q 2025-03-03 20:34:44 +01:00
Denis Bilenko 3888654ac6 Initial version 2025-03-03 17:25:12 +01:00
Denis Bilenko (aider) 86d7606304 refactor: improve test command execution with runCmd and captureOutput helpers 2025-03-03 16:51:02 +01:00
Denis Bilenko 8b91c207db fix: Correct variable name in runCmd and update venv path in test 2025-03-03 16:50:43 +01:00
Denis Bilenko (aider) 9c58b2eeaa refactor: update tests to use t.TempDir(), uv, and pyproject.toml 2025-03-03 16:44:14 +01:00
Denis Bilenko c0cd244e22 refactor: Add context import and TODOs for test improvements 2025-03-03 16:44:05 +01:00
Denis Bilenko (aider) 5276a5b461 refactor: Move version parsing logic from parseMetadata to caller 2025-03-03 16:20:01 +01:00
Denis Bilenko 64e7ad779a refactor: Add context import and comment for version parsing in patchwheel.go 2025-03-03 16:19:54 +01:00
Denis Bilenko (aider) 174db9432c feat: add context parameter to PatchWheel function 2025-03-03 16:17:29 +01:00
Denis Bilenko fd8f65a9da refactor: Simplify version parsing and add logging in PatchWheel 2025-03-03 16:17:13 +01:00
Denis Bilenko (aider) c814e86cf4 refactor: use constant for "Name:" prefix in metadata parsing 2025-03-03 16:13:52 +01:00
Denis Bilenko (aider) b9357fa8d2 refactor: simplify Name field parsing in parseMetadata function 2025-03-03 16:13:14 +01:00
Denis Bilenko 8bcf9ac2fe clean up 2025-03-03 16:12:32 +01:00
Denis Bilenko (aider) 965b250d89 refactor: simplify version parsing in parseMetadata function 2025-03-03 16:06:49 +01:00
Denis Bilenko cfbe899116 wip 2025-03-03 16:05:18 +01:00
Denis Bilenko 5c146ca57a
Synchronize logging in cmdio (#2418) 
## Changes
Add mutex synchronization in cmdio logger Log() method.

## Why

Since we issue multiple calls to underlying writer, we should lock the
whole method, otherwise we can get broken messages. One that can be
easily reproduced today is

```
 hyperfine -m 100 --show-output 'go test ./acceptance -run ^TestAccept$/^bundle$/^artifacts$/^whl_multiple$ -count=1'
...
            -Uploading my_test_code-0.0.1-py3-none-any.whl...
            -Uploading my_test_code_2-0.0.1-py3-none-any.whl...
            +Uploading my_test_code-0.0.1-py3-none-any.whl...Uploading my_test_code_2-0.0.1-py3-none-any.whl...

Error: Command terminated with non-zero exit code 1 in benchmark iteration 54. Use the '-i'/'--ignore-failure' option if you want to ignore this. Alternatively, use the '--show-output' option to debug what went wrong.
```

An alternative could be to prepare a message fully in a local buffer and
write it in one call (I’m assuming underlying writer is still
synchronized). However, that’s more complicated and unclear if it’s
worth it, perf-wise.

## Tests
With this change I’m running the same hyperfine command with 1000
iterations with no failures.
 2025-03-03 13:42:43 +00:00
Denis Bilenko e4cd782852
Remove bundle.{Parallel,ReadOnlyBundle} (#2414) 
## Changes
- Remove bundle.Parallel & bundle.ReadOnlyBundle.
- Add bundle.ApplyParallel, as a helper to migrate from bundle.Parallel.
- Keep ReadOnlyMutator as a separate type but it's now a subtype of
Mutator so it works on regular *Bundle. Having it as a separate type
prevents non-readonly mutators being passed to ApplyParallel
- validate.Validate becomes a function (was Mutator).

## Why
This a follow up to #2390 where we removed most of the tools to
construct chains of mutators. Same motivation applies here.

When it comes to read-only bundles, it's a leaky abstraction -- since
it's a shallow copy, it does not actually guarantee or enforce readonly
access to bundle. A better approach would be to run parallel operations
on independent narrowly-focused deep-copied structs, with just enough
information to carry out the task (this is not implemented here, but the
eventual goal). Now that we can just write regular code in phases and
not limited to mutator interface, we can switch to that approach.

## Tests
Existing tests.

---------

Co-authored-by: shreyas-goenka <88374338+shreyas-goenka@users.noreply.github.com>
 2025-03-03 13:35:36 +00:00