Commit Graph

195 Commits

Author SHA1 Message Date
Shreyas Goenka e2f4f4d5f1
some final cleanup 2023-01-19 11:34:55 +01:00
Shreyas Goenka e4935642ca
updated formatting on doc strings 2023-01-18 22:59:50 +01:00
Shreyas Goenka d00cee4680
Added generic test 2023-01-18 18:09:18 +01:00
Shreyas Goenka 35c3793579
corrected add to get in getStructFields 2023-01-18 17:45:53 +01:00
Shreyas Goenka 5da5ea0c7a
Moved tracing to safeToSchema 2023-01-18 17:36:50 +01:00
Shreyas Goenka 35d9829b7b
PR is almost done, three things to go, 1. A nice big test, 2. Some cleanup and self review, 3. Address reviews from first round 2023-01-18 17:16:59 +01:00
Shreyas Goenka 9e13a62b00
added tests for errors and handling errors correctly now 2023-01-18 16:58:09 +01:00
Shreyas Goenka 1ee80080d2
Added doc ingension with a test 2023-01-18 16:02:38 +01:00
Shreyas Goenka 2789b61e40
added test for require <-> omitempty 2023-01-18 13:12:01 +01:00
Shreyas Goenka 7e00a80109
added and modified tests to work with it 2023-01-18 12:54:51 +01:00
Shreyas Goenka 1a8627fc26
added test for pointers in structs 2023-01-18 11:02:25 +01:00
Shreyas Goenka 4dfe3cea9a
updated dashed and non annotated field skipping test 2023-01-18 10:44:37 +01:00
Shreyas Goenka 410ba97ebc
updated embedded struct schema test 2023-01-18 10:42:33 +01:00
Shreyas Goenka 8a8f93e150
nit: moved generic test down 2023-01-17 19:32:44 +01:00
Shreyas Goenka f52d090166
added tests for slice of [primitive, slice, map, struct] 2023-01-17 19:31:18 +01:00
Shreyas Goenka ef6737d7de
removed old tests: TestMapOfObjectsSchema, TestSliceOfObjectsSchema 2023-01-17 18:02:14 +01:00
Shreyas Goenka a173d89ffa
added test for map of slice 2023-01-17 17:59:58 +01:00
Shreyas Goenka bd6d0dca57
added test for map of map 2023-01-17 17:57:48 +01:00
Shreyas Goenka 753c54e899
added support for additionalProperties = false for validation and a test for a map of struct 2023-01-17 17:53:58 +01:00
Shreyas Goenka 91617e50c1
added test for map of primitives 2023-01-17 15:47:31 +01:00
Shreyas Goenka f556e62c3b
added tests for struct of map and struct of slice 2023-01-17 15:43:35 +01:00
Shreyas Goenka 2021ca1886
Added test for struct of structs 2023-01-17 15:34:49 +01:00
Shreyas Goenka 019b7d7fa9
added tests for schemas for primitives 2023-01-17 15:08:17 +01:00
Shreyas Goenka ce7b2133bf
Added comments for the schema struct fields 2023-01-17 13:59:56 +01:00
Shreyas Goenka d2f466afc5
replaced properties and items with schema 2023-01-17 13:47:31 +01:00
Shreyas Goenka cc350f761a
correct typo and some comments 2023-01-17 13:43:50 +01:00
Shreyas Goenka e79c52ff37
Added doc string for type mapping 2023-01-17 12:25:25 +01:00
Shreyas Goenka aa81d83970
added ignoring - fields and tests for ignoring dashed and non annotated fields 2023-01-17 11:58:32 +01:00
Shreyas Goenka 2a66a2fc74
added comment for what to do about cycles in json schema 2023-01-17 11:26:46 +01:00
Shreyas Goenka 7385f37df6
fixed typo 2023-01-16 21:53:20 +01:00
Shreyas Goenka 2945408f0d
add test for errWithTrace 2023-01-16 13:19:31 +01:00
Shreyas Goenka 42d82ede6e
- 2023-01-16 02:30:41 +01:00
Shreyas Goenka 4438d1b37c
some todo and comment cleanup 2023-01-16 02:27:49 +01:00
Shreyas Goenka ae201f1bd3
comments and typo correction 2023-01-16 02:23:35 +01:00
Shreyas Goenka 276ba00067
fixed debugTrace 2023-01-13 20:03:24 +01:00
Shreyas Goenka 1ee35c3633
corrected enum 2023-01-13 19:40:09 +01:00
Shreyas Goenka d605ab1aa4
using list for error tracing 2023-01-13 19:37:35 +01:00
Shreyas Goenka 1538422d27
some cleanup 2023-01-13 19:26:50 +01:00
Shreyas Goenka 0f67d7c0d7
added test for embedded structs 2023-01-13 19:25:42 +01:00
Shreyas Goenka b1e85e20f6
cleaned up test boilerplate, added support for maps and embedded types 2023-01-13 19:08:21 +01:00
Shreyas Goenka 010f60d498
added slice of object handling 2023-01-13 18:01:53 +01:00
Shreyas Goenka babd7fa4eb
corrected item typo 2023-01-13 17:28:46 +01:00
Shreyas Goenka cc5ed2bc76
fixed typo, and tested schema is working 2023-01-13 17:13:21 +01:00
Shreyas Goenka 926db54a6d
added tests for primitives and basic objects/arrays 2023-01-13 16:45:01 +01:00
Shreyas Goenka 987dd29357
added recursive limit 2023-01-13 12:09:19 +01:00
Shreyas Goenka d46dbbce6a
WIP json schema support for bundles 2023-01-13 04:52:25 +01:00
Pieter Noordhuis 3582037be6
Add nil check for retries.Info.Info (#166) 2023-01-12 18:58:36 +01:00
Kartik Gupta e48eb6ff50
Fix integration tests for windows (#165)
Successful run: 
Azure:
https://github.com/databricks/eng-dev-ecosystem/actions/runs/3892131225
AWS:
https://github.com/databricks/eng-dev-ecosystem/actions/runs/3892432562
2023-01-11 13:32:02 +01:00
shreyas-goenka bf9f0c06b0
Fix sync integration test failing on aws-prod (#164)
The tests were failing because we were the list of expected files did
not include .gitignore

aws and azure test runs:

https://github.com/databricks/eng-dev-ecosystem/actions/runs/3891837322/jobs/6642552850


https://github.com/databricks/eng-dev-ecosystem/actions/runs/3891836306/jobs/6642550633
2023-01-11 11:50:27 +01:00
shreyas-goenka 0d9ecb5643
Refactor and cover edge cases in sync integration tests (#160)
This PR:
1. Refactors the sync integration tests to make them more readable
2. Adds additional tests for edge cases we encountered during vscode
runs
3. Intensional side effect: sync integration tests are also green on
windows (see
https://github.com/databricks/eng-dev-ecosystem/actions/runs/3817365642/jobs/6493576727)

Change in coverage

- We now test for python notebook <-> python file interconversion and
python notebook deletion being synced to workspace
- Tests are split up and are more focused on testing specific edge cases
2023-01-10 13:16:30 +01:00