mirror of https://github.com/databricks/cli.git
723 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
shreyas-goenka
|
0c837e5772
|
Make `file_path` and `artifact_path` fields consistent with json tag (#987)
## Changes This PR: 1. Renames `FilesPath` -> `FilePath` and `ArtifactsPath` -> `ArtifactPath` in the bundle and metadata configuration to make them consistant with the json tags. 2. Fixes development / production mode error messages to point to `file_path` and `artifact_path` ## Tests Existing unit tests. This is a strightforward renaming of the fields. |
|
Pieter Noordhuis
|
2c908f8fea
|
Function to convert Go struct back to `config.Value` (#935)
## Changes This PR is the counterpart to #904. With this change, we are able to convert a `config.Value` into a Go struct, make modifications to the Go struct, and reflect those changes in a new `config.Value`. This functionality allows us to incrementally introduce this configuration representation to existing bundle mutators. Bundle mutators expect a `*bundle.Bundle` argument and mutate its configuration directly. These mutations are not reflected in the corresponding `config.Value` (once introduced), which means we cannot use the `config.Value` as source of truth until we update _all_ mutators. To address this, we can run `convert.ToTyped` and `convert.FromTyped` at the mutator boundary (from `bundle.Apply`) and capture changes made to the Go struct. Then we can incrementally make mutators aware of the `config.Value` configuration and have them mutate that structure directly. ## Tests New unit tests pass. Manual spot checks against the bundle configuration type. |
|
|
shreyas-goenka
|
a25f10f247
|
Add `--tag` and `--branch` options to bundle init command (#975)
## Tests Tested manually. Specified branch / tag are indeed cloned and used by bundle init. |
|
|
shreyas-goenka
|
b397501880
|
Fix template initialization from current working directory (#976)
## Changes If args[0] == "." was provided to bundle init command, it would try to resolve it as a built in template and error out. ## Tests Manually before: ``` shreyas.goenka@THW32HFW6T mlops-stack % cli bundle init . Error: open /var/folders/lg/njll3hjx7pjcgxs6n7b290bw0000gp/T/templates3934264356/templates/databricks_template_schema.json: no such file or directory ``` after: ``` shreyas.goenka@THW32HFW6T mlops-stack % cli bundle init . Welcome to MLOps Stacks. For detailed information on project generation, see the README at https://github.com/databricks/mlops-stacks/blob/main/README.md. Project Name [my-mlops-project]: ^C ``` |
|
|
shreyas-goenka
|
0f58f6c875
|
Serialise empty files_path and job.relative_path in the deployment metadata (#984)
## Changes The Jobs service expects these fields to always be present in the metadata in their validation logic, which is reasonable. This PR removes the omit empty tags so these fields are always uploaded to the workspace `metadata.json` file. |
|
Lennart Kats (databricks)
|
0ab125c109
|
Allow jobs to be manually unpaused in development mode (#885)
Partly mitigates #859. It's still not clear to me if there is an actual use case or if users are trying to use "development" mode jobs for production, but making this overridable is reasonable. Beyond this fix I think we could do something in the Jobs schedule UI, but it would help to better understand the use case (or actual reason of confusion). I expect we should hint customers to move away from dev mode rather than unpause. |
|
dependabot[bot]
|
c3ced68c60
|
Bump github.com/databricks/databricks-sdk-go from 0.24.0 to 0.25.0 (#980)
Bumps [github.com/databricks/databricks-sdk-go](https://github.com/databricks/databricks-sdk-go) from 0.24.0 to 0.25.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/databricks/databricks-sdk-go/blob/main/CHANGELOG.md">github.com/databricks/databricks-sdk-go's changelog</a>.</em></p> <blockquote> <h2>0.25.0</h2> <ul> <li>Make sure path parameters are first in order in RequiredFields (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/669">#669</a>).</li> <li>Added Field.IsRequestBodyField method for code generation (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/670">#670</a>).</li> <li>Added regressions question to the issue template (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/676">#676</a>).</li> <li>Added telemetry for CI/CD platform to useragent (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/665">#665</a>).</li> <li>Skiped GCP Integration Tests using Statement Execution API (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/678">#678</a>).</li> <li>Added more detailed error message on default credentials not found error (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/679">#679</a>).</li> <li>Updated SDK to latest OpenAPI Spec (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/685">#685</a>).</li> </ul> <p>API Changes:</p> <ul> <li>Changed <code>Create</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionsAPI">w.Functions</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#MetastoresAPI">w.Metastores</a> workspace-level service with new required argument order.</li> <li>Changed <code>InputParams</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateFunction">catalog.CreateFunction</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionInfo">catalog.FunctionInfo</a> to <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionParameterInfos">catalog.FunctionParameterInfos</a>.</li> <li>Changed <code>Properties</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateFunction">catalog.CreateFunction</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionInfo">catalog.FunctionInfo</a> to <code>string</code>.</li> <li>Changed <code>ReturnParams</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateFunction">catalog.CreateFunction</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionInfo">catalog.FunctionInfo</a> to <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionParameterInfos">catalog.FunctionParameterInfos</a></li> <li>Changed <code>StorageRoot</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateMetastore">catalog.CreateMetastore</a> to no longer be required.</li> <li>Added <code>SkipValidation</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#UpdateExternalLocation">catalog.UpdateExternalLocation</a>.</li> <li>Added <code>Libraries</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#CreatePolicy">compute.CreatePolicy</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EditPolicy">compute.EditPolicy</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#Policy">compute.Policy</a>.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InitScriptEventDetails">compute.InitScriptEventDetails</a>.</li> <li>Added <code>InitScripts</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#EventDetails">compute.EventDetails</a>.</li> <li>Added <code>File</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InitScriptInfo">compute.InitScriptInfo</a>.</li> <li>Added <code>ZoneId</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InstancePoolGcpAttributes">compute.InstancePoolGcpAttributes</a>.</li> <li>Added <code>IncludeResolvedValues</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#GetRunRequest">jobs.GetRunRequest</a>.</li> <li>Added <code>EditMode</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob">jobs.CreateJob</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings">jobs.JobSettings</a>.</li> <li>Added <code>NetworkConnectivityConfigId</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/provisioning#UpdateWorkspaceRequest">provisioning.UpdateWorkspaceRequest</a>.</li> <li>Added <code>ContainerLogs</code> and <code>ExtraInfo</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#DeploymentStatus">serving.DeploymentStatus</a>.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#CreateFunctionRequest">catalog.CreateFunctionRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#DependencyList">catalog.DependencyList</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/catalog#FunctionParameterInfos">catalog.FunctionParameterInfos</a>.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InitScriptExecutionDetails">compute.InitScriptExecutionDetails</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InitScriptExecutionDetailsStatus">compute.InitScriptExecutionDetailsStatus</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#InitScriptInfoAndExecutionDetails">compute.InitScriptInfoAndExecutionDetails</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/compute#LocalFileInfo">compute.LocalFileInfo</a>.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJobEditMode">jobs.CreateJobEditMode</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettingsEditMode">jobs.JobSettingsEditMode</a>.</li> <li>Added <code>DeleteApp</code>, <code>GetApp</code>, <code>GetAppDeploymentStatus</code>, <code>GetApps</code> and <code>GetEvents</code> method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI">w.Apps</a> workspace-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppEvents">serving.AppEvents</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppServiceStatus">serving.AppServiceStatus</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#DeleteAppResponse">serving.DeleteAppResponse</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#GetAppDeploymentStatusRequest">serving.GetAppDeploymentStatusRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#GetAppResponse">serving.GetAppResponse</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#GetEventsRequest">serving.GetEventsRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ListAppEventsResponse">serving.ListAppEventsResponse</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#ListAppsResponse">serving.ListAppsResponse</a>.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NetworkConnectivityAPI">a.NetworkConnectivity</a> account-level service.</li> <li>Added <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#CreateNetworkConnectivityConfigRequest">settings.CreateNetworkConnectivityConfigRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#CreatePrivateEndpointRuleRequest">settings.CreatePrivateEndpointRuleRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#CreatePrivateEndpointRuleRequestGroupId">settings.CreatePrivateEndpointRuleRequestGroupId</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeleteNetworkConnectivityConfigurationRequest">settings.DeleteNetworkConnectivityConfigurationRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#DeletePrivateEndpointRuleRequest">settings.DeletePrivateEndpointRuleRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetNetworkConnectivityConfigurationRequest">settings.GetNetworkConnectivityConfigurationRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#GetPrivateEndpointRuleRequest">settings.GetPrivateEndpointRuleRequest</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccAzurePrivateEndpointRule">settings.NccAzurePrivateEndpointRule</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccAzurePrivateEndpointRuleConnectionState">settings.NccAzurePrivateEndpointRuleConnectionState</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccAzurePrivateEndpointRuleGroupId">settings.NccAzurePrivateEndpointRuleGroupId</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccAzureServiceEndpointRule">settings.NccAzureServiceEndpointRule</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccEgressConfig">settings.NccEgressConfig</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccEgressDefaultRules">settings.NccEgressDefaultRules</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NccEgressTargetRules">settings.NccEgressTargetRules</a>, <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/settings#NetworkConnectivityConfiguration">settings.NetworkConnectivityConfiguration</a>.</li> <li>Removed <code>Delete</code>, <code>Get</code>, method for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/serving#AppsAPI">w.Apps</a> workspace-level service.</li> <li>Removed <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettingsUiState">jobs.JobSettingsUiState</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJobUiState">jobs.CreateJobUiState</a>.</li> <li>Removed <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#OAuthEnrollmentAPI">a.OAuthEnrollment</a> account-level service.</li> <li>Removed <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#CreateOAuthEnrollment">oauth2.CreateOAuthEnrollment</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/oauth2#OAuthEnrollmentStatus">oauth2.OAuthEnrollmentStatus</a>.</li> <li>Removed <code>UiState</code> field for <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#CreateJob">jobs.CreateJob</a> and <a href="https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/jobs#JobSettings">jobs.JobSettings</a>.</li> </ul> <p>OpenAPI SHA: e7b127cb07af8dd4d8c61c7cc045c8910cdbb02a, Date: 2023-11-08 Dependency updates:</p> <ul> <li>Bump google.golang.org/api from 0.146.0 to 0.150.0 (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/683">#683</a>).</li> <li>Bump golang.org/x/mod from 0.13.0 to 0.14.0 (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/681">#681</a>).</li> <li>Bump google.golang.org/grpc from 1.58.2 to 1.58.3 in /examples/slog (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/672">#672</a>).</li> <li>Bump google.golang.org/grpc to 1.58.3 in /examples/zerolog (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/684">#684</a>).</li> <li>Bump golang.org/x/time from 0.3.0 to 0.4.0 (<a href="https://redirect.github.com/databricks/databricks-sdk-go/pull/680">#680</a>).</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
b2055ed49e
|
Bump golang.org/x/oauth2 from 0.13.0 to 0.14.0 (#982)
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.13.0 to 0.14.0. <details> <summary>Commits</summary> <ul> <li><a href=" |
|
Andrew Nester
|
f3db42e622
|
Added support for top-level permissions (#928)
## Changes
Now it's possible to define top level `permissions` section in bundle
configuration and permissions defined there will be applied to all
resources defined in the bundle.
Supported top-level permission levels: CAN_MANAGE, CAN_VIEW, CAN_RUN.
Permissions are applied to: Jobs, DLT Pipelines, ML Models, ML
Experiments and Model Service Endpoints
```
bundle:
name: permissions
workspace:
host: ***
permissions:
- level: CAN_VIEW
group_name: test-group
- level: CAN_MANAGE
user_name: user@company.com
- level: CAN_RUN
service_principal_name: 123456-abcdef
```
## Tests
Added corresponding unit tests + ran `bundle validate` and `bundle
deploy` manually
|
|
|
dependabot[bot]
|
14d2d0a2d5
|
Bump github.com/hashicorp/terraform-json from 0.17.1 to 0.18.0 (#979)
Bumps [github.com/hashicorp/terraform-json](https://github.com/hashicorp/terraform-json) from 0.17.1 to 0.18.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/hashicorp/terraform-json/releases">github.com/hashicorp/terraform-json's releases</a>.</em></p> <blockquote> <h2>v0.18.0</h2> <p>NOTES:</p> <ul> <li>Update README to explain when not to use this library by <a href="https://github.com/alisdair"><code>@alisdair</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/104">hashicorp/terraform-json#104</a></li> </ul> <p>ENHANCEMENTS:</p> <ul> <li>Add PreviousAddress field to ResourceChange to support moved block by <a href="https://github.com/takaishi"><code>@takaishi</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/95">hashicorp/terraform-json#95</a></li> </ul> <p>BUG FIXES:</p> <ul> <li>Fixed typing of check results in statefiles by <a href="https://github.com/Yantrio"><code>@Yantrio</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/101">hashicorp/terraform-json#101</a></li> </ul> <p>INTERNAL:</p> <ul> <li>Bump actions/setup-go from 4.0.1 to 4.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/98">hashicorp/terraform-json#98</a></li> <li>Bump github.com/zclconf/go-cty from 1.13.2 to 1.13.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/99">hashicorp/terraform-json#99</a></li> <li>Bump actions/checkout from 3.5.3 to 3.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/100">hashicorp/terraform-json#100</a></li> <li>Bump github.com/zclconf/go-cty from 1.13.3 to 1.14.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/102">hashicorp/terraform-json#102</a></li> <li>Bump actions/checkout from 3.6.0 to 4.0.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/103">hashicorp/terraform-json#103</a></li> <li>Bump actions/checkout from 4.0.0 to 4.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/105">hashicorp/terraform-json#105</a></li> <li>Bump github.com/zclconf/go-cty from 1.14.0 to 1.14.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/107">hashicorp/terraform-json#107</a></li> <li>Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/109">hashicorp/terraform-json#109</a></li> <li>Bump actions/checkout from 4.1.0 to 4.1.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/110">hashicorp/terraform-json#110</a></li> </ul> <p>New Contributors</p> <ul> <li><a href="https://github.com/Yantrio"><code>@Yantrio</code></a> made their first contribution in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/101">hashicorp/terraform-json#101</a></li> <li><a href="https://github.com/takaishi"><code>@takaishi</code></a> made their first contribution in <a href="https://redirect.github.com/hashicorp/terraform-json/pull/95">hashicorp/terraform-json#95</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
ef76fe02f0
|
Bump golang.org/x/term from 0.13.0 to 0.14.0 (#981)
Bumps [golang.org/x/term](https://github.com/golang/term) from 0.13.0 to 0.14.0. <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
Andrew Nester
|
ea4153e323
|
Fixed flaky TestBackgroundCombinedOutputFailure (#978)
## Changes `TestBackgroundCombinedOutputFailure` was occasionally failing because combined output could have been in different order, see https://github.com/databricks/cli/actions/runs/6823883271/job/18558675165?pr=928 |
|
Ilia Babanov
|
e82a49b4e9
|
Make `databricks configure` save only explicit fields (#973)
## Changes Save only explicit fields to the config file This applies to two commands: `configure` and `auth login`. The latter only pulls env vars in the case of the `--configure-cluster` flag ## Tests Manual, plus additional unit test for the `configure` command |
|
|
shreyas-goenka
|
f208853626
|
Fix integration test asserting errors on unknown template parameters (#977)
## Changes Recent descriptions were made mandatory for input parameters so this test started failing. ## Tests The test passes now. |
|
Serge Smertin
|
3284a8c56c
|
Improved usability of `databricks auth login ... --configure-cluster` flow by displaying cluster type and runtime version (#956)
This PR adds selectors for Databricks-connect compatible clusters and SQL warehouses Tested in https://github.com/databricks/cli/pull/914 |
|
|
Serge Smertin
|
f111b0846e
|
Added process stubbing for easier testing of launched subprocesses (#963)
## Changes
This PR makes unit testing with subprocesses fast.
```
ctx := context.Background()
ctx, stub := process.WithStub(ctx)
stub.WithDefaultOutput("meeee")
ctx = env.Set(ctx, "FOO", "bar")
out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"})
require.NoError(t, err)
require.Equal(t, "meeee", out)
require.Equal(t, 1, stub.Len())
require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands())
allEnv := stub.CombinedEnvironment()
require.Equal(t, "bar", allEnv["FOO"])
require.Equal(t, "bar", stub.LookupEnv("FOO"))
```
This should make further iterations of
https://github.com/databricks/cli/pull/914 easier
## Tests
`make test`
|
|
|
Serge Smertin
|
d4c0027556
|
Add `--debug` as shortcut for `--log-level debug` (#964)
## Changes This PR exposes simpler interfaces to end users. ## Tests <img width="724" alt="image" src="https://github.com/databricks/cli/assets/259697/8bd25110-33f0-4197-8f00-2b8198c4aba6"> |
|
|
shreyas-goenka
|
d4d4b7480f
|
Do not allow empty descriptions for bundle template inputs (#967)
## Changes We rely on the descriptions to render the prompts to a user. Thus we should not allow empty descriptions here. Note, both mlops stacks and the default-python template have descriptions for all their properties so this should not be an issue. ## Tests Unit test |
|
|
Andrew Nester
|
b72f2a9604
|
Release v0.209.1 (#969)
CLI: * Hide `--progress-format` global flag ([#965](https://github.com/databricks/cli/pull/965)). * Make configure command visible + fix bundle command description ([#961](https://github.com/databricks/cli/pull/961)). * Log process ID in each log entry ([#949](https://github.com/databricks/cli/pull/949)). * Improve error message when `--json` flag is specified ([#933](https://github.com/databricks/cli/pull/933)). Bundles: * Remove validation for default value against pattern ([#959](https://github.com/databricks/cli/pull/959)). * Bundle path rewrites for dbt and SQL file tasks ([#962](https://github.com/databricks/cli/pull/962)). * Initialize variable definitions that are defined without properties ([#966](https://github.com/databricks/cli/pull/966)). Internal: * Function to merge two instances of `config.Value` ([#938](https://github.com/databricks/cli/pull/938)). * Make to/from string methods private to the jsonschema package ([#942](https://github.com/databricks/cli/pull/942)). * Make Cobra runner compatible with testing interactive flows ([#957](https://github.com/databricks/cli/pull/957)). * Added `env.UserHomeDir(ctx)` for parallel-friendly tests ([#955](https://github.com/databricks/cli/pull/955)). Dependency updates: * Bump golang.org/x/mod from 0.13.0 to 0.14.0 ([#954](https://github.com/databricks/cli/pull/954)). * Bump golang.org/x/text from 0.13.0 to 0.14.0 ([#953](https://github.com/databricks/cli/pull/953)). * Bump golang.org/x/sync from 0.4.0 to 0.5.0 ([#951](https://github.com/databricks/cli/pull/951)). * Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 ([#950](https://github.com/databricks/cli/pull/950)). * Bump github.com/fatih/color from 1.15.0 to 1.16.0 ([#952](https://github.com/databricks/cli/pull/952)). |
|
|
Andrew Nester
|
47e434db2f
|
Improve error message when `--json` flag is specified (#933)
## Changes Improve error message when --json input is provided ## Tests ``` cli % databricks model-registry create-model mymodel --json @./input.json Error: when --json flag is specified, no positional arguments are required. Provide NAME in your JSON input ``` |
|
|
Serge Smertin
|
e68a88e14d
|
Added `env.UserHomeDir(ctx)` for parallel-friendly tests (#955)
## Changes `os.Getenv(..)` is not friendly with `libs/env`. This PR makes the relevant changes to places where we need to read user home directory. ## Tests Mainly done in https://github.com/databricks/cli/pull/914 |
|
|
Pieter Noordhuis
|
7847388f95
|
Initialize variable definitions that are defined without properties (#966)
## Changes We can debate whether or not variable definitions without properties are valid, but in no case should this panic the CLI. Fixes #934. ## Tests Unit. |
|
|
Ilia Babanov
|
65dd9c5c0f
|
Log process ID in each log entry (#949)
## Changes This will help differentiate multiple cli commands that write to the same log file. Noticed that the root module wasn't using the common log utilities, refactored it to avoid missing log arguments. Relevant PR on the databricks vscode extension side: https://github.com/databricks/databricks-vscode/pull/923 ## Tests Tested manually for sdk and cli loggers |
|
|
Serge Smertin
|
7509e4d55a
|
Hide `--progress-format` global flag (#965)
## Changes At the moment, these flags are mostly used for VSCode integration for bundles, but they're not effective for the majority of commands. ## Tests <img width="559" alt="image" src="https://github.com/databricks/cli/assets/259697/15ddd322-f746-48ad-b1ce-35c55e664a06"> |
|
|
Andrew Nester
|
f07832746b
|
Make configure command visible + fix bundle command description (#961)
## Changes Fixes #936 #937 |
|
Michał Szafrański
|
10291b0e13
|
Bundle path rewrites for dbt and SQL file tasks (#962)
## Changes Support path rewrites for Dbt and SQL file job taks. <!-- Summary of your changes that are easy to understand --> ## Tests * Added unit test <!-- How is this tested? --> |
|
|
Serge Smertin
|
56bcb6f833
|
Make Cobra runner compatible with testing interactive flows (#957)
## Changes This PR enables testing commands with stdin ## Tests https://github.com/databricks/cli/pull/914 |
|
|
shreyas-goenka
|
283f24179d
|
Remove validation for default value against pattern (#959)
## Changes
This PR removes validation for default value against the regex pattern
specified in a JSON schema at schema load time. This is required because
https://github.com/databricks/cli/pull/795 introduces parameterising the
default value as a Go text template impling that the default value now
does not necessarily have to match the pattern at schema load time.
This will also unblock:
https://github.com/databricks/mlops-stacks/pull/108
Note, this does not remove runtime validation for input parameters right
before template initialization, which happens here:
|
|
|
dependabot[bot]
|
677f28e2fb
|
Bump github.com/fatih/color from 1.15.0 to 1.16.0 (#952)
Bumps [github.com/fatih/color](https://github.com/fatih/color) from 1.15.0 to 1.16.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/fatih/color/releases">github.com/fatih/color's releases</a>.</em></p> <blockquote> <h2>v1.16.0</h2> <h2>What's Changed</h2> <ul> <li>Update dependabot.yml by <a href="https://github.com/ilyabrin"><code>@ilyabrin</code></a> in <a href="https://redirect.github.com/fatih/color/pull/200">fatih/color#200</a></li> <li>color: add newline after wrapping text by <a href="https://github.com/fatih"><code>@fatih</code></a> in <a href="https://redirect.github.com/fatih/color/pull/192">fatih/color#192</a></li> <li>[Test] Nil check added by <a href="https://github.com/hyunsooda"><code>@hyunsooda</code></a> in <a href="https://redirect.github.com/fatih/color/pull/203">fatih/color#203</a></li> <li>fixes <a href="https://redirect.github.com/fatih/color/issues/206">#206</a> (using underline with a different fg color breaks) by <a href="https://github.com/gregpoirson"><code>@gregpoirson</code></a> in <a href="https://redirect.github.com/fatih/color/pull/210">fatih/color#210</a></li> </ul> <h3>Dependency updates</h3> <ul> <li>Bump dominikh/staticcheck-action from 1.2.0 to 1.3.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/201">fatih/color#201</a></li> <li>Bump github.com/mattn/go-isatty from 0.0.17 to 0.0.18 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/193">fatih/color#193</a></li> <li>Bump golang.org/x/sys from 0.6.0 to 0.8.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/195">fatih/color#195</a></li> <li>Bump github.com/mattn/go-isatty from 0.0.18 to 0.0.19 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/196">fatih/color#196</a></li> <li>Bump golang.org/x/sys from 0.8.0 to 0.10.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/199">fatih/color#199</a></li> <li>Bump github.com/mattn/go-isatty from 0.0.19 to 0.0.20 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/212">fatih/color#212</a></li> <li>Bump golang.org/x/sys from 0.10.0 to 0.13.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/209">fatih/color#209</a></li> <li>Bump actions/setup-go from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/202">fatih/color#202</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/208">fatih/color#208</a></li> <li>Bump golang.org/x/sys from 0.13.0 to 0.14.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/fatih/color/pull/213">fatih/color#213</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/ilyabrin"><code>@ilyabrin</code></a> made their first contribution in <a href="https://redirect.github.com/fatih/color/pull/200">fatih/color#200</a></li> <li><a href="https://github.com/hyunsooda"><code>@hyunsooda</code></a> made their first contribution in <a href="https://redirect.github.com/fatih/color/pull/203">fatih/color#203</a></li> <li><a href="https://github.com/gregpoirson"><code>@gregpoirson</code></a> made their first contribution in <a href="https://redirect.github.com/fatih/color/pull/210">fatih/color#210</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/fatih/color/compare/v1.15.0...v1.16.0">https://github.com/fatih/color/compare/v1.15.0...v1.16.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
4b18f117d3
|
Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 (#950)
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/cobra/releases">github.com/spf13/cobra's releases</a>.</em></p> <blockquote> <h2>v1.8.0</h2> <h2>✨ Features</h2> <ul> <li>Support usage as plugin for tools like kubectl by <a href="https://github.com/nirs"><code>@nirs</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2018">spf13/cobra#2018</a> - this means that programs that utilize a "plugin-like" structure have much better support and usage (like for completions, command paths, etc.)</li> <li>Move documentation sources to site/content by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1428">spf13/cobra#1428</a></li> <li>Add 'one required flag' group by <a href="https://github.com/marevers"><code>@marevers</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1952">spf13/cobra#1952</a> - this includes a new <code>MarkFlagsOneRequired</code> API for flags which can be used to mark a flag group as required and cause command failure if at least one is not used when invoked.</li> <li>Customizable error message prefix by <a href="https://github.com/5ouma"><code>@5ouma</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2023">spf13/cobra#2023</a> - This adds the <code>SetErrPrefix</code> and <code>ErrPrefix</code> APIs on the <code>Command</code> struct to allow for setting a custom prefix for errors</li> <li>feat: add getters for flag completions by <a href="https://github.com/avirtopeanu-ionos"><code>@avirtopeanu-ionos</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1943">spf13/cobra#1943</a></li> <li>Feature: allow running persistent run hooks of all parents by <a href="https://github.com/vkhoroz"><code>@vkhoroz</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2044">spf13/cobra#2044</a></li> <li>Improve API to get flag completion function by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2063">spf13/cobra#2063</a></li> </ul> <h2>🐛 Bug fixes</h2> <ul> <li>Fix typo in fish completions by <a href="https://github.com/twpayne"><code>@twpayne</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1945">spf13/cobra#1945</a></li> <li>Fix grammar: 'allows to' by <a href="https://github.com/supertassu"><code>@supertassu</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1978">spf13/cobra#1978</a></li> <li>powershell: escape variable with curly brackets by <a href="https://github.com/Luap99"><code>@Luap99</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1960">spf13/cobra#1960</a></li> <li>Don't complete --help flag when flag parsing disabled by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2061">spf13/cobra#2061</a></li> <li>Replace all non-alphanumerics in active help env var program prefix by <a href="https://github.com/scop"><code>@scop</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1940">spf13/cobra#1940</a></li> </ul> <h2>🔧 Maintenance</h2> <ul> <li>build(deps): bump golangci/golangci-lint-action from 3.4.0 to 3.5.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1971">spf13/cobra#1971</a></li> <li>build(deps): bump golangci/golangci-lint-action from 3.5.0 to 3.6.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1976">spf13/cobra#1976</a></li> <li>build(deps): bump golangci/golangci-lint-action from 3.6.0 to 3.7.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2021">spf13/cobra#2021</a></li> <li>build(deps): bump actions/setup-go from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1934">spf13/cobra#1934</a></li> <li>build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.2 to 2.0.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2047">spf13/cobra#2047</a></li> <li>build(deps): bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2028">spf13/cobra#2028</a></li> <li>command: temporarily disable G602 due to <a href="https://redirect.github.com/securego/gosec/issues/1005">securego/gosec#1005</a> by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2022">spf13/cobra#2022</a></li> </ul> <h2>🧪 Testing & CI/CD</h2> <ul> <li>test: make fish_completions_test more robust by <a href="https://github.com/branchvincent"><code>@branchvincent</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1980">spf13/cobra#1980</a></li> <li>golangci: enable 'unused' and disable deprecated replaced by it by <a href="https://github.com/umarcor"><code>@umarcor</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/1983">spf13/cobra#1983</a></li> <li>cleanup: minor corrections to unit tests by <a href="https://github.com/JunNishimura"><code>@JunNishimura</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2003">spf13/cobra#2003</a></li> <li>ci: test golang 1.21 by <a href="https://github.com/nunoadrego"><code>@nunoadrego</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2024">spf13/cobra#2024</a></li> <li>Fix linter errors by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2052">spf13/cobra#2052</a></li> <li>Add tests for flag completion registration by <a href="https://github.com/marckhouzam"><code>@marckhouzam</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2053">spf13/cobra#2053</a></li> </ul> <h2>✏️ Documentation</h2> <ul> <li>doc: fix typo, Deperecated -> Deprecated by <a href="https://github.com/callthingsoff"><code>@callthingsoff</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2000">spf13/cobra#2000</a></li> <li>Add notes to doc about the execution condition of *PreRun and *PostRun functions by <a href="https://github.com/haoming29"><code>@haoming29</code></a> in <a href="https://redirect.github.com/spf13/cobra/pull/2041">spf13/cobra#2041</a></li> </ul> <hr /> <p>Thank you everyone who contributed to this release and all your hard work! Cobra and this community would never be possible without all of you!!!! 🐍</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0">https://github.com/spf13/cobra/compare/v1.7.0...v1.8.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
|
|
dependabot[bot]
|
83820a3a67
|
Bump golang.org/x/sync from 0.4.0 to 0.5.0 (#951)
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.4.0 to
0.5.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="
|
|
|
dependabot[bot]
|
b5a438ea62
|
Bump golang.org/x/text from 0.13.0 to 0.14.0 (#953)
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.13.0 to
0.14.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="
|
|
|
dependabot[bot]
|
9eec6da29b
|
Bump golang.org/x/mod from 0.13.0 to 0.14.0 (#954)
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.13.0 to
0.14.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="
|
|
|
shreyas-goenka
|
fb32e78c9b
|
Make to/from string methods private to the jsonschema package (#942)
## Changes This PR makes a few methods private, exposing cleaner interfaces to get the string representations for enums and default values of a JSON Schema. ## Tests Manually, template initialization for the `default-python` template still works as expected. |
|
|
Pieter Noordhuis
|
8e1156edbd
|
Function to merge two instances of `config.Value` (#938)
## Changes Semantics for merging two instances of `config.Value`: * Merging x with nil or nil with x always yields x * Merging maps a and b means entries from map b take precedence * Merging sequences a and b means concatenating them These are the same semantics that we use today when calling into mergo in `bundle/config`. ## Tests Unit tests pass. |
|
|
shreyas-goenka
|
401ae3dc99
|
Remove mention of Lakehouse apps from the changelog (#945) | |
|
shreyas-goenka
|
51d41d6c44
|
Release v0.209.0 (#944)
CLI: * Added GitHub issue templates for CLI and DABs issues ([#925](https://github.com/databricks/cli/pull/925)). * Added override to support YAML inputs for apps ([#921](https://github.com/databricks/cli/pull/921)). * Simplified code generation logic for handling path and request body parameters and JSON input ([#905](https://github.com/databricks/cli/pull/905)). Bundles: * Fixed URL for bundle template documentation in init command help docs ([#903](https://github.com/databricks/cli/pull/903)). * Fixed pattern validation for input parameters in a bundle template ([#912](https://github.com/databricks/cli/pull/912)). * Fixed multiline description rendering for enum input parameters in bundle templates ([#916](https://github.com/databricks/cli/pull/916)). * Changed production mode check for whether identity used is a service principal to use UserName ([#924](https://github.com/databricks/cli/pull/924)). * Changed bundle deploy to upload partial terraform state even if deployment fails ([#923](https://github.com/databricks/cli/pull/923)). * Added support for welcome messages to bundle templates ([#907](https://github.com/databricks/cli/pull/907)). * Added support for uploading bundle deployment metadata to WSFS ([#845](https://github.com/databricks/cli/pull/845)). Internal: * Loading an empty yaml file yields a nil ([#906](https://github.com/databricks/cli/pull/906)). * Library to convert config.Value to Go struct ([#904](https://github.com/databricks/cli/pull/904)). * Remove default resolution of repo names against the Databricks Github account([#940](https://github.com/databricks/cli/pull/940)). * Run make fmt from fmt job ([#929](https://github.com/databricks/cli/pull/929)). * `make snapshot` to build file in `.databricks/databricks` ([#927](https://github.com/databricks/cli/pull/927)). * Add configuration normalization code ([#915](https://github.com/databricks/cli/pull/915)). API Changes: * Added `databricks apps` command group. * Added `databricks account network-policy` command group. Dependency updates: * Bump Terraform provider from v1.28.0 to v1.29.0 ([#926](https://github.com/databricks/cli/pull/926)). * Bump the Go SDK in the CLI from v0.23 to v0.24 ([#919](https://github.com/databricks/cli/pull/919)). * Bump google.golang.org/grpc from 1.58.2 to 1.58.3 ([#920](https://github.com/databricks/cli/pull/920)). * Bump github.com/google/uuid from 1.3.1 to 1.4.0 ([#932](https://github.com/databricks/cli/pull/932)). OpenAPI commit 5903bb39137fd76ac384b2044e425f9c56840e00 (2023-10-23) |
|
|
shreyas-goenka
|
b6aa4631f1
|
Fix metadata computation for empty bundle (#939)
## Changes This PR fixes metadata computation for empty bundle. Before we would error because the `terraform.Load()` mutator errors on a empty / no state file. ## Tests Failing integration tests now pass. |
|
|
shreyas-goenka
|
d70d7445c4
|
Remove resolution of repo names against the Databricks Github account (#940)
## Changes
This functionality is not exercised (and will not be anytime soon).
Instead we use a map to have first party aliases for supported
templates.
|
|
|
dependabot[bot]
|
1e46b9f88a
|
Bump github.com/google/uuid from 1.3.1 to 1.4.0 (#932)
Bumps [github.com/google/uuid](https://github.com/google/uuid) from 1.3.1 to 1.4.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/google/uuid/releases">github.com/google/uuid's releases</a>.</em></p> <blockquote> <h2>v1.4.0</h2> <h2><a href="https://github.com/google/uuid/compare/v1.3.1...v1.4.0">1.4.0</a> (2023-10-26)</h2> <h3>Features</h3> <ul> <li>UUIDs slice type with Strings() convenience method (<a href="https://redirect.github.com/google/uuid/issues/133">#133</a>) (<a href=" |
|
|
shreyas-goenka
|
82a71ef33b
|
Add GitHub issue templates (#925)
This PR adds a few github issue templates, allowing customers to give feedback and report issues in a more structured way. |
|
Taiga Matsumoto
|
e408b701ac
|
Add override to support YAML inputs for apps (#921)
## Changes <!-- Summary of your changes that are easy to understand --> Take @andrefurlan-db 's original [commit](https://github.com/databricks/cli/compare/databricks:6e21ced...andrefurlan-db:12ed10c) to add `apps` support to the CLI and add the yaml file-support as an override (the apps routes are already apart of the Go SDK and are available for use in the CLI) **NOTE: this feature is still private preview. CLI usage will be internal only** ## Tests <!-- How is this tested? --> |
|
|
Pieter Noordhuis
|
b91fab7d09
|
Run make fmt from fmt job (#929)
## Changes I noticed we weren't running `goimports` from our formatting job. If we run `make fmt`, we do. ## Tests The fmt job passes. |
|
|
shreyas-goenka
|
5a8cd0c5bc
|
Persist deployment metadata in WSFS (#845)
## Changes
This PR introduces a metadata struct that stores a subset of bundle
configuration that we wish to expose to other Databricks services that
wish to integrate with bundles.
This metadata file is uploaded to a file
`${bundle.workspace.state_path}/metadata.json` in the WSFS destination
of the bundle deployment.
Documentation for emitted metadata fields:
* `version`: Version for the metadata file schema
* `config.bundle.git.branch`: Name of the git branch the bundle was
deployed from.
* `config.bundle.git.origin_url`: URL for git remote "origin"
* `config.bundle.git.bundle_root_path`: Relative path of the bundle root
from the root of the git repository. Is set to "." if they are the same.
* `config.bundle.git.commit`: SHA-1 commit hash of the exact commit this
bundle was deployed from. Note, the deployment might not exactly match
this commit version if there are changes that have not been committed to
git at deploy time,
* `file_path`: Path in workspace where we sync bundle files to.
* `resources.jobs.[job-ref].id`: Id of the job
* `resources.jobs.[job-ref].relative_path`: Relative path of the yaml
config file from the bundle root where this job was defined.
Example metadata object when bundle root and git root are the same:
```json
{
"version": 1,
"config": {
"bundle": {
"lock": {},
"git": {
"branch": "master",
"origin_url": "www.host.com",
"commit": "7af8e5d3f5dceffff9295d42d21606ccf056dce0",
"bundle_root_path": "."
}
},
"workspace": {
"file_path": "/Users/shreyas.goenka@databricks.com/.bundle/pipeline-progress/default/files"
},
"resources": {
"jobs": {
"bar": {
"id": "245921165354846",
"relative_path": "databricks.yml"
}
}
},
"sync": {}
}
}
```
Example metadata when the git root is one level above the bundle repo:
```json
{
"version": 1,
"config": {
"bundle": {
"lock": {},
"git": {
"branch": "dev-branch",
"origin_url": "www.my-repo.com",
"commit": "3db46ef750998952b00a2b3e7991e31787e4b98b",
"bundle_root_path": "pipeline-progress"
}
},
"workspace": {
"file_path": "/Users/shreyas.goenka@databricks.com/.bundle/pipeline-progress/default/files"
},
"resources": {
"jobs": {
"bar": {
"id": "245921165354846",
"relative_path": "databricks.yml"
}
}
},
"sync": {}
}
}
```
This unblocks integration to the jobs break glass UI for bundles.
## Tests
Unit tests and integration tests.
|
|
|
Serge Smertin
|
905fe10e62
|
`make snapshot` to build file in `.databricks/databricks` (#927)
Goreleaser builds binary in 10-15 seconds, but go build does it just in 3-5 seconds. Target is `.databricks` folder in the current checkout, which is already in `.gitignore`. Make sure you have the following $PATH: ``` PATH="/path/to/cli/checkout/.databricks:$PATH" ``` |
|
|
shreyas-goenka
|
bb662fadbb
|
Bump Terraform provider to v1.29.0 (#926)
This PR: 1. Regenerates go structs using provider version 1.29 2. Adds QOL autogenerated diff labels for github 3. Adds a small SOP for doing the tf provider bump for go structs |
|
|
Andrew Nester
|
6f22ae8696
|
Use UserName instead of Id to check if identity used is a service principal (#924)
## Changes Use UserName instead of Id to check if identity used is a service principal |
|
|
Andrew Nester
|
19e00d2d47
|
Upload terraform state even if apply fails (#923)
## Changes Upload terraform state even if apply fails Fixes #893 ## Tests Manually running `databricks bundle deploy` with incorrect permissions in bundle config and observe that it gets uploaded correctly |
|
Miles Yucht
|
9b16e9bd45
|
Bump the Go SDK in the CLI (#919)
## Changes Bump the Databricks Go SDK version from v0.23.0 to v0.24.0. ## Tests <!-- How is this tested? --> |
|
|
dependabot[bot]
|
01f669555d
|
Bump google.golang.org/grpc from 1.58.2 to 1.58.3 (#920)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.2 to 1.58.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p> <blockquote> <h2>Release 1.58.3</h2> <h1>Security</h1> <ul> <li> <p>server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)</p> <p>In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |